Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3491971rwb; Sat, 3 Dec 2022 05:56:14 -0800 (PST) X-Google-Smtp-Source: AA0mqf676sG6icdHorH8JpYYbKXmPIltQDSLhHo765AZDhcrrFrBAP9DuvCQaKzuI2M2D8tmALqt X-Received: by 2002:a05:6402:5513:b0:467:7026:515e with SMTP id fi19-20020a056402551300b004677026515emr68102477edb.26.1670075774581; Sat, 03 Dec 2022 05:56:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670075774; cv=none; d=google.com; s=arc-20160816; b=cS9PSur1WxL7jH7YgQHLYkxTUVoDCEFyundp5GBGTDSGKoUpmo1JKMS9J1G7+adLzF KajBZ2DZJ4ktIc4Mve+0EGu7cZLUG24IuDn21nc5fu5ZKK2NHOw/MJ7ELxZlCqwkwGJE hm995IpcFU2uRc/7jRIpR6cdLAWfGujc2HrCTBKGeIFmqrTdfH3vlXPoYXC9JHaLVL7x DqnhHDvy7f/9QSrNnbu8ZMaYSRTyrDFaW4xylU/Q8oGNZkMxMiYKaXJTg33idD4uVNRF TIndMLKJjsShBrO2h7XU3LzEA8MnEgti4W08DKq5OnA7AUSkpbjGCtj819uGNaZxaIiw Fbjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=XWABGCmGD84OUsmG880Qoc6rzx6jHoYZPe1k5Lbjz9Y=; b=pWLpeUrs9DyqDFUguZHk+6Zd3ArbQ3oWXHjDIWPKiSpKyCmV+Ok0GZwLw+Jla4c5Px 9M9ZRSHzjQ4mYH8q527v7xc83zgka6THuzLwpdMA6uag54U4lVJCVxsOmlBGYQP05pJR mQdQMGy3D9UcPy/YkrCvPhvvR2nlHYAPe9ehfY2rGRkkqH6r8sPuAXD7KqUA8CA21kNx axnN+RRWczXK5ygD+lqc7uUg6EyWU1gIG6v+OJvbHtpPMLdKjtNVwwbYIQ4aEwuTxudI sNIJIrXo/xwrHK0QDI0U4VpN1e26XX9K6QONp2Snv7zi6IqpgRvT1Cf1kSFa3RLdrXIC SPdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VAf3CMVy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sh43-20020a1709076eab00b007c003e06f9bsi8181443ejc.102.2022.12.03.05.55.55; Sat, 03 Dec 2022 05:56:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VAf3CMVy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229553AbiLCNic (ORCPT + 82 others); Sat, 3 Dec 2022 08:38:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbiLCNib (ORCPT ); Sat, 3 Dec 2022 08:38:31 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4382D1BE95; Sat, 3 Dec 2022 05:38:30 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E871BB80171; Sat, 3 Dec 2022 13:38:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56CD3C433C1; Sat, 3 Dec 2022 13:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1670074707; bh=bMIyH4sES3OwK/UPdqogNOYLfgzZfXluu8F1DJdT2oM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VAf3CMVyOY0R/NPDtMP8vSI1X0QcjsUcs4W4/x6n4WhqoxefQ9i5hSMLewiNyr/O0 fplnHo/+4GnsbjSUUFrZSFGhLhvw3pgQyTtBMd69IE0I62A6oxOqSIeqMnEse1a09z +/8TH+xqcWnTUOjU7AAVSO5SGc0AhO/c3JSxx/p4= Date: Sat, 3 Dec 2022 14:38:24 +0100 From: Greg Kroah-Hartman To: Fedor Pchelkin Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Starke , jirislaby@kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org Subject: Re: [PATCH 5.10] Revert "tty: n_gsm: avoid call of sleeping functions from atomic context" Message-ID: References: <20221123181916.6911-1-pchelkin@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221123181916.6911-1-pchelkin@ispras.ru> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 23, 2022 at 09:19:16PM +0300, Fedor Pchelkin wrote: > From: Fedor Pchelkin > > [ Upstream commit acdab4cb4ba7e5f94d2b422ebd7bf4bf68178fb2 ] > > This reverts commit eb75efdec8dd0f01ac85c88feafa6e63b34a2521. > > The above commit is reverted as the usage of tx_mutex seems not to solve > the problem described in eb75efdec8dd ("tty: n_gsm: avoid call of sleeping > functions from atomic context") and just moves the bug to another place. > > Signed-off-by: Fedor Pchelkin > Signed-off-by: Alexey Khoroshilov > Reviewed-by: Daniel Starke > Link: https://lore.kernel.org/r/20221008110221.13645-2-pchelkin@ispras.ru > --- > drivers/tty/n_gsm.c | 39 +++++++++++++++++++++------------------ > 1 file changed, 21 insertions(+), 18 deletions(-) Also, what happened to my original signed-off-by here? thanks, greg k-h