Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 3 Dec 2022 13:40:26 +0000
From:   Qais Yousef <qyousef@layalina.io>
To:     Bagas Sanjaya <bagasdotme@gmail.com>
Cc:     Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, Lukasz Luba <lukasz.luba@arm.com>,
        Xuewen Yan <xuewen.yan94@gmail.com>, Wei Wang <wvw@google.com>,
        Jonathan JMChen <Jonathan.JMChen@mediatek.com>,
        Hank <han.lin@mediatek.com>, Paul Bone <pbone@mozilla.com>
Subject: Re: [PATCH v2] Documentation: sched: Add a new sched-util-clamp.rst
Message-ID: <20221203134026.ert6kax2f3okajj2@airbuntu>
References: <20221127142657.1649347-1-qyousef@layalina.io>
 <Y4V5lDHNqYHEzEaI@debian.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <Y4V5lDHNqYHEzEaI@debian.me>
Precedence: bulk

On 11/29/22 10:16, Bagas Sanjaya wrote:
> On Sun, Nov 27, 2022 at 02:26:57PM +0000, Qais Yousef wrote:
> > The new util clamp feature needs a document explaining what it is and
> > how to use it. The new document hopefully covers everything one needs to
> > know about uclamp.
> > 
> 
> For patch subject, better say "Documentation: sched: Document util clamp
> feature".

ACK.

> 
> > Signed-off-by: Qais Yousef <qais.yousef@arm.com>
> > Signed-off-by: Qais Yousef (Google) <qyousef@layalina.io>
> > ---
> > 
> > Changes in v2:
> > 
> > 	* Address various style comments from Bagas
> > 
> 
> I don't see any of my wording suggestions from [1] being applied. Still
> a rather confused to read (maybe should be applied on top of jon's
> suggestions)?

Apologies! It was an oversight from my side when I revisited the thread and
reworked the patch. I got confused somehow.

All applied now almost as is. There was one tweak that used "40% utilization"
that I replaced with "40% performance level" instead.

Thanks a lot!

Cheers

--
Qais Yousef

> 
> [1]: https://lore.kernel.org/lkml/Y3II59dyKuvQGIhG@debian.me/
> [2]: https://lore.kernel.org/linux-doc/87cz976pwn.fsf@meer.lwn.net/