Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 3 Dec 2022 12:43:57 -0800
From:   Saeed Mahameed <saeed@kernel.org>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Leon Romanovsky <leon@kernel.org>, zhang.songyi@zte.com.cn,
        saeedm@nvidia.com, pabeni@redhat.com, davem@davemloft.net,
        edumazet@google.com, mbloch@nvidia.com, maorg@nvidia.com,
        elic@nvidia.com, jerrliu@nvidia.com, cmi@nvidia.com,
        vladbu@nvidia.com, netdev@vger.kernel.org,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net/mlx5: remove NULL check before dev_{put,
 hold}
Message-ID: <Y4u1DVbFWFPx3hMf@x130>
References: <202211301541270908055@zte.com.cn>
 <Y4cbssiTgsGGNHlh@unreal>
 <20221130092516.024873db@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20221130092516.024873db@kernel.org>
Precedence: bulk

On 30 Nov 09:25, Jakub Kicinski wrote:
>On Wed, 30 Nov 2022 11:00:34 +0200 Leon Romanovsky wrote:
>> On Wed, Nov 30, 2022 at 03:41:27PM +0800, zhang.songyi@zte.com.cn wrote:
>> > From: zhang songyi <zhang.songyi@zte.com.cn>
>> >
>> > The call netdev_{put, hold} of dev_{put, hold} will check NULL,
>> > so there is no need to check before using dev_{put, hold}.
>> >
>> > Fix the following coccicheck warning:
>> > /drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1450:2-10:
>> > WARNING:
>> > WARNING  NULL check before dev_{put, hold} functions is not needed.
>> >
>> > Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
>> > ---
>> >  drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +--
>> >  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> Please change all places in mlx5 in one patch.
>
>Your call as a mlx5 maintainer, but I'd say don't change them at all.
>All these trivial patches are such a damn waste of time.

I agree, let's not waste more time on this, I will accept this patch as is
since it's already marked awating-upstream.. 

Applied to net-next-mlx5