Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3887953rwb; Sat, 3 Dec 2022 12:59:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf4my3ZTeR5oiPXBD66XQKXlsnugYk1Qgh3PkMGY9mD5gAYNmW3LCSqSXKzk699i/RLhPhFh X-Received: by 2002:a17:906:660d:b0:7ba:5085:864 with SMTP id b13-20020a170906660d00b007ba50850864mr41147831ejp.357.1670101159543; Sat, 03 Dec 2022 12:59:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670101159; cv=none; d=google.com; s=arc-20160816; b=TAO/9edoVzpf6X/dJatxMnfXfVQJJDyb4jMkN7UwHEIQcOH2U/sC9FDa80DudFe28j RYKeoG9oNOp/5pZTidWxS1eQD+Hz6dqVeRJxXlMXWwIrkEaQu9phOA7xAosKEVi5y69o 7elst2lholQvl0zozkS+kHAm+Har2jxlprvu4bskCO3dPB5ZXYXmOwyDKqb6cCJQiJKD RSTNRvGCHGEGeyM9aJmb2sCEYcQjZBhgNhccNAthmsGaYU+VkNCpROjrBqJyEeL5p2Lm Di3AvXV+KyDV9cOqFRxxUtyGLx7ZkYuGHPrfonO2bPmWVwjimXO/5ZaQ3/bjI/Cpp3PC QrHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xmiQ6e+EZtYhwtAvlqQA2RYZuXf7XfXC0ewv4MxWppk=; b=NqUxjuhaix64LSMGn6D/6rijMYrN1Ebqfvg4uP+8nGO0ER5P1IUQjuPAzUB1k6BHzg 0DKSvp+OX8jCkZUsNe5akvr5cbU53O1vbZQPDP2iHaul2QUQlfPh2/uAh+064bdKlLQ9 n/K8RI1yHjTP/WB6JMUMa6vFuRVrs9VBnBYG9ovtl5+2UrMbyBZ4J0I/rUQio2ctTxRk 866zBy7CwNazcgo0cKalkYspfv42DSFFvSQMPVwvr/oFQFr49vltfzg0+G4+G8y4iWaF Yy6mYvhnyDi/ukwYzy4T6fFICKt1ScdQv3Y5yEv51QCOh+/I5cYHW+76p6XY7U9KeW4T YT3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sC01FcTH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y7-20020a056402358700b0046777becff2si9213203edc.629.2022.12.03.12.58.48; Sat, 03 Dec 2022 12:59:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sC01FcTH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229929AbiLCUoF (ORCPT + 82 others); Sat, 3 Dec 2022 15:44:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbiLCUoC (ORCPT ); Sat, 3 Dec 2022 15:44:02 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3C1A60EA; Sat, 3 Dec 2022 12:44:01 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5DD66B80782; Sat, 3 Dec 2022 20:44:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0BA5C433C1; Sat, 3 Dec 2022 20:43:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670100238; bh=Mjt6xiXtxGYM7hTuzc+6X726pwVTwWJ7KDsMrRCyBqs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sC01FcTHOatBjyQjO1V0AOdBS3VZsPMseu0z32NLF02KYmcabavP0BQk27gQhXiEi ihg2w4Zo9gN38cthfobICA+hj0fetFrqZPIvfRzDZ1Q1Ig54TpcOGzeRkN1oenPffw f+k6FVaXedlo5Kkbt8nmiGixVg9+wk/tSYvrUrn9WXVzJsM08VZO7W686gYCyC1Vhb URKHPmddGQcc4zrhARzfsKDOIMSXnD64i8/UhL2It1x1SEUM7+JbOgMWISwpJpRmdk MT2r/E+7VFmzPdfLCqsdypaO0ZTiCxcBbUWsEKUEC+1kwvZvgusxAchkNiMtgbvP59 +NsCF38rTY/3w== Date: Sat, 3 Dec 2022 12:43:57 -0800 From: Saeed Mahameed To: Jakub Kicinski Cc: Leon Romanovsky , zhang.songyi@zte.com.cn, saeedm@nvidia.com, pabeni@redhat.com, davem@davemloft.net, edumazet@google.com, mbloch@nvidia.com, maorg@nvidia.com, elic@nvidia.com, jerrliu@nvidia.com, cmi@nvidia.com, vladbu@nvidia.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net/mlx5: remove NULL check before dev_{put, hold} Message-ID: References: <202211301541270908055@zte.com.cn> <20221130092516.024873db@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20221130092516.024873db@kernel.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30 Nov 09:25, Jakub Kicinski wrote: >On Wed, 30 Nov 2022 11:00:34 +0200 Leon Romanovsky wrote: >> On Wed, Nov 30, 2022 at 03:41:27PM +0800, zhang.songyi@zte.com.cn wrote: >> > From: zhang songyi >> > >> > The call netdev_{put, hold} of dev_{put, hold} will check NULL, >> > so there is no need to check before using dev_{put, hold}. >> > >> > Fix the following coccicheck warning: >> > /drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1450:2-10: >> > WARNING: >> > WARNING NULL check before dev_{put, hold} functions is not needed. >> > >> > Signed-off-by: zhang songyi >> > --- >> > drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +-- >> > 1 file changed, 1 insertion(+), 2 deletions(-) >> >> Please change all places in mlx5 in one patch. > >Your call as a mlx5 maintainer, but I'd say don't change them at all. >All these trivial patches are such a damn waste of time. I agree, let's not waste more time on this, I will accept this patch as is since it's already marked awating-upstream.. Applied to net-next-mlx5