Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 3 Dec 2022 12:49:16 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Yongqiang Liu <liuyongqiang13@huawei.com>
CC:     <linux-kernel@vger.kernel.org>, <nvdimm@lists.linux.dev>,
        <dan.j.williams@intel.com>, <vishal.l.verma@intel.com>,
        <dave.jiang@intel.com>, <akpm@linux-foundation.org>,
        <joao.m.martins@oracle.com>, <zhangxiaoxu5@huawei.com>
Subject: Re: [PATCH] dax/hmem: Fix refcount leak in dax_hmem_probe()
Message-ID: <Y4u2TK4yPU9dfiDr@iweiny-mobl>
References: <20221203095858.612027-1-liuyongqiang13@huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221203095858.612027-1-liuyongqiang13@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Zp8KQ/wCSOdTFC64r2+Qvcn09ih4duoniEgGoLIfeloym42khe2fc7zkwttx?=
 =?us-ascii?Q?w5KKgC6Zip4v53gRLFB2x9iuVAyHqebqvVCUJHIzEgh1qcgfthE6F0Aj02LT?=
 =?us-ascii?Q?1r7EDrj7ZDOYt2FLqUJbdk4sLURzaMdPMvOXfRG5iUvQpRsxdqWOXd8gDji7?=
 =?us-ascii?Q?am6ZnM0GbZcirMtTHSptqjeDg6A3bUgoEL2cfKRyX5P5Ab5UVEFtLw4e1+8s?=
 =?us-ascii?Q?f+m2JSdEvd4y829UHBlaJ2RiX7DKTypjWtW5lAdOWGsojLTmnpLHkkNgMgwB?=
 =?us-ascii?Q?YLNnG/9GQArjDu7O1JpvgPsUh3CNuoePMSZ1CkVxyd7rwsRntIMXkIxkkayS?=
 =?us-ascii?Q?mmaEJE/dJZrd5ITQ7dlhr203YL3HSkxGBo3kaBlYnQEmfg1JlaVGUtFf4blt?=
 =?us-ascii?Q?AUGICn52C7G8BpZJjMlyHZ1tLWga0Vd2vWFZiRZn4G2KHJ5jkP4XPwlyi+yc?=
 =?us-ascii?Q?N65lDBxp3yxorgaimCwj0qfxF93jZpAq3mmFx67ajo1cGbhoR1/8f+tN/pnh?=
 =?us-ascii?Q?Hy8U7qUmcS16Fn+uv0xADS0k8kHQZLHLuIWi9xwKdiHxnPPxa0B3CwSGSZ4g?=
 =?us-ascii?Q?YyaPVOzJQNeNV8XGavEyL1n/KyAaDmwEDyl5oUazrtINe6eMBkvwFsJcUGqQ?=
 =?us-ascii?Q?AmfE0j1P+d8vASHMh4BLnxYsLWuNjCEZtAUrThKTnj4W2AMM0YJI3qOxomZ3?=
 =?us-ascii?Q?L2QJ8nEBBtimBEGu7Rmab5fOosLCdfcA0C8N4ezlWBYgF/H0xyHesVlGIf7S?=
 =?us-ascii?Q?8xxuBCovyRXdg6prSRuWGwlYy0LIrE7AGepfet5ntlmrdLqzTVBmv7UvjYRE?=
 =?us-ascii?Q?EiGZ9D0pMBTKiB59lvM7xoNerOSSQyJ/CoPsOM/apDJfopu34sL9XUI+1FyP?=
 =?us-ascii?Q?7MYc2OUvFo6Dvmr2YW3hvue0yHpAWo74oBqIcVydNvtAmmscofRkFPhxULH0?=
 =?us-ascii?Q?FDx5NnH9wDFCC5O3ytZHvlgfI4Gh36LjJDsc0N5gu3K9y4TsIAKcZd+2XN3i?=
 =?us-ascii?Q?EQTgWIq2W1ZP6aduLuIq3ldweivjdfuEbMIdfAYwXv2guOvAtDKLxlgQYNOk?=
 =?us-ascii?Q?cRNwUJU5MusaDCVChC7KlE47At0BK7Y+f10OmxoAh1YIRkY5Js1NzqJGExnf?=
 =?us-ascii?Q?QKSUrPQipZ7/I0xNM2dLi1GGROgpEMTW2a/2wXEWfjF40ElM0a+TEPJjxKAu?=
 =?us-ascii?Q?d9fzWv9ZLZEIrorZjtLEtsXgeS+Y2csmOe4iDwTC+yx9g0ih2+OJisxJpGUX?=
 =?us-ascii?Q?Be1N3pDJLRXu91WvXgS0hnx1qOqRb/ZkdTEtpf5ZxSP66tPS7+A7LCgxq1ex?=
 =?us-ascii?Q?UJENaM7Pk/48IGNojXRc9i55SG0ICqvMoitJEcYmngeL91Aj0LUi8eQ/BX0/?=
 =?us-ascii?Q?Lf2LoInto+vcDxrGNv5igcYvMNFXlbbwgRW2He1hURueElo4L4y3K9y4QoFd?=
 =?us-ascii?Q?vo8J4G3pufvDU9/4f1M1pzoxXANagGHz5PeBvF8S/kCX/cIEgGprcHOnC6Ua?=
 =?us-ascii?Q?vD5dnMES3kswd0ptmwmgXCRjTrH5BuEbdtXBY0p10shPvTxvs7wn1loYWvGT?=
 =?us-ascii?Q?1iJodL/sGNEhgrw7c15Ply40lO/Exp8f5WmzwIVP?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 14aa6290-edf6-4db2-bc8c-08dad56fda4f
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2022 20:49:20.9759
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n70Lytf7X3YEaCi0r1KriDdU/bwozhAHQjcfquQsnWmqtBtG3JXGE7EEJgofbJBEvPL61zP0ax50/usSCXQwvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5080
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Dec 03, 2022 at 09:58:58AM +0000, Yongqiang Liu wrote:
> We should always call dax_region_put() whenever devm_create_dev_dax()
> succeed or fail to avoid refcount leak of dax_region. Move the return
> value check after dax_region_put().

I think dax_region_put is called from dax_region_unregister() automatically on
tear down.

> 
> Fixes: c01044cc8191 ("ACPI: HMAT: refactor hmat_register_target_device to hmem_register_device")

I'm also not sure how this patch is related to this fix.

Ira

> Signed-off-by: Yongqiang Liu <liuyongqiang13@huawei.com>
> ---
>  drivers/dax/hmem/hmem.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dax/hmem/hmem.c b/drivers/dax/hmem/hmem.c
> index 1bf040dbc834..09f5cd7b6c8e 100644
> --- a/drivers/dax/hmem/hmem.c
> +++ b/drivers/dax/hmem/hmem.c
> @@ -36,12 +36,11 @@ static int dax_hmem_probe(struct platform_device *pdev)
>  		.size = region_idle ? 0 : resource_size(res),
>  	};
>  	dev_dax = devm_create_dev_dax(&data);
> -	if (IS_ERR(dev_dax))
> -		return PTR_ERR(dev_dax);
>  
>  	/* child dev_dax instances now own the lifetime of the dax_region */
>  	dax_region_put(dax_region);
> -	return 0;
> +
> +	return IS_ERR(dev_dax) ? PTR_ERR(dev_dax) : 0;
>  }
>  
>  static int dax_hmem_remove(struct platform_device *pdev)
> -- 
> 2.25.1
> 
>