Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp4089280rwb; Sat, 3 Dec 2022 17:28:49 -0800 (PST) X-Google-Smtp-Source: AA0mqf6HoBXS9W6dDgSo4/NLEcw/VMHN2N+x+WXstMpgJ/9sn86Bts2wYkzLKUAX2cqSOiMm69Xh X-Received: by 2002:a17:906:a983:b0:7b8:31b1:b23f with SMTP id jr3-20020a170906a98300b007b831b1b23fmr48329401ejb.591.1670117329000; Sat, 03 Dec 2022 17:28:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670117328; cv=none; d=google.com; s=arc-20160816; b=QGsF5XOAo/1dGqVO9Mx1pcU0MDwmilKb+sDDitI/UuA0XL/DDX6Wm3AYzXIm3bHM4+ dz158GP9uyNmLf7D/aJOBvovc2jj9H11Z96qDT6AYfhi2Uw2+VZYy/ZrhVMqn88LKdZT oHinIvt9rG1NOsWOeGTVp9jRd8JyQd8ZK4fHREWu7GNpMe8Iq/1R6G42xCOHi2XtFLpA Jcnj+5Hygom+STRgDCkw7sPqmz/Fxh34AlzGbC/LOQoBa/WK8ION+Npdx1+HL/mg1YHk X1zZG2cqRNZC4pMqVq9R4yGRSqrW0lbYCYnZY5n3aJOr62EYqRE6dE+LFToGZ+SP9Z3S LPcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=08OqTfpjEPIElzgm0b3XrsSLNPOJHA8nk6UGImZBGMo=; b=Qz2ioQjdKhiybz6OIXbrzALFuaDFY7JyGUlRkMdvazG9xziMDRg4z9OAAR5xIOGxer dDruZU/rcfw5nljPSAokfAU8cHNLHDFgUC4dB1a9A9DozZk7dmUP3rwlNfKYbe6f/0QN SY2jqMdtGyTTrt2NnOWuv3okcTLysdv8UUV7OT+p5FCgcP0eQ5U2Sn9YWVyw1kuO8oCh 3O9DoO4sKuH6GlsojioiT+z899XTwHwVZSuaU0zJSnOofIegh7RARATlvG6grGg2rnqK R/C29MhlA4EyzSTcp0SUmfCi9+6EVAbIYOByh4JyaPF+sV94YciHMyjvyO12SI+o1mSC zJxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=G8bd266J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i25-20020a0564020f1900b0046ca545887fsi216773eda.500.2022.12.03.17.28.29; Sat, 03 Dec 2022 17:28:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=G8bd266J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229698AbiLDA63 (ORCPT + 84 others); Sat, 3 Dec 2022 19:58:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbiLDA62 (ORCPT ); Sat, 3 Dec 2022 19:58:28 -0500 Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 751941AF08; Sat, 3 Dec 2022 16:58:27 -0800 (PST) Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-3a7081e3b95so85000277b3.1; Sat, 03 Dec 2022 16:58:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=08OqTfpjEPIElzgm0b3XrsSLNPOJHA8nk6UGImZBGMo=; b=G8bd266JZeEMVezTktX5sBBXee/WS2YVaOVvlcrBqxqKaj30U4vEvZZTLGf50yRrgG Hp3OsMSGRd5eXDNQg/IuK8WCKLqnlMyPeWWSvexkhxZML/9L0n1QesgbX+nMTneYatRq cWUVEaADZsCVnZUkBNDUQUbTGksxgbqY0+9aeIWee6RTI9l74A3NShjoSNsvGqU1lazQ hn1IiKuZ0NYyMW7Mkpu2mla2xwRfCfbZDuY0Dt8CaLe+YeoTmLWEAG/ab6ffdFEppxGr ylbest2ijb8/Zxz3RevXcShDX2f8DW39oClIE0VDtpBuUHb8A5xBN38/fxvqwPbXCPaw +jeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=08OqTfpjEPIElzgm0b3XrsSLNPOJHA8nk6UGImZBGMo=; b=m0qGkLwiRxit650rCO3gcIwHM3HzGKQ2Mutqzopdim0YwCREXIiwJ8ansxrFbNWobd P1sjNWDPvd7ncCM7DDspezmKQOM5xq03bHl7vxGTPq/iLAjwC6hvuJZ3GEqbiUmrwAN7 V2cNADCHnPS3qHwzLnQaowXhmhbnZMlupZHWUSmefszklS/Cu7Emn9ME9unEC3dH2WSV m5IV7VHORCeBA0j5aQ8qd2krPa+ReLarbJ12lKgq5+du0ZqBDeoSGEts3retEb+ebFYW 58liabkl+fJlzBziSKmclFf1OIEEKYulBQdBvybUe9yDiBYtVDHhCV5f3UtYW+pycl8u pSXg== X-Gm-Message-State: ANoB5pklMdHQqmmMesJ6Yae2fXzyNS4pMx991pX8OjGrECe8l1pFMNdR 1dy8T+wvSANlvI2LYrvqcISTXeKABtl08GlXEBo= X-Received: by 2002:a0d:ccc7:0:b0:3d8:8c0e:6d48 with SMTP id o190-20020a0dccc7000000b003d88c0e6d48mr15165100ywd.462.1670115506664; Sat, 03 Dec 2022 16:58:26 -0800 (PST) MIME-Version: 1.0 References: <20221202161502.385525-1-ojeda@kernel.org> <20221202161502.385525-28-ojeda@kernel.org> In-Reply-To: From: Miguel Ojeda Date: Sun, 4 Dec 2022 01:58:15 +0100 Message-ID: Subject: Re: [PATCH v2 27/28] rust: types: add `Either` type To: Josh Triplett Cc: ojeda@kernel.org, Wedson Almeida Filho , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Wei Liu Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 3, 2022 at 12:42 AM Josh Triplett wrote: > > This specific example seems like it would be better served by the > existing `Cow` type. Yeah, possibly -- it is taken from one of the use cases in the full repository. Perhaps it was deemed simpler, or providing a way to go to an owned instance was to be avoided. Thanks for taking a look! Cheers, Miguel