Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Tharunkumar.Pasumarthi@microchip.com>
To:     <ilpo.jarvinen@linux.intel.com>,
        <Kumaravel.Thiagarajan@microchip.com>
CC:     <linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>,
        <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>,
        <andriy.shevchenko@linux.intel.com>, <macro@orcam.me.uk>,
        <jay.dolan@accesio.com>, <cang1@live.co.uk>,
        <u.kleine-koenig@pengutronix.de>, <wander@redhat.com>,
        <etremblay@distech-controls.com>, <jk@ozlabs.org>,
        <biju.das.jz@bp.renesas.com>, <geert+renesas@glider.be>,
        <phil.edworthy@renesas.com>, <lukas@wunner.de>,
        <UNGLinuxDriver@microchip.com>, <colin.i.king@gmail.com>
Subject: RE: [PATCH v6 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for
 quad-uart support.
Thread-Topic: [PATCH v6 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for
 quad-uart support.
Thread-Index: AQHZBUCRCt8OI9hKyEiqCIdkYKoOua5Yxz6AgATG/YA=
Date:   Sun, 4 Dec 2022 10:39:09 +0000
Message-ID: <PH7PR11MB5958B95CBD036C6A4EB8E76B9B199@PH7PR11MB5958.namprd11.prod.outlook.com>
References: <20221201045146.1055913-1-kumaravel.thiagarajan@microchip.com>
 <20221201045146.1055913-3-kumaravel.thiagarajan@microchip.com>
 <79c14380-2cf4-108c-544b-98a84e5e251e@linux.intel.com>
In-Reply-To: <79c14380-2cf4-108c-544b-98a84e5e251e@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?6ImBHmnqqvUiGPJ5UgVZjwW44dDbmVDOtKCI7jaFQMQv7cQIT4ZbhnbOfZ?=
 =?iso-8859-1?Q?4a9Laeor4/JX6p08AQZuyZqZBRYLJ2PAbxZUmtt7uBl2RljKoQjHXVvOpy?=
 =?iso-8859-1?Q?tAdOo3xzpmNc0I6vSLWrOD1/4vZsE52IOdOlM8S7K4VW47y2WhutTx9r3c?=
 =?iso-8859-1?Q?zB2RjuIYSOxBRMy6Gyba7zFT7z86EX+t873G5PVdfoeZ3pNw/qaq0U/DcR?=
 =?iso-8859-1?Q?3YauEFtMNiu0zNYArBygJp/fPpfxDUhTMdWUIn62lTOdiWMI6lV5k/dh8n?=
 =?iso-8859-1?Q?+o3XzGglqCzFWzm6F2v+DfsgqPz6rj9Nnyj5Q1Sb/GZ29XcFfxSbeJWEXw?=
 =?iso-8859-1?Q?gk7zT9ZX64K8z3t6GjmEBMdKEW9qsQKooJbEACw4faGrEIaY7WPmuTKQKT?=
 =?iso-8859-1?Q?CxSgtWjqmEVOfpDG/t+v196dM9BWqeaDjsmXRRQQ/I19+htZwblmfCN8ad?=
 =?iso-8859-1?Q?4K48Um1qMfgiTmD4hf0T9VsHOBSokSI0QdEGVfeJBsX0yPwNSGTc+zzl9c?=
 =?iso-8859-1?Q?GiaLX4aA9NGuq2RufXj6irtDHXNNk/YwpBIomxGMb7eXRZpc455Apvjmsp?=
 =?iso-8859-1?Q?f96V+mmOh6/3LVAo1cG3Mm6ICCICyBuOk2tnwU+M2PPSmeXN8MC1jnCBhC?=
 =?iso-8859-1?Q?Fu7ZmxMwXYit78cnRxzmN1iM8diYiWpd/0EU0uTtX3FJDPmHcZFhsUKtNZ?=
 =?iso-8859-1?Q?zn/i8x/Srb6A2uTjLwTA3OmoRMsjcBOEHWkc6kl3DZYbbIIAXyo1gGITEj?=
 =?iso-8859-1?Q?8qMErIzmDm8oFuIWAFXZNbXMe32A79DjojNu/hOCE6mTqtwI1eI0OusqYP?=
 =?iso-8859-1?Q?J5fk9/rx0l/a4QzEHzupn2D0z6/Jm9AL6Iwmo0lkK4Xl4MsN0X7/67N4Ph?=
 =?iso-8859-1?Q?eykuiS4oGLHq3QZnbk1UZpYPANiuWUFvj+64cCYUo7PDul5GLsKuC89qZO?=
 =?iso-8859-1?Q?gwn3dMD43s0ZLpNIXXI33k6T+ZY4EFx2rYp1lr5OxPh11OEnM3PhUE/kIM?=
 =?iso-8859-1?Q?HzYF5duV6Ul7xkVYi2cuXmTuna0N2zpd3wZLZ+3rqyVlvON9B47CfJaNOG?=
 =?iso-8859-1?Q?2DWuEF/dkRSKswTE6JADDN5EUBcrUMVIApA1EtKOfsXPb2wcfYS1vCjkUc?=
 =?iso-8859-1?Q?wVAI6tlyArPLLIFX+E5HJMtPLnG4Sp/SdHuKO+51Xd34CJX7xtNpM4+joG?=
 =?iso-8859-1?Q?EF6Y0fFlE1DToX1DsMigw/LaHEoaXulAeSqKkMmTOuQ+3Nzebw2iND0u1o?=
 =?iso-8859-1?Q?ux6io/5bzgiyIWtCwum76t0qg51lcJZx6A6Q0U78W24+8bqaENIJwHbLcJ?=
 =?iso-8859-1?Q?OTq8C1q8+64TMb2DLyZMZCuhPnUfh70W91JwF33G50EPJos5OttmBi3VB9?=
 =?iso-8859-1?Q?pgmR5n9txSAm3E8PoksaC6Aw94a/CHaiyj4P6xAIv1ecGKrsC+K8wi8JQE?=
 =?iso-8859-1?Q?qyUesg24lBnzuZg78IPH/OnWV91pgC6cK0g+rx6RqN91Ga9asFvmJO54Qe?=
 =?iso-8859-1?Q?zWwWMZXvIEGoHR8wU3hcADHWCbF376A4iO/QXIsPqlZqq0sReOU4LIufHS?=
 =?iso-8859-1?Q?nJuBoSK5QrRIijjutzN9KZvQ211zgYNuDxjIsG2RqrU1ZjDv74NLc02Upr?=
 =?iso-8859-1?Q?JPTawVvzAMwDIQGF9kNLsXCWdD93liCouz19cNvloN/o0C9BhIOphGPNW2?=
 =?iso-8859-1?Q?2zOmY8W+3V8mRyVhTRI=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5958.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a4c8cce-38af-46d5-ceb0-08dad5e3c6a9
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2022 10:39:09.3031
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lXUDXZojnj2u5D3mPBYrx32ou5PfowgsWzO2JGutpr5hG3T8gPEiW3buV60yI22psogTlXNobnHMNHwn41Dg1Fuc/pCM7FQ2A3KriykE2Nzu467Ys7YEj3smnJCFcM/f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6234
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>
> Sent: Thursday, December 1, 2022 3:10 PM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@microchip.com>
> Subject: Re: [PATCH v6 tty-next 2/4] serial: 8250_pci1xxxx: Add driver fo=
r
> quad-uart support.
>=20
> > +             {3, -1, -1, -1} /* PCI1p3 */
>=20
> Add comma also to the last item.
>=20
> This array can go outside of function's scope.

Okay, I will create a new function get_physical_port and declare static arr=
ay inside the function.
I will call the function to get value from the array whenever required. The=
 scope of the function
Will be throughout the file.

Thanks,
Tharun Kumar P