Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 4 Dec 2022 10:31:53 +0000
From:   Gary Guo <gary@garyguo.net>
To:     Josh Triplett <josh@joshtriplett.org>
Cc:     ojeda@kernel.org, Wedson Almeida Filho <wedsonaf@gmail.com>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        patches@lists.linux.dev, Wei Liu <wei.liu@kernel.org>
Subject: Re: [PATCH v2 27/28] rust: types: add `Either` type
Message-ID: <20221204103153.117675b1@GaryWorkstation>
In-Reply-To: <Y4qNR+Nn9utDftHq@localhost>
References: <20221202161502.385525-1-ojeda@kernel.org>
        <20221202161502.385525-28-ojeda@kernel.org>
        <Y4qNR+Nn9utDftHq@localhost>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JIlusyEbQQCFlpMsIl+rLIy/et+uQBlXI045JuYgW9LwiK1rQ4wG2LSPoWVO?=
 =?us-ascii?Q?E6btrKWcQY1E4Ya8/R0YpM+EabWJorLrduJoffnv5oRj0z1C0CGK1c2ZlIJt?=
 =?us-ascii?Q?xP3/Hu6Tm2ERTuTwtD6YILDeznblc6F+JUDCbKWHVcCC0elmbF2fOhW7oLnu?=
 =?us-ascii?Q?WQPv5Yg4zvJPROuCZzv+i96OI7sq3sFIHQUSlqptVLs+aWFI9+mUS1OlBEdL?=
 =?us-ascii?Q?dYhEDshwF/lAJ0LQcJPwpHLngfsu7LJWlHkZnJSUgkSwKqPNVpu6GauQ/Tyo?=
 =?us-ascii?Q?MLIkrHOLN9JoQAFiTPGw/oUg2h29yY7+gF8NrCV8QRZOHy7y5T1evt0SvCkW?=
 =?us-ascii?Q?i6gOtynIgkqrwyYZD1g79rn9guCuaYvGdSnmsaNllZiudxTynh9cttv09n4Y?=
 =?us-ascii?Q?0sj8a22zYXK6JIV29adyocZh6NdQYjyWkk2dw22xjkXftOcj1bkILpGvU4sW?=
 =?us-ascii?Q?JMubcfl8VWd3KSwbZeJcfLY2vh561OWUUYGn+jaBrqHheyiCx3affujQCMyl?=
 =?us-ascii?Q?V0RhnsCnnaFqhnLYjVYOG7EHE9qkiztmKTZdYMECwoXlSt7XqvFuW7EMwtwh?=
 =?us-ascii?Q?zV9SUOl54kNvnc/NQJgQ11g+Q0paSBUMya0e7S0gbg/tI6JD468EASmQmlFP?=
 =?us-ascii?Q?eBZOPe40IUl220tsFEJnbpDjOw2V9p7bwibf/OencT5PuMoy+7s2gxxN6u9m?=
 =?us-ascii?Q?1V5osXgCpVj4cxjiuqOwcbP9uEqIXqs5KTPO77SmJZz7WWbjZcs93tp6BZ/P?=
 =?us-ascii?Q?srlxXZSUKQ/8ldfc9UgKAAU/oquTp7bNghGd7vWNBOuhlnD3QO8Qm1KvfCa9?=
 =?us-ascii?Q?jXrlk6a2BsAZegWv6zrF0pfddHIMZXckhv7fFze5iRO+g7AqKWeun202JJDC?=
 =?us-ascii?Q?7BsY3B3C6gmbtPUlO+P7z9YP5nRK8NPJ7seeP0YTGFZlSnuUwspFjJ4b2aDO?=
 =?us-ascii?Q?abuH069LVUznUW/YtMYTb0y/31Pg7oGGkbrnqqwSom6V0p9WTHXAdtd2ispe?=
 =?us-ascii?Q?k/g2SaNa+Wi+lo1BPAQxYUO/syrLlmitANVV3d9NJBNhwerp39v1a/FCYKTd?=
 =?us-ascii?Q?V1D3fa4mg4MJWLNVZswIzDUAxGWN64gE6Ty5eRqO4qwErKFFiABPWAogDQ9P?=
 =?us-ascii?Q?tdpUq/S7t8yr4/7NMYjcvj1qlN6jQa+Fn6Ce5ElHIddKpG4qbJWtIpNQ+kbx?=
 =?us-ascii?Q?n7ugPeM/lXPyTJPQnrTvFQ7OeDXisVnQdcFKGrMVN60oKZkxHjEUBifwxHtj?=
 =?us-ascii?Q?cqJW2ZoqWeddDqcLBuK8HnmxjO7VLLMRbxqShecx3oMHN2FWAUtJSh+ASTA5?=
 =?us-ascii?Q?5x4V/T/+m7rPznQBkycgqme9E/D5eVjHv16L51WoxOYhkd8DaQSVrPGwIuZn?=
 =?us-ascii?Q?R8u0k8RJVk+bsu9Pb2J/jXKgW57Yyr+5cm/QXpcr3rQnSb83pml7vblbVGFl?=
 =?us-ascii?Q?V8BeDxZJADyBO+6ZF7NJ1GG9cw8mdn4Catp5KoVGfeLnsLGf9ehYR4P1MalT?=
 =?us-ascii?Q?ft6Uju2EvLhwXeuRvYmpDr/szKQRammxjhioxSL1ZyKNFG+chnpDwtFquugG?=
 =?us-ascii?Q?qcikxx5fZKspwwr3QDsY7DUNbDGLtPn4cw112n0aLIDvEnf5Knhs8pp6mJUn?=
 =?us-ascii?Q?QiuqRP22HY1Nz5zSet6An5g3ISzA8BJubBqKRBfPpaOG?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 86198265-7bc3-4a02-afe8-08dad5e2c3f3
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2022 10:31:57.1790
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RQVB6LL7rVtFvzeVJbcXnNvEIcoAK9PmmGyXH8QuEpybx48zqufA2Bnpj4v6qC3fNO5NWCFSCwRTK7HtvDhYbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB5676
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2 Dec 2022 15:41:59 -0800
Josh Triplett <josh@joshtriplett.org> wrote:

> On Fri, Dec 02, 2022 at 05:14:58PM +0100, ojeda@kernel.org wrote:
> > From: Wedson Almeida Filho <wedsonaf@gmail.com>
> > 
> > Introduce the new `types` module of the `kernel` crate with
> > `Either` as its first type.
> > 
> > `Either<L, R>` is a sum type that always holds either a value
> > of type `L` (`Left` variant) or `R` (`Right` variant).
> > 
> > For instance:
> > 
> >     struct Executor {
> >         queue: Either<BoxedQueue, &'static Queue>,
> >     }  
> 
> This specific example seems like it would be better served by the
> existing `Cow` type.

We use `no_global_oom_handling`, which gates most `ToOwned`
implementations (e.g. `str` cannot implement `to_owned()` because it
cannot guarantee allocation success).

So the Rust `Cow` is pretty much useless in the kernel.

Best,
Gary