Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Arthur Simchaev <Arthur.Simchaev@wdc.com>
To:     Arthur Simchaev <Arthur.Simchaev@wdc.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>
CC:     "beanhuo@micron.com" <beanhuo@micron.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 0/4] ufs: core: Always read the descriptors with max
 length
Thread-Topic: [PATCH v4 0/4] ufs: core: Always read the descriptors with max
 length
Thread-Index: AQHZAlj7k4GN9YfaUkugDTmI0A5hTK5dwfHg
Date:   Sun, 4 Dec 2022 13:22:43 +0000
Message-ID: <BY5PR04MB6327A3C457A16BDFC5C13ADAED199@BY5PR04MB6327.namprd04.prod.outlook.com>
References: <1669550910-9672-1-git-send-email-Arthur.Simchaev@wdc.com>
In-Reply-To: <1669550910-9672-1-git-send-email-Arthur.Simchaev@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zdcb2G+2v/FIf+CU89cSBbJpxzwhVBCsuNeJc8YpgRuU5/rgz+LdBuB+URDE?=
 =?us-ascii?Q?3RyyAqYATtRhgZ940IZaatF57AlfqtseRjEy+nv3jfBZ88SZAHzw8KYsbiix?=
 =?us-ascii?Q?SX3pIvWeQ+bSSKa8oW1N6J1PWmudksMXcrCLYMh34PdcRimhl/w0l3Vtc4fw?=
 =?us-ascii?Q?Vsg4So6LBcoWpuOebG67XuxlOD35TEHteXlrYyC/S9AwCT1E69yrXc1diEGy?=
 =?us-ascii?Q?7yXCIqXnJ6BTAlriQeG5q3CIh2CQZ0dF8DzvY9zV0WpjonpVJOigi23dqiYJ?=
 =?us-ascii?Q?Pp5+tH86/L9m7QQ7VWUaz0pWMZ0pnnfYB849bQNUIhD57+NnfxUG+VliZ38p?=
 =?us-ascii?Q?+wm9zFzNSlMpXHv5Wpu8BMPvNeyjNiqv/d4Z4Wfk5UPBBJG8JFGyUmHkibo3?=
 =?us-ascii?Q?6CScNRs557OUBJpGbfhRI8YyZLTqYTp4lmSGwbag3uSH4vUXM7/oV0lYCpGk?=
 =?us-ascii?Q?KGtOMt1r2Ceqebc0DhbpCARAxjyWXqbKuI4Enr5tAXQAEbSXxXCyGO0PBSWs?=
 =?us-ascii?Q?BWQnDmmh1bKuL2siMIdqIh5qK6IZd7y5J8IvHqvc8iDwMHKMgOIsyMAjv+0o?=
 =?us-ascii?Q?lXfZmx2wpsYEh+zU7UXCILUrx4UYtvDNGK5Qt8JGOgjWpupZ23DS2lWWCD5K?=
 =?us-ascii?Q?jLuwSzvDyl/j4IaxmT0T/YxmNr/3q4B2yu+ywdanyauIwYz39nrx8PrZra4o?=
 =?us-ascii?Q?7ZnZUNBt36Io6QSGAzW0ZJcmYzBuh2PSX4XwQQaBzkWJVR0OvSUCsvJ99OvZ?=
 =?us-ascii?Q?B5FQN+hrrphFMEib2frK/OwwJCnXPJdHl1r6RzR1kYbtPeYClbNATiPOA4c9?=
 =?us-ascii?Q?FGh72TtOUKImmcH9lNxAZxFA8amWH64bQka7FZLJh1XhYxmaRxJPAyxp6ttt?=
 =?us-ascii?Q?Y9jEWTrjjlPW0zXy3wPMlE/d8W49Jyubq0q5FYcGJstQ/ZdJgDaWUV+/ikk6?=
 =?us-ascii?Q?6jCa17DTMp/TWtcj7LDU7bnW8/oq+Qy61GNJV3uILwCGT2QYwj+KyBkJbkwy?=
 =?us-ascii?Q?vzwk6PjVC3wpkauOHOYJ+YVNu0BTyc64PhkzaTZkQ2kQGzMGLV/qFvKFgN4N?=
 =?us-ascii?Q?fkwns3RjXB6FY559CBhfleFmtV20IbYANfj3vgKFaMqbC0RRlN/JnpR+lSP8?=
 =?us-ascii?Q?/h9nTmvPN3Of7VgdcdMiAMP2T1ge0bhimMwjXRp7sqA9cp0A2vd/bn4WUV5i?=
 =?us-ascii?Q?AV17jcHSieURbA4+ZtHLTaGxMaVW+fsAP5Aa1saTyw1R5v1QGCTIiaprL14E?=
 =?us-ascii?Q?Z322T/Jvt/ktt9ngIb8u/pYMC71VoiE66zB/hDQUZoLq2GfDiNt/j1MboNA3?=
 =?us-ascii?Q?KeVruS35EiCbut9RkA8pqeqatl+25AuHBnGcACdrrTYzUf9YBRD/aK9vfIAK?=
 =?us-ascii?Q?Sejkfc3ANNknEA37hvdSiYAfuImULJyCJDrx8MHL4l+LXxC+lhXjoy8bpxqf?=
 =?us-ascii?Q?yKH9Z2mJigoIqLDZRqfD53A8Y3nfce3NYuKo93dpFJTd4Zyz2WRp8i6SDVap?=
 =?us-ascii?Q?McekURmx2enIHjyjWZCVj9kA96vT7FgndU8Lt3ZdzvOieOcanq5ZgAlN8ujA?=
 =?us-ascii?Q?kmx2CGFkbAJ7hvxHUikv95NC+DHpBEofBfmlsWt2?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: IUEu+NoYgVknYcbmbnJfibPRPhRm1s7V8L7TWDFtpw5lZF+idqN/71+QefddEI5SMb/71veRtWJJjj6IoxyhfgTiKcaOIWE2mUSJ5FEZIYPpKZnpY3ROUIjFmRjFquqU+ayUXVq8/u5uPAL4P0utqQsVSdal9LU6rI4Fhz9KVOUHOhRVHnUspyaQPAqMm/YK1SiJOXAGL+PZKEdTuGqeg51mcxbfXY31BL6fmIAQhGeD9qTG3pXUNEAgr9FwoPpNaislWrGO5+M27bHvPNWjdebam/FYJHwPzez1CbbDq8z/aEFFnPikJp/OtmfvF3hDK02pxX/uOmupaMXbV9gS5OxL0/Am4p6RKDxShdHQJRCDdxnWVyeXLhjYrEEaTUyHwcXifnJnNQMYHp+1OJNTV+IhkJy8KoCHIjWfKenilLrPiJbtxlAZdKpWdsNVDtb+RlwRNiHGmciR/6BwNsN6eweNX3Q5ww929TyWshbOzBac7tNGRZZ9imTmf6AuF9vJaTci6U0rWzNGD77Bq37qLgurcIPBQU4FWpQ9D13+A824zTTIfh5gPsTZ54ycotn6EYX8EA3Q+KWH6oiTb1jUbWjLZb3qRtjYBkZl4n9fXYBg+OzMDryWz965ThlusvJ9wC2OemjQVM+NauvJN8B6RrlgCGpzrnlNBp3uwWKhPAiKBgJTxi5Y/GHXZgvpquJapCf7xoR49qb9EvHcSGHapUqTylzvHdi2BjZ/wjeOJZmOsbT0N+fteyDCJsLCDsNi2xgytKgcLqDDLm0S2tUDrz/ClOkGewutZCxMckwLw6HJxQDTDFUYoQ56TmwunM0bco9/lzetJKpKpr1ku0sJPJVG8iduVHv7QiPfF6drORsuNO3dRxIMy6gpGFod/6rN
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6327.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f225e2d4-f68c-4848-258a-08dad5faa0a5
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2022 13:22:43.9428
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bqHfjfRhVWil3p017NpkbHV8inziAj9ysnYtT7zmqMMfKtuEx4LIq2FgD/ibPCBqktlTdTkn/Gi3sHgAh/VjLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB5703
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Martin,=20

Gentle reminder

Regards
Arthur

> -----Original Message-----
> From: Arthur Simchaev <Arthur.Simchaev@wdc.com>
> Sent: Sunday, November 27, 2022 2:08 PM
> To: martin.petersen@oracle.com
> Cc: beanhuo@micron.com; linux-scsi@vger.kernel.org; linux-
> kernel@vger.kernel.org; Arthur Simchaev <Arthur.Simchaev@wdc.com>
> Subject: [PATCH v4 0/4] ufs: core: Always read the descriptors with max l=
ength
>=20
> v3--v4:
>   Add "Reviewed-by" to patch's commits
>   Use kzalloc instead of kmalloc in drivers/ufs/core/ufshcd.c - patch 2/4
>=20
> v2--v3:
>   Based on Bean's comments:
>   1)Use kzalloc instead of kmalloc in ufshcd_set_active_icc_lvl - patch 2=
/4
>   2)Delete  UFS_RPMB_UNIT definition - patch 2/4
>   3)Delete len description - patch 3/4
>=20
> v1--v2:
>   Fix argument warning in ufshpb.c
>=20
> Read any descriptor with a maximum size of QUERY_DESC_MAX_SIZE.
> According to the spec the device rerurns the actual size.
> Thus can improve code readability and save CPU cycles.
> While at it, cleanup few leftovers around the descriptor size parameter.
>=20
> Suggested-by: Bean Huo <beanhuo@micron.com>
>=20
> Arthur Simchaev (4):
>   ufs:core: Remove redundant wb check
>   ufs:core: Remove redundant desc_size variable from hba
>   ufs: core: Remove len parameter from ufshcd_set_active_icc_lvl
>   ufs: core: Remove ufshcd_map_desc_id_to_length function
>=20
>  drivers/ufs/core/ufs_bsg.c     |   7 +--
>  drivers/ufs/core/ufshcd-priv.h |   3 --
>  drivers/ufs/core/ufshcd.c      | 100 ++++++++++-------------------------=
------
>  drivers/ufs/core/ufshpb.c      |   5 +--
>  include/ufs/ufshcd.h           |   1 -
>  5 files changed, 26 insertions(+), 90 deletions(-)
>=20
> --
> 2.7.4