Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp4677129rwb; Sun, 4 Dec 2022 06:19:38 -0800 (PST) X-Google-Smtp-Source: AA0mqf6P/LeitJFHoHdIkts7BgizHbpw3quHmraeRsPY4vskSI6FIhlug2LY+/4QuFgDL0QkyrEg X-Received: by 2002:a17:90b:2792:b0:218:a152:12c4 with SMTP id pw18-20020a17090b279200b00218a15212c4mr71849105pjb.125.1670163577840; Sun, 04 Dec 2022 06:19:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670163577; cv=none; d=google.com; s=arc-20160816; b=ZO8HkEuC3kVlzphLf3ajPGkrV15jpnq5rNFwZQUPfOpQzX3JGaX8bSDMD8y3oiMUU1 icWnIYdO7wbJIbR/R1X9MRwB7nrmvOHOjmwCD1NXicaRCiTELA68MdvxyHMBP3EgeP9E IijXgS21ELdzfNZKG7p76icpjKJDy/1OimI7+Gc/bTYNuoOJds3R6ywFzqQivpljwXhi wf52ULytjs8WoqtPTPFQmihZkeVQoq3PKvI8xocQyOSEIOASAFEKzv02WRb/SOHnZ4Zj hoMsdIRq1D5Rabg+qAy+P4KsuQWqGMrwSGIIe/IZwkQJyNlA1nSHgxHxmjttQV7plUnH cPeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=CqQTeFdImTPbJ6y2VwFAz5hzdRoVCh1den0ybRFJRgg=; b=MfWELtewSkznq28E+ai9MHTE/KZ5SR2UlKQtO75pQQnqvjW94BpgbO1nud6SuTAadY +R0EQ5FC5nnk5B4KFU5V5lC7+/e10TxXHmld5WUI2GYMVOQcjkQtyAsxAqRxNSA7Qzws I+r2RSQL1XesbLmG/ZXRWQPnQlHx6xtGymLYqZbSUdLXBaBN39wtwh6lfDUyAaCOe7l3 TUzWTyRJi5aj1aIoteyKZkbZEHWoU1lonwSqvWU2FUm8IVbKJnUrDW8DlI/SgcSNF0G8 wntLKIHchtXNn0HsdZtEQh/z9EMTjRziFIVzi7wLbxHCcLo78ms1GngbVHKY+6Cxnwz9 7J5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ftD9lMIk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n11-20020a654ccb000000b00476a48051edsi11893869pgt.476.2022.12.04.06.19.27; Sun, 04 Dec 2022 06:19:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ftD9lMIk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230038AbiLDNfY (ORCPT + 82 others); Sun, 4 Dec 2022 08:35:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbiLDNfX (ORCPT ); Sun, 4 Dec 2022 08:35:23 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F60414004; Sun, 4 Dec 2022 05:35:22 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 9CAA3CE0A0C; Sun, 4 Dec 2022 13:35:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C34AC433D6; Sun, 4 Dec 2022 13:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670160918; bh=VlKuCgOQ28C212SdnRP/jadsFdbY9F2MPbY8bCGAltk=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=ftD9lMIkviQAtO184KO+aoAn20Jjc3vIh19Y2I2f0P8heif44MqUNzOgRSlYIs3dZ 0FTz5DSYFZ8YiF8lL29DHqYnGvNocFHS7Yixw+0czRDskGYPvttpJopeGthCwgBuox I8ZGxowV7JfW+Y0jz5Ed9GXXdsBqNFdyvtaiVWSC7Baec5YwxyEy1PaKW0clq+I1fo CKgIraUYtHeyGvFPiVs+fiUWOPwCAav3/Fv2IQu/OY3Q/AAbXAC2NOaiEry7mrEIf7 EyF7IZoUKsYchwyOcPipHLmB3GtHVv+Z5MfDORVLxzVFEqkz7GrttHl5PqoeGrTqa8 oaeiWD9uMCO/g== From: Leon Romanovsky To: jgg@ziepe.ca, Li Zhijian Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20221203033714.25870-1-lizhijian@fujitsu.com> References: <20221203033714.25870-1-lizhijian@fujitsu.com> Subject: Re: [PATCH] RDMA/mlx5: no need to kfree NULL pointer Message-Id: <167016091277.37965.6806153987261665211.b4-ty@kernel.org> Date: Sun, 04 Dec 2022 15:35:12 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.11.0-dev-87e0e X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 3 Dec 2022 11:37:14 +0800, Li Zhijian wrote: > Goto label 'free' where it will kfree the 'in' is not needed though > it's safe to kfree NULL. Return err code directly to simplify the code. > > 1973 free: > 1974 kfree(in); > 1975 return err; > > [...] Applied, thanks! [1/1] RDMA/mlx5: no need to kfree NULL pointer https://git.kernel.org/rdma/rdma/c/6978837ce42f8b Best regards, -- Leon Romanovsky