Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Sun, 4 Dec 2022 07:57:24 -0800
From:   Guenter Roeck <linux@roeck-us.net>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Badhri Jagan Sridharan <badhri@google.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Kyle Tso <kyletso@google.com>
Subject: Re: [PATCH v3 3/3] usb: typec: maxim_contaminant: Implement
 check_contaminant callback
Message-ID: <20221204155724.GA1862600@roeck-us.net>
References: <20221204084844.3573800-1-badhri@google.com>
 <20221204084844.3573800-3-badhri@google.com>
 <Y4xrpgCTqV4yAplp@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y4xrpgCTqV4yAplp@kroah.com>
Precedence: bulk

On Sun, Dec 04, 2022 at 10:43:02AM +0100, Greg Kroah-Hartman wrote:
> On Sun, Dec 04, 2022 at 12:48:44AM -0800, Badhri Jagan Sridharan wrote:
> > +EXPORT_SYMBOL_GPL(is_contaminant);
> 
> Sorry, but this is a horrible name for the kernel global namespace.
> Please properly prefix it to show exactly what subsystem this is from.
> 

I don't think this needs to be exported either.

Guenter