Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Subject: Re: [PATCH 2/2] perf stat: Fix invalid output handle
From:   Athira Rajeev <atrajeev@linux.vnet.ibm.com>
In-Reply-To: <a0745ad9-c21e-2c93-9af4-46e60bc301fc@arm.com>
Date:   Sun, 4 Dec 2022 22:38:28 +0530
Cc:     Namhyung Kim <namhyung@kernel.org>,
        linux-perf-users@vger.kernel.org,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E93B2D0E-8862-4873-B49F-F74D83CEEDAD@linux.vnet.ibm.com>
References: <20221130111521.334152-1-james.clark@arm.com>
 <20221130111521.334152-2-james.clark@arm.com>
 <CAM9d7cj0Zrv32CgJ7jSjCY=CsOcF40zC2kxE+NSixG4qZDpXqQ@mail.gmail.com>
 <a0745ad9-c21e-2c93-9af4-46e60bc301fc@arm.com>
To:     James Clark <james.clark@arm.com>
Precedence: bulk


> On 01-Dec-2022, at 3:36 PM, James Clark <james.clark@arm.com> wrote:
>=20
>=20
>=20
> On 30/11/2022 18:32, Namhyung Kim wrote:
>> On Wed, Nov 30, 2022 at 3:15 AM James Clark <james.clark@arm.com> =
wrote:
>>>=20
>>> In this context, 'os' is already a pointer so the extra dereference
>>> isn't required. This fixes the following test failure on aarch64:
>>>=20
>>>  $ ./perf test "json output" -vvv
>>>  92: perf stat JSON output linter                                    =
:
>>>  --- start ---
>>>  Checking json output: no args Test failed for input:
>>>  ...
>>>  Fatal error: glibc detected an invalid stdio handle
>>>  ---- end ----
>>>  perf stat JSON output linter: FAILED!
>>>=20
>>> Fixes: e7f4da312259 ("perf stat: Pass struct outstate to =
printout()")
>>> Signed-off-by: James Clark <james.clark@arm.com>
>>=20
>> Thanks for fixing this.  I'm not sure how I missed it.. :(
>>=20
>=20
> It seems to only go down that path on some configuration. At least on
> x86 the test was passing fine for me.
>=20
>> Acked-by: Namhyung Kim <namhyung@kernel.org>
>=20
> Thanks for the review!

Faced same issue on powerpc. Tested with this change and it works with =
this patch.

Tested-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>

Thanks
Athira
>=20
>>=20
>> Thanks,
>> Namhyung
>>=20
>>=20
>>> ---
>>> tools/perf/util/stat-display.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>=20
>>> diff --git a/tools/perf/util/stat-display.c =
b/tools/perf/util/stat-display.c
>>> index 847acdb5dc40..eac5ac3a734c 100644
>>> --- a/tools/perf/util/stat-display.c
>>> +++ b/tools/perf/util/stat-display.c
>>> @@ -741,7 +741,7 @@ static void printout(struct perf_stat_config =
*config, struct outstate *os,
>>>                perf_stat__print_shadow_stats(config, counter, uval, =
map_idx,
>>>                                              &out, =
&config->metric_events, &rt_stat);
>>>        } else {
>>> -               pm(config, &os, /*color=3D*/NULL, /*format=3D*/NULL, =
/*unit=3D*/"", /*val=3D*/0);
>>> +               pm(config, os, /*color=3D*/NULL, /*format=3D*/NULL, =
/*unit=3D*/"", /*val=3D*/0);
>>>        }
>>>=20
>>>        if (!config->metric_only) {
>>> --
>>> 2.25.1