Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp4871965rwb;
        Sun, 4 Dec 2022 09:37:46 -0800 (PST)
X-Google-Smtp-Source: AA0mqf7z2tbZsEcJZ4BUsTWlwyEwbxvEvivoDZKGzbq/wq4jVEjIW6DbPzThDq0OEtihPZBbYCEV
X-Received: by 2002:a17:902:b7cc:b0:189:b36a:544c with SMTP id v12-20020a170902b7cc00b00189b36a544cmr16904939plz.78.1670175466195;
        Sun, 04 Dec 2022 09:37:46 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1670175466; cv=none;
        d=google.com; s=arc-20160816;
        b=V/q7jXCpR4hUppvEdg6qL5vqvx3pXAnT9/MHISgZ80EajBlnrdyAYAlaWJ8uVcSTK0
         WtOTXaEbocvSMrUk0v1oXYrMWm2WaVpw8gBb0p9AJyXkoEH9qdbyYMO418S8wJR+JSMP
         mRYk8BiFglHT109InkE1OkFer/cY3Mpk9dVzq47s7GeUWvjHiSF72rlYmLEdccIdN4su
         k/y6M2+PeuIcGOO/D8Ex8ADxbsU7hsrB/v0cGOrhmZDRyl8ZmsmBrrJ4H6g80z9csIi5
         DfB/s9pMKAs8Ik4571foFnzht/gbDiLA9y1txHGP+h52Y/SdIyyz3c+ZULARmPuoIOMz
         AVuw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:references:message-id:in-reply-to
         :subject:cc:to:from:date:dkim-signature;
        bh=US8RV8rLRBc3Y6eYRhoB9PNQiWAAaPE+LmyqRq6Fb2U=;
        b=0iZyflSrxO5MIXw5yPHQ5SvmywyyX9vaB9p3qEZOQpjqlal3ccc7RJI0JuiazYNwXV
         IR+WspJTJ8RYwaXCzsSDH2U1c68obbpD16e7W69bQFN6hzm/0yf1WYZUCapdHan/Kog9
         FXcwb80OUHFJdMG4TGSgecyWnVl37xixlpcu1qsfM69v2HmyDKIaHYLcqgd82ydBCyWn
         OxXk4sEznaKBYK0Gr9pbzI0nfOcuErLK5MBIm8vDtxjPbnVNBJQgxiCE7ePzW3lntMsK
         n1KdEg8DeVQFBX3uzNrrj6bsxXqYNzgSw6GXXSiDGws4VyX77rEO7Y+9Gq6K4C86Ii+y
         jRog==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@gentwo.de header.s=default header.b="Ep5o62z/";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gentwo.de
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id ot7-20020a17090b3b4700b002196df802afsi11909613pjb.76.2022.12.04.09.37.36;
        Sun, 04 Dec 2022 09:37:46 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@gentwo.de header.s=default header.b="Ep5o62z/";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gentwo.de
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230049AbiLDQWU (ORCPT <rfc822;41i3n8@gmail.com> + 82 others);
        Sun, 4 Dec 2022 11:22:20 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44876 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229753AbiLDQWS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 4 Dec 2022 11:22:18 -0500
Received: from gentwo.de (gentwo.de [161.97.139.209])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F03131402A
        for <linux-kernel@vger.kernel.org>; Sun,  4 Dec 2022 08:22:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.de; s=default;
        t=1670170904; bh=US8RV8rLRBc3Y6eYRhoB9PNQiWAAaPE+LmyqRq6Fb2U=;
        h=Date:From:To:cc:Subject:In-Reply-To:References:From;
        b=Ep5o62z/3URHOiHCgJe/2yW/NEWPSMmEGsOXTs0vw71T0MO3pTNjZ1OmfSu8avoN/
         ll+5xnoc6TuC3v57y70g06DfHjZBm6bJRQ3klXkyTWaznXMoz1t5dEIiLoRXZrbbnp
         9uJpLBpnyjfG/57D770NuSnReTsxE9BAtPogGEJn3Nx8HUH6BmO0eSRD4JeMKalM6l
         8yx0azQQ9zVJ1uQSvHfQ0AHF9Li1bG+/YCpfX1jQv0grEZj1FOZzb6VoQK3moJZHtn
         U4smZQ0jztBM0hwPF9Ec8mSHPK1ETxZ0dGbdrGf/Y07EGq7x8oPK7Q5k1RJz4QR2Yg
         +CrY3cBJpZC1g==
Received: by gentwo.de (Postfix, from userid 1001)
        id E6BCAB000B5; Sun,  4 Dec 2022 17:21:44 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
        by gentwo.de (Postfix) with ESMTP id E3B1FB0001A;
        Sun,  4 Dec 2022 17:21:44 +0100 (CET)
Date:   Sun, 4 Dec 2022 17:21:44 +0100 (CET)
From:   Christoph Lameter <cl@gentwo.de>
To:     Baoquan He <bhe@redhat.com>
cc:     Wupeng Ma <mawupeng1@huawei.com>, akpm@linux-foundation.org,
        tj@kernel.org, dennis@kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 1/1] percpu: cleanup invalid assignment to err in
 pcpu_alloc
In-Reply-To: <Y4yOMmnrT772wFSL@MiWiFi-R3L-srv>
Message-ID: <6a732c63-125e-c033-3869-87dea6c53e8f@gentwo.de>
References: <20221204031430.662169-1-mawupeng1@huawei.com> <Y4yOMmnrT772wFSL@MiWiFi-R3L-srv>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 4 Dec 2022, Baoquan He wrote:

> Can we change the conditional checking in fail part as below?

Yes please. This is potentially a rare condition that should get some
visibility.