Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 4 Dec 2022 21:27:51 +0100
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     lars@metafoo.de, jiasheng@iscas.ac.cn, paul@crapouillou.net,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] iio:adc:twl6030: Enable measurements of VUSB, VBAT and
 others
Message-ID: <20221204212751.2de52084@aktux>
In-Reply-To: <20221204154152.5f7948b9@jic23-huawei>
References: <20221201181635.3522962-1-andreas@kemnade.info>
        <20221204154152.5f7948b9@jic23-huawei>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 4 Dec 2022 15:41:52 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> On Thu,  1 Dec 2022 19:16:35 +0100
> Andreas Kemnade <andreas@kemnade.info> wrote:
> 
> > Some inputs need to be wired up to produce proper measurements,
> > without this change only near zero values are reported.
> > 
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>  
> 
> Sounds like a fix to me.  If so, Fixes tag?

seems to be there since the beginning, to it would be
Fixes: 1696f36482e70 ("iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver")

I think it was just not used with the charger (which is not in mainline yet),
so it was probably ignored.

> 
> Anything in here we should be turning off again if the driver is removed 
> or toggling on suspend? If not, other than the space below this looks fine to me.
> 
I would consider that as configuration, comparing with the nearest relative twl4030,
there a similar bit is set in the probe() without disabling it in the remove().

But I think we should set TWL6030_GPADCR in remove() as we do in suspend(),
but that is another fix.

Regards,
Andreas