Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Dec 2022 09:24:15 +1100
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Al Viro <viro@ZenIV.linux.org.uk>, Gao Xiang <xiang@kernel.org>
Cc:     Gao Xiang <hsiangkao@linux.alibaba.com>,
        Jingbo Xu <jefflexu@linux.alibaba.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: manual merge of the vfs tree with the erofs tree
Message-ID: <20221205092415.56cc6e19@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/g.g95rLd+aEp7LGactM_8Yf";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/g.g95rLd+aEp7LGactM_8Yf
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

Today's linux-next merge of the vfs tree got a conflict in:

  fs/erofs/fscache.c

between commits:

  89175ef1262d ("erofs: switch to prepare_ondemand_read() in fscache mode")
  89175ef1262d ("erofs: switch to prepare_ondemand_read() in fscache mode")

from the erofs tree and commit:

  89175ef1262d ("erofs: switch to prepare_ondemand_read() in fscache mode")

from the vfs tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

--=20
Cheers,
Stephen Rothwell

diff --cc fs/erofs/fscache.c
index f14886c479bd,4c837be3b6e3..000000000000
--- a/fs/erofs/fscache.c
+++ b/fs/erofs/fscache.c
@@@ -126,28 -159,47 +126,28 @@@ static int erofs_fscache_read_folios_as
 =20
  	ret =3D fscache_begin_read_operation(cres, cookie);
  	if (ret)
 -		goto out;
 +		return ret;
 =20
  	while (done < len) {
 -		subreq =3D kzalloc(sizeof(struct netfs_io_subrequest),
 -				 GFP_KERNEL);
 -		if (subreq) {
 -			INIT_LIST_HEAD(&subreq->rreq_link);
 -			refcount_set(&subreq->ref, 2);
 -			subreq->rreq =3D rreq;
 -			refcount_inc(&rreq->ref);
 -		} else {
 -			ret =3D -ENOMEM;
 -			goto out;
 -		}
 -
 -		subreq->start =3D pstart + done;
 -		subreq->len	=3D  len - done;
 -		subreq->flags =3D 1 << NETFS_SREQ_ONDEMAND;
 +		loff_t sstart =3D pstart + done;
 +		size_t slen =3D len - done;
 +		unsigned long flags =3D 1 << NETFS_SREQ_ONDEMAND;
 =20
 -		list_add_tail(&subreq->rreq_link, &rreq->subrequests);
 -
 -		source =3D cres->ops->prepare_read(subreq, LLONG_MAX);
 -		if (WARN_ON(subreq->len =3D=3D 0))
 +		source =3D cres->ops->prepare_ondemand_read(cres,
 +				sstart, &slen, LLONG_MAX, &flags, 0);
 +		if (WARN_ON(slen =3D=3D 0))
  			source =3D NETFS_INVALID_READ;
  		if (source !=3D NETFS_READ_FROM_CACHE) {
 -			erofs_err(sb, "failed to fscache prepare_read (source %d)",
 -				  source);
 -			ret =3D -EIO;
 -			subreq->error =3D ret;
 -			erofs_fscache_put_subrequest(subreq);
 -			goto out;
 +			erofs_err(sb, "failed to fscache prepare_read (source %d)", source);
 +			return -EIO;
  		}
 =20
 -		atomic_inc(&rreq->nr_outstanding);
 +		refcount_inc(&req->ref);
- 		iov_iter_xarray(&iter, READ, &req->mapping->i_pages,
++		iov_iter_xarray(&iter, ITER_DEST, &req->mapping->i_pages,
 +				lstart + done, slen);
 =20
 -		iov_iter_xarray(&iter, ITER_DEST, &rreq->mapping->i_pages,
 -				start + done, subreq->len);
 -
 -		ret =3D fscache_read(cres, subreq->start, &iter,
 -				   NETFS_READ_HOLE_FAIL,
 -				   erofc_fscache_subreq_complete, subreq);
 +		ret =3D fscache_read(cres, sstart, &iter, NETFS_READ_HOLE_FAIL,
 +				   erofs_fscache_subreq_complete, req);
  		if (ret =3D=3D -EIOCBQUEUED)
  			ret =3D 0;
  		if (ret) {
@@@ -233,19 -297,17 +233,19 @@@ static int erofs_fscache_data_read_slic
  		}
  		iov_iter_zero(PAGE_SIZE - size, &iter);
  		erofs_put_metabuf(&buf);
 -		return PAGE_SIZE;
 +		primary->submitted +=3D PAGE_SIZE;
 +		return 0;
  	}
 =20
 +	count =3D primary->len - primary->submitted;
  	if (!(map.m_flags & EROFS_MAP_MAPPED)) {
- 		iov_iter_xarray(&iter, READ, &mapping->i_pages, pos, count);
 -		count =3D len;
+ 		iov_iter_xarray(&iter, ITER_DEST, &mapping->i_pages, pos, count);
  		iov_iter_zero(count, &iter);
 -		return count;
 +		primary->submitted +=3D count;
 +		return 0;
  	}
 =20
 -	count =3D min_t(size_t, map.m_llen - (pos - map.m_la), len);
 +	count =3D min_t(size_t, map.m_llen - (pos - map.m_la), count);
  	DBG_BUGON(!count || count % PAGE_SIZE);
 =20
  	mdev =3D (struct erofs_map_dev) {

--Sig_/g.g95rLd+aEp7LGactM_8Yf
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmONHg8ACgkQAVBC80lX
0GwUEwgAnFSYP2Et4YcN+0kK6vadLkzl0zpYBVtfLY2GEfrfvxZlVnI7zLH1BkYt
/VPCeeCmC2gA34LlhHVrZwwaeNWCG9ApLsh+TeenNhATtCLguSh47jj4cU99PZA/
23BD1a13ihkRp/sYbMurqzBHS1Y7GgQXkofaPAMIIVcB1qKVFQ4sG7hXISB8XjDl
txHyteaQGpR3HuMaSIoJz8UFknSgPGfYhLGkU9HjVmp1bOjmiQxCtmO3myx9whvE
MEAxCiOdTSUitSU6dkwt0leF6aMGaQKX9NR24d6AAJcghC6xRB0ZqvQuHkuJYPnK
g92mpgQOyVAYtnW/He48cE7nbzhRrw==
=deRc
-----END PGP SIGNATURE-----

--Sig_/g.g95rLd+aEp7LGactM_8Yf--