Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <62ee3765-b4fc-db79-5281-7295e43f4314@linux-m68k.org>
Date:   Mon, 5 Dec 2022 10:02:11 +1000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH linux-next] m68k: use strscpy() to instead of strncpy()
To:     yang.yang29@zte.com.cn, geert@linux-m68k.org
Cc:     linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
        xu.panda@zte.com.cn
References: <202212031410566533649@zte.com.cn>
Content-Language: en-US
From:   Greg Ungerer <gerg@linux-m68k.org>
In-Reply-To: <202212031410566533649@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Xu,

On 3/12/22 16:10, yang.yang29@zte.com.cn wrote:
> From: Xu Panda <xu.panda@zte.com.cn>
> 
> The implementation of strscpy() is more robust and safer.
> 
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>

Thanks. Seeing as this is non-MMU related I'll take this through
the m68knommu git tree. Applied to the for-next branch.

Regards
Greg


> ---
>   arch/m68k/kernel/setup_no.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
> index cb6def585851..37fb663559b4 100644
> --- a/arch/m68k/kernel/setup_no.c
> +++ b/arch/m68k/kernel/setup_no.c
> @@ -90,8 +90,7 @@ void __init setup_arch(char **cmdline_p)
>   	config_BSP(&command_line[0], sizeof(command_line));
> 
>   #if defined(CONFIG_BOOTPARAM)
> -	strncpy(&command_line[0], CONFIG_BOOTPARAM_STRING, sizeof(command_line));
> -	command_line[sizeof(command_line) - 1] = 0;
> +	strscpy(&command_line[0], CONFIG_BOOTPARAM_STRING, sizeof(command_line));
>   #endif /* CONFIG_BOOTPARAM */
> 
>   	process_uboot_commandline(&command_line[0], sizeof(command_line));