Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Veerasenareddy Burru <vburru@marvell.com>
To:     Leon Romanovsky <leon@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Liron Himi <lironh@marvell.com>,
        Abhijit Ayarekar <aayarekar@marvell.com>,
        Sathesh B Edara <sedara@marvell.com>,
        Satananda Burla <sburla@marvell.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Subject: RE: [EXT] Re: [PATCH net-next v2 2/9] octeon_ep: poll for control
 messages
Thread-Topic: [EXT] Re: [PATCH net-next v2 2/9] octeon_ep: poll for control
 messages
Thread-Index: AQHZA/PZs+9RX6z1+0m5ZGIy8eBWva5XNNSAgABoFsCAARQmAIACoOYQ
Date:   Mon, 5 Dec 2022 04:46:31 +0000
Message-ID: <BYAPR18MB2423229A66D1C98C6C744EE1CC189@BYAPR18MB2423.namprd18.prod.outlook.com>
References: <20221129130933.25231-1-vburru@marvell.com>
 <20221129130933.25231-3-vburru@marvell.com> <Y4cirWdJipOxmNaT@unreal>
 <BYAPR18MB242397C352B0086140106A46CC159@BYAPR18MB2423.namprd18.prod.outlook.com>
 <Y4hhpFVsENaM45Ho@unreal>
In-Reply-To: <Y4hhpFVsENaM45Ho@unreal>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XBRp5rkEZk/e79ZbXjHasT+H1ZJ9ghZUmB+LrpeEQHldt8sWrkmlQBe81jK4?=
 =?us-ascii?Q?LgtSzxK5sd3W5R7ozIGjgvD0OiHY4LXyjblITwcePPdjKf8rDvFY3dS/hvU8?=
 =?us-ascii?Q?r1uD4DC3icRUzWBAtfv2Wc9qL3DMbu1bwv33VT3/4zlspHXq+KwKbLhRCjAF?=
 =?us-ascii?Q?cSJ4tlT401DxJMfagFGWzCbgblXRoPhKj0pBRGP7ph03kybPw4G46BdVvawl?=
 =?us-ascii?Q?A+kb313mggLk7xVlm71NBPn4LvGp7TeAoS5KUqdBkzvsBf0wsm49ku9VMx7j?=
 =?us-ascii?Q?SW38xoon7XDH9r1SiJMEV6LVb4MOP/PN/bMx6RjHaIDp7JqhDiPIBXxiSbo8?=
 =?us-ascii?Q?JX0DQYVtqlgBDvIVm00AHNLKsOmi8ixK+RZa7vlB9FAcfm64RlR1A54HjEfa?=
 =?us-ascii?Q?4YCXQJ9b+f00ju4yWMuuq3wHXFSgiJru9mGVeAnWXr6DbjAXPXD0lBPGD3gV?=
 =?us-ascii?Q?WwEF+SSYpTjuxehwjkIDM0EYDW3QuIH0OKbzJO/bQEhKhEt14DayDfiM8Orb?=
 =?us-ascii?Q?c5PSLCS+i4Uuksvz0ILlTTS+/1NXVqYrxG8/l4+PXOBV5MemL7fVATrjzLLp?=
 =?us-ascii?Q?u+U7OZDpNVpCJpOEo5XR01x4pI+iILTKn58fGMJFdWUNPo5KoJLmSw5bPc5Z?=
 =?us-ascii?Q?DXrWRt0YFGEbeYZLz+OHpdFIisD7K8a2oMVX4n6bJhY1Z7C0Vb4GgPIfO+ui?=
 =?us-ascii?Q?csdm7F824UJSuDsnTIM0i26ofB0uM7CrEWqXSRwNsbIIfSI3hhcL5vfZYTyl?=
 =?us-ascii?Q?wMsTu7WUhZfpagY5K/u/4gnzJW0I3R4PbNqjLUdDm27gAaAY9q1jlCN0sgmX?=
 =?us-ascii?Q?AmLDo6wapQMsVZoEglS5OPMkGekFLAkx9SbvFgtPX1onQvncp30dDUQcpOlh?=
 =?us-ascii?Q?LpXHNB3w3S5hyxR5ip7YCTl+qkU92buV9b7/c5cGPkdV2e8DzejdFNb/Ztj5?=
 =?us-ascii?Q?a5PNIdPFRMryqNbKGXVCUc1DIs3GOL9UCuXv1eDr5r8zAOz3oWbUHVuFEuom?=
 =?us-ascii?Q?2JVeG17fYRPHKNoTwwgy22/90NUf5FXrYIo8GLYyLAuV0mjP8bz/mFpqA2eu?=
 =?us-ascii?Q?iAXzaQEUKjnd6+Zpb2hCFs19JPoQp1sd9E0didXHZ2ebauCq8waJIP6bA3Mz?=
 =?us-ascii?Q?naYfpkt4DBRn09GWowha79jPFONsu74cv+WUqF8u7KsxK/XMp3xJwdvpc7Ou?=
 =?us-ascii?Q?0/PFYCSDoNbPw1JT70WRMNTx0gHVxJvIpF9r0yt/P5wQnNpbLzZzovNqgaCO?=
 =?us-ascii?Q?IdLyJgrn8ly0CaK33wXaJoOgcB995K5JldQP8nkSGU7jI/26upwlFdNrWRy4?=
 =?us-ascii?Q?uB7lPtsZmyvCC2CSmS6rdsdbtOn3A2gQGfBeiFgjQ96z6M2YS/NQzbQW/O/+?=
 =?us-ascii?Q?ENFdvxnpO+cagq325xSi6F33eljA3ClS1/8SOSIiTi0Rg+O9aqynh29z48FV?=
 =?us-ascii?Q?5TxrJdjX8cU5hwg6yeV2/NcO+M45n1VsJ97eTuOkL8Np1Sbf0AHlynMFmMiq?=
 =?us-ascii?Q?/qYpeL54zT3zHvcISX35PbUYatiu3xAfFMEZJURzE72vZ9GRLYVrNDGVt1sM?=
 =?us-ascii?Q?UB5onK0M4cSohbVk0ik=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR18MB2423.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1758dff-dc34-4b6a-91e9-08dad67bae36
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2022 04:46:31.8323
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7nlDpTh/i4EjBmaIseIRnB3sXA97s7oJtMTcniGm7bVa5HFyxAtyLEcE0JIwFLXGwA3ggnV5aZkg6wNUswypTw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4500
X-Proofpoint-ORIG-GUID: nRsWKkzG4WcBUvpqSACymvYVH_PXyoFk
X-Proofpoint-GUID: nRsWKkzG4WcBUvpqSACymvYVH_PXyoFk
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-05_01,2022-12-01_01,2022-06-22_01
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Leon Romanovsky <leon@kernel.org>
> Sent: Thursday, December 1, 2022 12:11 AM
> To: Veerasenareddy Burru <vburru@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Liron Himi
> <lironh@marvell.com>; Abhijit Ayarekar <aayarekar@marvell.com>; Sathesh
> B Edara <sedara@marvell.com>; Satananda Burla <sburla@marvell.com>;
> linux-doc@vger.kernel.org; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
> Paolo Abeni <pabeni@redhat.com>
> Subject: Re: [EXT] Re: [PATCH net-next v2 2/9] octeon_ep: poll for contro=
l
> messages
>=20
> On Wed, Nov 30, 2022 at 03:44:30PM +0000, Veerasenareddy Burru wrote:
> >
> >
> > > -----Original Message-----
> > > From: Leon Romanovsky <leon@kernel.org>
> > > Sent: Wednesday, November 30, 2022 1:30 AM
> > > To: Veerasenareddy Burru <vburru@marvell.com>
> > > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Liron Himi
> > > <lironh@marvell.com>; Abhijit Ayarekar <aayarekar@marvell.com>;
> > > Sathesh B Edara <sedara@marvell.com>; Satananda Burla
> > > <sburla@marvell.com>; linux-doc@vger.kernel.org; David S. Miller
> > > <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>;
> Jakub
> > > Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>
> > > Subject: [EXT] Re: [PATCH net-next v2 2/9] octeon_ep: poll for
> > > control messages
> > >
> > > External Email
> > >
> > > --------------------------------------------------------------------
> > > -- On Tue, Nov 29, 2022 at 05:09:25AM -0800, Veerasenareddy Burru
> > > wrote:
> > > > Poll for control messages until interrupts are enabled.
> > > > All the interrupts are enabled in ndo_open().
> > >
> > > So what are you saying if I have your device and didn't enable
> > > network device, you will poll forever?
> > Yes, Leon. It will poll periodically until network interface is enabled=
.
>=20
> I don't know if it is acceptable behaviour in netdev, but it doesn't soun=
d right
> to me. What type of control messages will be sent by FW, which PF should
> listen to them?
>=20

These messages include periodic keep alive (heartbeat) messages from FW and=
 control messages from VFs.
Every PF will be listening for its own control messages.

Thank you.

> > >
> > > > Add ability to listen for notifications from firmware before ndo_op=
en().
> > > > Once interrupts are enabled, this polling is disabled and all the
> > > > messages are processed by bottom half of interrupt handler.
> > > >
> > > > Signed-off-by: Veerasenareddy Burru <vburru@marvell.com>
> > > > Signed-off-by: Abhijit Ayarekar <aayarekar@marvell.com>
> > > > ---
> > > > v1 -> v2:
> > > >  * removed device status oct->status, as it is not required with th=
e
> > > >    modified implementation in 0001-xxxx.patch
> > > >
> > > >  .../marvell/octeon_ep/octep_cn9k_pf.c         | 49 +++++++++------=
----
> > > >  .../ethernet/marvell/octeon_ep/octep_main.c   | 35 +++++++++++++
> > > >  .../ethernet/marvell/octeon_ep/octep_main.h   | 11 ++++-
> > > >  .../marvell/octeon_ep/octep_regs_cn9k_pf.h    |  4 ++
> > > >  4 files changed, 71 insertions(+), 28 deletions(-)
> > > >
> > > > diff --git
> > > > a/drivers/net/ethernet/marvell/octeon_ep/octep_cn9k_pf.c
> > > > b/drivers/net/ethernet/marvell/octeon_ep/octep_cn9k_pf.c
> > > > index 6ad88d0fe43f..ace2dfd1e918 100644
> > > > --- a/drivers/net/ethernet/marvell/octeon_ep/octep_cn9k_pf.c
> > > > +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_cn9k_pf.c
> > > > @@ -352,27 +352,36 @@ static void
> > > octep_setup_mbox_regs_cn93_pf(struct octep_device *oct, int q_no)
> > > >  	mbox->mbox_read_reg =3D oct->mmio[0].hw_addr +
> > > > CN93_SDP_R_MBOX_VF_PF_DATA(q_no);  }
> > > >
> > > > -/* Mailbox Interrupt handler */
> > > > -static void cn93_handle_pf_mbox_intr(struct octep_device *oct)
> > > > +/* Process non-ioq interrupts required to keep pf interface runnin=
g.
> > > > + * OEI_RINT is needed for control mailbox  */ static int
> > > > +octep_poll_non_ioq_interrupts_cn93_pf(struct octep_device *oct)
> > > >  {
> > > > -	u64 mbox_int_val =3D 0ULL, val =3D 0ULL, qno =3D 0ULL;
> > > > +	u64 reg0;
> > > > +	int handled =3D 0;
> > >
> > > Reversed Christmas tree.
> > Thanks for the feedback. Will revise the patch.
>=20
> It is applicable to all patches.
>=20
> And please fix your email client to properly add blank lines between repl=
ies.
>=20
> Thanks
>=20
> > >
> > > Thanks