Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <899d9d4c-36e8-6a4f-4243-dcf16f9ef29f@loongson.cn>
Date:   Mon, 5 Dec 2022 14:04:09 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v10 1/2] gpio: loongson: add gpio driver support
To:     Andy Shevchenko <andriy.shevchenko@intel.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        WANG Xuerui <kernel@xen0n.name>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Juxin Gao <gaojuxin@loongson.cn>,
        Bibo Mao <maobibo@loongson.cn>,
        Yanteng Si <siyanteng@loongson.cn>, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        loongarch@lists.linux.dev, linux-mips@vger.kernel.org,
        Arnaud Patard <apatard@mandriva.com>,
        Huacai Chen <chenhuacai@kernel.org>,
        Jianmin Lv <lvjianmin@loongson.cn>,
        Hongchen Zhang <zhanghongchen@loongson.cn>,
        Liu Peibao <liupeibao@loongson.cn>
References: <20221201123220.7893-1-zhuyinbo@loongson.cn>
 <CACRpkdZm-4-5625szX_VqJoQH1OQZnw+jH3SqWsb9nr3S0Nbmw@mail.gmail.com>
 <35ff475a-e925-81eb-ffeb-448be43f59ff@loongson.cn>
 <Y4tq4i2CJdnQWFZC@smile.fi.intel.com> <Y4tuOyKOdZcQ4sjm@smile.fi.intel.com>
From:   Yinbo Zhu <zhuyinbo@loongson.cn>
In-Reply-To: <Y4tuOyKOdZcQ4sjm@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2022/12/3 23:41, Andy Shevchenko 写道:
> On Sat, Dec 03, 2022 at 05:27:31PM +0200, Andy Shevchenko wrote:
>> On Sat, Dec 03, 2022 at 06:53:20PM +0800, Yinbo Zhu wrote:
>>> 在 2022/12/3 18:03, Linus Walleij 写道:
>>>> On Thu, Dec 1, 2022 at 1:33 PM Yinbo Zhu <zhuyinbo@loongson.cn> wrote:
>>>>> +config GPIO_LOONGSON_64BIT
>>>>> +       tristate "Loongson 64 bit GPIO support"
>>>>> +       depends on LOONGARCH || COMPILE_TEST
>>>>> +       select GPIO_GENERIC
>>>>> +       select GPIOLIB_IRQCHIP
>>>> If the kernelbots start complaining you might need to add a:
>>>>
>>>> select IRQ_DOMAIN_HIERARCHY
>>>>
>>>> here.
>>> Bartosz had merged my patch and I will add a change on top of the existing
>>> series.
>> I don;'t know why he had done that, the driver requires a lot of cleanups,
>> e.g. why it uses acpi.h, what that "nice" container of the platform device for.

I just compile it that it is still okay when remove acpi.h, so I will 
remove it in v11.

and, I'm afraid I didn't catch your meaning about "

what that "nice" container of the platform device for."


you said is for following code ?
144         struct platform_device *pdev =
145                 container_of(chip->parent, struct platform_device, dev);

> + we have macros for get_direction() returned values and so on.
okay, I will use that macros in v11.