Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5482631rwb; Sun, 4 Dec 2022 22:51:25 -0800 (PST) X-Google-Smtp-Source: AA0mqf4NUbpxmno9nTASNxpGHhdpJkdgCg3rKChj6mLfOwXQrexcHrU/dYMQ73UJFTvw7tG8b6uU X-Received: by 2002:a05:6402:3785:b0:461:e598:e0bb with SMTP id et5-20020a056402378500b00461e598e0bbmr10333784edb.21.1670223085598; Sun, 04 Dec 2022 22:51:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670223085; cv=none; d=google.com; s=arc-20160816; b=lU0RtlQGgrzNZ/de5i4ZXL9NKJVXdgE5ze1xG8v9vqMMNwAFDEP0oocvsL/4yIRyuu mKJsYqH8/0to+Cb3+IqY3h8qrlG4r8QV1/sKrlbQv4np2GmeWTuCM/xTYTakglEknpPU 4qc+vLpH4DC/fOfn+0QT/dnmmZSU/EAoE/Jf0mkqBi81klkeQh/YdoBsmTe763rqA/jZ 3hOqt6tyNkblLzBpa2/xxgiF51hDbtXDwq+0nIssFSL3gmnC25uitaUvAoDgUkJcAziJ O1eTuCaBOLiA6f18ZYcAFbIjTcgvh+SuqvflGUd8D1Jvc9fEkYMTTJ6UA4I6C3w3Fa1e pfvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mkC5JbvhIAEVlL4W9PX3C93AXIIetRtoX9YfDfghWVM=; b=cjPiBMYnBFblu4nJkrQ/nrnIUv6QGjJFBUgDoyz4PSdsI1LPestLPok4UfpBfjPOPZ 8WnwKpOu90Tn0+W+5dpZFGDjWFjVPXRPogfJ7JtY03BH2PQY2LK29y4HHgstqfwmEsPC kM7vkp2NXXe0XMXbeNsbPeusl3ibAG3mJE1aMF5FOQNyuaNq/CWPwzs76dyOqtoV9zpx iAQvGnE3i3A4WliIOv3MeAs9bXbHAZC/orV6BFIKPcVqcuTe19QtQo8yNdqFkGH3rIwr u7pHsC9emCGEa/1BL08NTAxcjNzzjJMpz/JWIC7g6mdcMaSykxWO1LzoqNvL4ABfQIl/ wwwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZI0BVErd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cs13-20020a170906dc8d00b007ae29da29e4si11217073ejc.962.2022.12.04.22.51.05; Sun, 04 Dec 2022 22:51:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZI0BVErd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231637AbiLEGS4 (ORCPT + 83 others); Mon, 5 Dec 2022 01:18:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231239AbiLEGSu (ORCPT ); Mon, 5 Dec 2022 01:18:50 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4BB5DFEC for ; Sun, 4 Dec 2022 22:18:49 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 34AD460F64 for ; Mon, 5 Dec 2022 06:18:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 995A9C433D6; Mon, 5 Dec 2022 06:18:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670221128; bh=W33NQFED21c+6UVqfmxS3Py544P8P6AaTZgzm21x5xo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZI0BVErdNz6S3GY+S1GvVTKarxwpU8wiqJa3zFwHVZO6g1qDAy7EDQJO5kg5xE9sk 3TQttRYx24UuXXEbnThaFcoJHbt6bUHXNjOSBGGaniK85qHxnQHbxhAcPZ39UjaYYW snQNq3ILOyofYAe2LEQ0CdIf2XCf9ts9oANlhs/f36XCL1m/3ftUFvWrWmqc3N/EL2 +jZ7wh+0SXpMNKhkRjOjOPJke1SXaU9HWR5aP2op1flCtXzlWKW8/VAssL901VUb8G 1N6yth0YFC7P2F20nhBO9zPi1Zo0Ps+HoT0Lt5TA15kI/8hnyNBSTIY1c4wJoVVHLu rcEQVeTFKgZwA== Date: Mon, 5 Dec 2022 14:18:45 +0800 From: Tzung-Bi Shih To: ye.xingchen@zte.com.cn Cc: bleung@chromium.org, groeck@chromium.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] platform/chrome: use sysfs_emit() to instead of scnprintf() Message-ID: References: <202212021656040995199@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202212021656040995199@zte.com.cn> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 02, 2022 at 04:56:04PM +0800, ye.xingchen@zte.com.cn wrote: > From: ye xingchen > > Follow the advice of the Documentation/filesystems/sysfs.rst and show() > should only use sysfs_emit() or sysfs_emit_at() when formatting the > value to be returned to user space. > > Signed-off-by: ye xingchen Fixed the commit message a bit and queued the patch. Also, I found a little more here: https://patchwork.kernel.org/project/chrome-platform/patch/20221205061042.1774769-1-tzungbi@kernel.org/