Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Dec 2022 09:45:56 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Max Staudt <max@enpas.org>
Cc:     Wolfgang Grandegger <wg@grandegger.com>,
        Vincent Mailhol <vincent.mailhol@gmail.com>,
        Oliver Neukum <oneukum@suse.com>, linux-kernel@vger.kernel.org,
        "Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] can: can327: Flush tx_work on ldisc .close()
Message-ID: <20221205084556.etpo2xufbsl5753d@pengutronix.de>
References: <20221202160148.282564-1-max@enpas.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="y3v7ghucklse6fhe"
Content-Disposition: inline
In-Reply-To: <20221202160148.282564-1-max@enpas.org>
Precedence: bulk


--y3v7ghucklse6fhe
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 03.12.2022 01:01:48, Max Staudt wrote:
> Additionally, remove it from .ndo_stop().
>=20
> This ensures that the worker is not called after being freed, and that
> the UART TX queue remains active to send final commands when the netdev
> is stopped.
>=20
> Thanks to Jiri Slaby for finding this in slcan:
>=20
>   https://lore.kernel.org/linux-can/20221201073426.17328-1-jirislaby@kern=
el.org/
>=20
> A variant of this patch for slcan, with the flush in .ndo_stop() still
> present, has been tested successfully on physical hardware:
>=20
>   https://bugzilla.suse.com/show_bug.cgi?id=3D1205597
>=20
> Fixes: 43da2f07622f ("can: can327: CAN/ldisc driver for ELM327 based OBD-=
II adapters")
> Cc: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
> Cc: Max Staudt <max@enpas.org>
> Cc: Wolfgang Grandegger <wg@grandegger.com>
> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: linux-can@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: stable@vger.kernel.org
> Signed-off-by: Max Staudt <max@enpas.org>

Applied to linux-can.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--y3v7ghucklse6fhe
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmONr8EACgkQrX5LkNig
012LCwf8CMDCZv6PnSKRAlBjjjDBvBq29KA/kv21asReFn7i+WoSd6hqvKIT0mnM
7oKfo57cdk2qPJC1hjzsRtnMHlvgEXlqHFFkJtqD08IXPW/n+hJt3O3R4qpe6q0Q
ooLTpZTC7l8Ze6MEdeO95DOfFj71ziLBk+583Xjm+caUNwE9IeDzXHBlv3F6+Sji
efgmaCKqsgmEoJMc7Enz+412PAiMtN/8mHfH4par5n3WP0nIOD4njkWXpyOu7WnU
ORiRJideTEgeSQwDkiUJkjfDo+iFVvtWLeSVViYcUXlOeOfDTYvhhYGjTofRd6Ja
XWGZDP69+co9pHGh58o78sd+jbI+ag==
=urxd
-----END PGP SIGNATURE-----

--y3v7ghucklse6fhe--