Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Dec 2022 10:43:39 +0100
From:   Wolfram Sang <wsa@kernel.org>
To:     Stephen Kitt <steve@sk2.org>
Cc:     Guenter Roeck <linux@roeck-us.net>, Peter Rosin <peda@axentia.se>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/i2c: use simple i2c probe
Message-ID: <Y429SywVngrf2Q9I@ninjato>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Stephen Kitt <steve@sk2.org>, Guenter Roeck <linux@roeck-us.net>,
        Peter Rosin <peda@axentia.se>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221012163647.3930565-1-steve@sk2.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="qTaLEuURhpk3LiI/"
Content-Disposition: inline
In-Reply-To: <20221012163647.3930565-1-steve@sk2.org>
Precedence: bulk


--qTaLEuURhpk3LiI/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 12, 2022 at 06:36:47PM +0200, Stephen Kitt wrote:
> All these drivers have an i2c probe function which doesn't use the
> "struct i2c_device_id *id" parameter, so they can trivially be
> converted to the "probe_new" style of probe with a single argument.
>=20
> This is part of an ongoing transition to single-argument i2c probe
> functions. Old-style probe functions involve a call to i2c_match_id:
> in drivers/i2c/i2c-core-base.c,
>=20
>          /*
>           * When there are no more users of probe(),
>           * rename probe_new to probe.
>           */
>          if (driver->probe_new)
>                  status =3D driver->probe_new(client);
>          else if (driver->probe)
>                  status =3D driver->probe(client,
>                                         i2c_match_id(driver->id_table, cl=
ient));
>          else
>                  status =3D -EINVAL;
>=20
> Drivers which don't need the second parameter can be declared using
> probe_new instead, avoiding the call to i2c_match_id. Drivers which do
> can still be converted to probe_new-style, calling i2c_match_id
> themselves (as is done currently for of_match_id).
>=20
> This change was done using the following Coccinelle script, and fixed
> up for whitespace changes:
>=20
> @ rule1 @
> identifier fn;
> identifier client, id;
> @@
>=20
> - static int fn(struct i2c_client *client, const struct i2c_device_id *id)
> + static int fn(struct i2c_client *client)
> {
> ...when !=3D id
> }
>=20
> @ rule2 depends on rule1 @
> identifier rule1.fn;
> identifier driver;
> @@
>=20
> struct i2c_driver driver =3D {
> -       .probe
> +       .probe_new
>                 =3D
> (
>                    fn
> |
> -                  &fn
> +                  fn
> )
>                 ,
> };
>=20
> Signed-off-by: Stephen Kitt <steve@sk2.org>

Dropped the mux-part because I applied an older patch doing the same.
Despite that, applied the rest to for-next, thanks!


--qTaLEuURhpk3LiI/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmONvUsACgkQFA3kzBSg
KbaZtw/7Bw8qWJ/EO16/DWsZFw3b7UK+vssIrQB0ygAmIGAyef7b9VN9nuJAw+fD
fqbA/xTn0bylU4In7nB7ld0YJ9l1iPTnoXsK7J1QkEg1T65MDHugz0iwLXopc+lx
y3WvupwfSa2D3o9R1YR4iBOGYjcc3+XAGF+9WFwoZ21Az2HDGPVChQQHAQHplJpN
nYepLm1/MZ2qqoEpB1kZoNSdgvCtXBCVCutWpufRA6TqZSOxs6hARBsQ/mFAGL7K
STSlrzybN/UVhI27Z03x6kiEC3sCcXlCo/pXu5hY4dRZpkcO80TXJ1jaXnR40nWh
T6EiNzAHsqCDdy7/OysCDVrZAOyxynxjaILrhdxQdRnKauTEsa+3S90rXpgXCEkf
Y3iE8mh2Lpaq87zPTEPgQqH2uETsnJb/f3CD1igjTA95wx5+WwNNzNm7H+G2c0be
Zoiv6iJgNOtb+JzYDhz175owFV8zVuXWK6crOScywqVndUR3P4mpbbSbWsq/YjTi
9lElGSIVZt3CKKccdHojPBdK15cTD7O/EUDSOdOlK88fkxeVhQG93d07QqQ/oeoq
ra4oX+ewiEY7v2cm+jnob3O6RBBn1f6USOACQRvaolKq9V2aCWmPC6ppxPgSLnBX
JhL01EkzdVsOgHAEXt+cZT2qvzaBjuHw65vEM4EU5nXsW0RcUuA=
=f7EH
-----END PGP SIGNATURE-----

--qTaLEuURhpk3LiI/--