Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5682943rwb; Mon, 5 Dec 2022 02:37:18 -0800 (PST) X-Google-Smtp-Source: AA0mqf5qV+rzR4Qn6+b18fNjgiH3ByZ05GYrqhOMlgbHSi5kbWHcH2UGPTIEnIFPJLYufb67yi0g X-Received: by 2002:a63:d944:0:b0:478:cd7c:9085 with SMTP id e4-20020a63d944000000b00478cd7c9085mr944100pgj.571.1670236638349; Mon, 05 Dec 2022 02:37:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670236638; cv=none; d=google.com; s=arc-20160816; b=gBgSM+bUxE5smErPp2KS5gi+i5RNZj39cL16kTd0JRSC2X8YoJlyDfn7R2hlfJiLh2 awLDbNwHfwOXig+3n9+CKiAMNiEuy9Ycmcmfhev67FdAANve9hnlcoRwowGuWZy3A/EW XiIammRabLhJwyNQap8zHXENEA0bC0+W7dpUqnjLp6XoRcfmfOn4BMGkzzZT1JoPd6Wh Xvjrc6js2rWPV96avw4F8E5geNwHTdXKLM/hyk2M6NdoOs+T3O6KNHfcd9ACateTUUWt vhMQrmzvwTq6mzTRblLmYoAZSqMyBrlLfxK6pdc+hQRaacEVzw8jdT4wUtcihw9VA1qT T/ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gzHuYHSbcboXDfFkwQdWcAsmcDgzO+RAlcVGLaNDnAY=; b=wX11CuQOUnQ1cXu/m4NehyLL0/l/YuzqPu4hfZNxUsTBCAZ9GCCemf0yqMr/ZzK1Mj yBCmz3Ir0Pc4YMajW6Q6ISqP1oavQ0593yRkkgNun8hyiu3nARvFkvtpljl+HH7EYBUl pvcLYlLjkBqnMgavNkWAzLMdDVc7xQTFoqcQsN76kyS79KmldOyhBvn1QeAosw5a5sBS 3+cS5YevD3/wTgWT6bAJdebO2OkGTe5dBdro33sX8uCTZzlfV+inVW2TmlfkK3OVK5VK yJei89NlO4uY2ClCyx3+Dsp0uJt2rgm9iF4KnM9LnKYgFdLoNO7WL6sfr2tbm+FiIbPH w8gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dSJeMiAG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b10-20020a6541ca000000b0046aff3cb64dsi10702676pgq.410.2022.12.05.02.37.06; Mon, 05 Dec 2022 02:37:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dSJeMiAG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231483AbiLEJ6x (ORCPT + 82 others); Mon, 5 Dec 2022 04:58:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230092AbiLEJ6u (ORCPT ); Mon, 5 Dec 2022 04:58:50 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9440DECF; Mon, 5 Dec 2022 01:58:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670234329; x=1701770329; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=upaZo6fjhhnh+UlqOySD7G2L3bnZ7lNoi+82BMImAOo=; b=dSJeMiAGkGorsrAERzEFqSLlzQUYuCuSOScynW0cx7VA+odqBmgUYdLJ FbQjN4VIEHhGUkJ+CYw4iY5I3U2sEXZASXWlwRFsI7thpbL1xE5JzVtUk ZJ3BWksm5KsKuywHrL8A6WlDOZiZkvdDXfk1bQntEWn54o5ZnItIpyREH RHvI7Jl3oknoGXU60SGDbqjSdBO5vLM0oT6JzVMrQZ6K7FwvlLQ4facQZ upo5yO+0sNxBRwEcq8a4dQT8pazGCa5WA5+ugHXg/zd4doacvByb0b9cU 3mP1xc5apgIrPtmm9QVhkpAuc9quFHt9Zzev9Upl1NSkbH56jF4bedQBZ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10551"; a="296009088" X-IronPort-AV: E=Sophos;i="5.96,219,1665471600"; d="scan'208";a="296009088" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2022 01:58:49 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10551"; a="820137760" X-IronPort-AV: E=Sophos;i="5.96,219,1665471600"; d="scan'208";a="820137760" Received: from punajuuri.fi.intel.com (HELO paasikivi.fi.intel.com) ([10.237.72.43]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2022 01:58:47 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 13E962033F; Mon, 5 Dec 2022 11:58:45 +0200 (EET) Date: Mon, 5 Dec 2022 09:58:45 +0000 From: Sakari Ailus To: Ricardo Ribalda Cc: Pavel Machek , Mauro Carvalho Chehab , Pali Rohar , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH v2] media: i2c: ad5820: Fix error path Message-ID: References: <20220921-ad5820-v2-0-3e5cabb04786@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220921-ad5820-v2-0-3e5cabb04786@chromium.org> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ricardo, On Fri, Dec 02, 2022 at 05:35:59PM +0100, Ricardo Ribalda wrote: > Error path seems to be swaped. Fix the order and provide some meaningful > names. > > Fixes: bee3d5115611 ("[media] ad5820: Add driver for auto-focus coil") > Signed-off-by: Ricardo Ribalda I'm afraid v1 has already been merged. But I understand patch content wasn't really different so that should be fine. -- Kind regards, Sakari Ailus