Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5693911rwb; Mon, 5 Dec 2022 02:50:08 -0800 (PST) X-Google-Smtp-Source: AA0mqf52DXMYtBOMj8rxyhNBotBdV6ua2d6Yk6jwWrcS6Eh6idr098e1Q0S+yOv52DDTiA3oMDTX X-Received: by 2002:a17:907:8f01:b0:7c0:e391:c548 with SMTP id wg1-20020a1709078f0100b007c0e391c548mr6300770ejc.18.1670237408267; Mon, 05 Dec 2022 02:50:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670237408; cv=none; d=google.com; s=arc-20160816; b=0oLHfsXr4gSgrhSAm78u7rA33RvyfzzMMjI1J+8iYb1rGIrEYrg1YMZu5+RtsfJHgW Q9rpT/8JwOAISqgxLFw6mJR+93e5f+Pv/xhWu/aZcXwoPR8233j8GqtcM1WoEjDY1HH0 TyPfskr/PKXOk8X10YqFqf/dOLN0KyBjY7a6nlsU2DMyeVa6zgz5gWMs4vGwUfkJ91FG t4Cm5fKqACYnIH0U30AnEWt2w1N+t+EHBz5PXh2CFjqb06iDagLmqsT0/mjgeQmABUja o9p5yUabN3ydh+3KQxbJzD01nn1j5+9sPN4H/oeG4ub1Rj67A0Rjq9afc8eRQDSvZepS 9BvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=NQ6cAl+86TDUB9cUa1/EWsCMl2DdMF0dDV8o8yg5Vqo=; b=0ghHbxUozkD1aeqRn1aStD+KqIKUVSNc9iLKnoLuGx2Aap0W/i6CkYIBVwG/UGPUXC dbztECMC1N8jJGTR42WXSBxQLoSWVhfYrHTCM70DwRO/322O56XYL5RA40xeSZnPr+cX J6vgmW291CRR8QIOk4cz0KmmaleaKWlqm8a2Q0C960txKF0pSKQzImoSADYaPAhBs1IK lRC2FVOnSVkqjTyqCT/xEFv1Jx+VJm0HGGf+hmWNYehA9fkN+5ynoSU7gFy6mE4FmH3Q xdRMYX8Id4GVShhlM8HePmIPiEXPAl+CjnYeM4d1v5ywivsYzHe5rKeOMHRcAi1SxFFV XRQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Dbxfud1E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dn22-20020a17090794d600b0077082e784easi11508689ejc.957.2022.12.05.02.49.47; Mon, 05 Dec 2022 02:50:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Dbxfud1E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231538AbiLEKAO (ORCPT + 82 others); Mon, 5 Dec 2022 05:00:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231487AbiLEKAM (ORCPT ); Mon, 5 Dec 2022 05:00:12 -0500 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 065A7E0BA for ; Mon, 5 Dec 2022 02:00:11 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id z8-20020a17090abd8800b00219ed30ce47so55402pjr.3 for ; Mon, 05 Dec 2022 02:00:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NQ6cAl+86TDUB9cUa1/EWsCMl2DdMF0dDV8o8yg5Vqo=; b=Dbxfud1EIQCczeM8D9qo8COwwUq+htWEyYt1aSASCGolP60aSlSkGvfIRY3Rermc9u X5GRzZ7JcDLi/ldCbMiflREi3JaZChi7ELkotb/7nyPofwcTUp4G6zeIoao9gbEhpr8q 8c+EUEW3AMqohdDWA3ZEJV+vyQzGcqjM7qQu4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NQ6cAl+86TDUB9cUa1/EWsCMl2DdMF0dDV8o8yg5Vqo=; b=JfQpVqZlXr2Z9eQZjhAMNZzwpYtjU27XJzrJiL0aCBm6+r3p6+U578KK1y8IMJ6y+z yUCulqC0Ul1ry3HhcKEwFpIyB2A4GsxuOuhtrQys8uvT/Tbgmtg0mHKwZlVqBuPUK12N xziYmSSdB8WmujmtqaQusJQkiBYbnEI7VMpInFSSayFXm04yANX6W9cF276ZK+0OMSoJ G1xnZ46zCSAF5DMl51vDuJHRznlxvHbL7UdDnW/sW24NqzbCryJM7qwy+trDMPzIked5 WvUK2NDKE5GKB5M0SQJFG1sZlotrgzK1XR+rZwOCHBTkhKh1WIRjpLUaihJX7jCgZ2Ym 793g== X-Gm-Message-State: ANoB5plVwpS68z9n32UoVWY9XIcbJ4HcZS1dDkfXjG/H85TulWJdIoBE j4ob9FahfJBSNZ9xruP8/vNQe73J7Q6n/z0T X-Received: by 2002:a17:90b:3c4c:b0:218:a8a1:933a with SMTP id pm12-20020a17090b3c4c00b00218a8a1933amr73171225pjb.14.1670234410351; Mon, 05 Dec 2022 02:00:10 -0800 (PST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com. [209.85.214.171]) by smtp.gmail.com with ESMTPSA id n9-20020a170902e54900b001898ca438fcsm10220857plf.282.2022.12.05.02.00.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Dec 2022 02:00:09 -0800 (PST) Received: by mail-pl1-f171.google.com with SMTP id jn7so10296506plb.13 for ; Mon, 05 Dec 2022 02:00:08 -0800 (PST) X-Received: by 2002:a17:90b:944:b0:219:33a1:d05f with SMTP id dw4-20020a17090b094400b0021933a1d05fmr40319988pjb.116.1670234407771; Mon, 05 Dec 2022 02:00:07 -0800 (PST) MIME-Version: 1.0 References: <20220921-ad5820-v2-0-3e5cabb04786@chromium.org> In-Reply-To: From: Ricardo Ribalda Date: Mon, 5 Dec 2022 10:59:56 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] media: i2c: ad5820: Fix error path To: Sakari Ailus Cc: Pavel Machek , Mauro Carvalho Chehab , Pali Rohar , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Dec 2022 at 10:58, Sakari Ailus wrote: > > Hi Ricardo, > > On Fri, Dec 02, 2022 at 05:35:59PM +0100, Ricardo Ribalda wrote: > > Error path seems to be swaped. Fix the order and provide some meaningful > > names. > > > > Fixes: bee3d5115611 ("[media] ad5820: Add driver for auto-focus coil") > > Signed-off-by: Ricardo Ribalda > > I'm afraid v1 has already been merged. But I understand patch content > wasn't really different so that should be fine. Sorry I missed that :) Thanks! > > -- > Kind regards, > > Sakari Ailus -- Ricardo Ribalda