Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5703745rwb; Mon, 5 Dec 2022 03:01:06 -0800 (PST) X-Google-Smtp-Source: AA0mqf7wnBUxpFKdUz1m/1O/d1LHl/p5CWA1ezZVPHk8TbCafbjOIkeLQal7lbOWsXnL9MSWHyY/ X-Received: by 2002:a63:5263:0:b0:439:8dd3:c3c2 with SMTP id s35-20020a635263000000b004398dd3c3c2mr54633062pgl.481.1670238066336; Mon, 05 Dec 2022 03:01:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670238066; cv=none; d=google.com; s=arc-20160816; b=cwhIHmgqJ9K89aL2QOOGno/qLeplQnogvbEqYBs9T1TuZwcLLyR04zmG5/ole2x9Lx SunmXwkDQ3l1p8VR/IXnNUjz0+5MkhO+cWUNvBr7K1i1zsX5PRsgmNy4z6dAYNq9JBln Ig5Cd46JbZmY8qmodIsEGnBq7EG9xeA9mGDmR1mKWcDArZiczw9ZBYJ5BQUqDIvnvx+8 KJGpV4KZSAwa5C/XQoTebhF4QOPczyH3x6g/fkKbZizlfttXnvtbYw2pYkGDT7w4uROU YvxtwCObsL+4qDNXzUHjYveT3kCrB++HUaANLLrfejujCPtTEqH4G8XRT9YQtBlHNrd5 2IVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=99HykxLgM645Ky9iWy53Cx4gvJnt6UjlNW+frpV58xI=; b=TJF8G2UYBQQb86WcY+zWZ0egEcr67vU+sxnconmUkuc1z8JpvHOiImx2hi/Gp2sGpQ lHLVqRRH+Q07CNyQcZrLFx2O0/wMrMb9achyCCSwLFblkUVJtIseleM6534JehOWDCZV qEZciCtRkG0E3tUfSza/S+MFkMq41takQZSxRL+UqVNrY0j1AAnyWkhgcaLM2uBNBkiJ YpvtyoKvODBrQXZCzkot6qtqfLoWL+GXwEZjkGyswXAJozDqJcI41D2dYXU4OGavlnKp sNVS68GL0I5FNf46+LBIe15OAFnr/GzvC5wHehlyamcO9nEahGDchorVUTDCkEM9xcPn wiXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@8bytes.org header.s=default header.b=50ZzaDPq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rm5-20020a17090b3ec500b00213a3a2a09csi18771813pjb.159.2022.12.05.03.00.54; Mon, 05 Dec 2022 03:01:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@8bytes.org header.s=default header.b=50ZzaDPq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230037AbiLEKzu (ORCPT + 82 others); Mon, 5 Dec 2022 05:55:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229954AbiLEKzs (ORCPT ); Mon, 5 Dec 2022 05:55:48 -0500 Received: from mail.8bytes.org (mail.8bytes.org [IPv6:2a01:238:42d9:3f00:e505:6202:4f0c:f051]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8500C1901C for ; Mon, 5 Dec 2022 02:55:47 -0800 (PST) Received: from 8bytes.org (p200300c27724780086ad4f9d2505dd0d.dip0.t-ipconnect.de [IPv6:2003:c2:7724:7800:86ad:4f9d:2505:dd0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.8bytes.org (Postfix) with ESMTPSA id A5EE42202AB; Mon, 5 Dec 2022 11:55:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=8bytes.org; s=default; t=1670237746; bh=UVOyFFaGYlpHJfm3mAMdFZ8zDZRV5tP+GuufCO475L4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=50ZzaDPqm6zSg1911499wI12ZJg8Zfh0ZeU4ptABj61knUN9uman1W/Zj3OEYkx5o DT9ag6YE8z9ZTFTyx8NXeKVyX07AjJ5Y6upV3L3aXZ/D460VDVWyQafxz15zOjjp4S FgdSVQjAe6xWxLCc2OH6AjuG6WHUyTjlxiuvxDq5rQ2/mXrNf4qAAR1Pe5N1Y/pvFQ Yhj/72n4bxUlGQer/1yKN42pLQMYn0kWFsXltRhMpwfVCMAT6640YBKA6YihbyoJeU NGKhXkJLpH1XQucxnBVkOjqWKoVoQneM7GOQ/2JkWO+TE92+yU4RW13aCKBdVkF2a2 Tb0yRdJ7AuqDA== Date: Mon, 5 Dec 2022 11:55:45 +0100 From: Joerg Roedel To: Ricardo Ribalda Cc: Matthias Brugger , Yong Wu , Will Deacon , Robin Murphy , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iommu/mediatek: Fix crash on isr after kexec() Message-ID: References: <20221125-mtk-iommu-v2-0-e168dff7d43e@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221125-mtk-iommu-v2-0-e168dff7d43e@chromium.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 28, 2022 at 11:16:48PM +0100, Ricardo Ribalda wrote: > If the system is rebooted via isr(), the IRQ handler might be triggerd > before the domain is initialized. Resulting on an invalid memory access > error. > > Fix: > [ 0.500930] Unable to handle kernel read from unreadable memory at virtual address 0000000000000070 > [ 0.501166] Call trace: > [ 0.501174] report_iommu_fault+0x28/0xfc > [ 0.501180] mtk_iommu_isr+0x10c/0x1c0 > > Signed-off-by: Ricardo Ribalda Applied with commit-message spelling fix.