Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5759949rwb; Mon, 5 Dec 2022 03:51:57 -0800 (PST) X-Google-Smtp-Source: AA0mqf5gy3GAkMJUMEdXokWtshi/dr3nxVGfMMi94QRATIAdpr+IVUq7R2n2pu8cyU0iK/ekphmr X-Received: by 2002:a17:903:2ce:b0:186:e852:b271 with SMTP id s14-20020a17090302ce00b00186e852b271mr65459425plk.117.1670241116965; Mon, 05 Dec 2022 03:51:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670241116; cv=none; d=google.com; s=arc-20160816; b=DPn/0OWFAo+LMUwWe/ryb79AtGgqinVVEBTY2A/ZNC1CbVukeG6QkqDo6rW58eJACp cTjW6VG7mBqcSg6t4g/l8nE2IjUIhkp9fA2X7SFvHcnpLiocXV/4ldGPsmjdCha9Rilp ByWJZSGzxGZR/Bzkh0palp30fhE5JGrJIaDkC58wNtkM9n/5Pzp9Zip/mqlfgmVxYOm+ Pwm+rwJdIsA7DqO1xq1viNJnp3fOjzoNWVIoPeD9QmS/QBJd/qush0FaJ8NT3J1qklCX fi8atrUCnkk7CS5WYn6it0AEAMj0ro6ihBvVixMXTJPYtsiN4nXS97seSwKcGf4AbwF5 jrIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=8dFgwBsb+ifD3pil3VCawClQZBj9cS0sp8KDUJ4nCDE=; b=QIKXdIcK+/J/Ja6zY8+Jm9IO89AXyq8jA7hFXiUTSbPBy4fEL3PReXbPgjHpS1yhnQ pIh2nkTpX5K2pWUjjQ3WHIL8eB9tUS6TShirdxsh3uP8bXFO2BJGTeeCSkArCRRu/ff8 yic3F029vHBu/EcYia/UpA2FpBwJyU+TzYm0dD1M2AZa6K9kRfpcK+/3aHQZeNfkpXs0 F97SUU+BGCQBGN6y/918+zVHPY5rNQRhRTWgQCWZxb8coL2QlvuyBrn6vfRiEAtRp0BZ 3WGOzOx1ldzT6X7wwFJolQjcF0b8W5wxV//E22l5KI1ZudeEHq2cKsAOkjpdSYCPg3bu S4iA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s11-20020a170902ea0b00b001891fd4ebf0si16198354plg.495.2022.12.05.03.51.44; Mon, 05 Dec 2022 03:51:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231222AbiLELgr (ORCPT + 82 others); Mon, 5 Dec 2022 06:36:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229970AbiLELgp (ORCPT ); Mon, 5 Dec 2022 06:36:45 -0500 Received: from mxct.zte.com.cn (mxct.zte.com.cn [183.62.165.209]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2891A19299 for ; Mon, 5 Dec 2022 03:36:45 -0800 (PST) Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxct.zte.com.cn (FangMail) with ESMTPS id 4NQhMv42LCz4xpy7; Mon, 5 Dec 2022 19:36:43 +0800 (CST) Received: from szxlzmapp03.zte.com.cn ([10.5.231.207]) by mse-fl1.zte.com.cn with SMTP id 2B5BaaYY051373; Mon, 5 Dec 2022 19:36:36 +0800 (+08) (envelope-from yang.yang29@zte.com.cn) Received: from mapi (szxlzmapp02[null]) by mapi (Zmail) with MAPI id mid14; Mon, 5 Dec 2022 19:36:40 +0800 (CST) Date: Mon, 5 Dec 2022 19:36:40 +0800 (CST) X-Zmail-TransId: 2b04638dd7c8ffffffffa569f048 X-Mailer: Zmail v1.0 Message-ID: <202212051936400309332@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , , Subject: =?UTF-8?B?W1BBVENIIGxpbnV4LW5leHRdIGlwbWkvd2F0Y2hkb2c6IHVzZSBzdHJzY3B5KCkgdG8gaW5zdGVhZCBvZiBzdHJuY3B5KCk=?= Content-Type: text/plain; charset="UTF-8" X-MAIL: mse-fl1.zte.com.cn 2B5BaaYY051373 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.251.13.novalocal with ID 638DD7CB.000 by FangMail milter! X-FangMail-Envelope: 1670240203/4NQhMv42LCz4xpy7/638DD7CB.000/10.5.228.132/[10.5.228.132]/mse-fl1.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 638DD7CB.000/4NQhMv42LCz4xpy7 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Xu Panda The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated strings. Signed-off-by: Xu Panda Signed-off-by: Yang Yang --- drivers/char/ipmi/ipmi_watchdog.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c index 47365150e431..0d4a8dcacfd4 100644 --- a/drivers/char/ipmi/ipmi_watchdog.c +++ b/drivers/char/ipmi/ipmi_watchdog.c @@ -213,8 +213,7 @@ static int set_param_str(const char *val, const struct kernel_param *kp) char valcp[16]; char *s; - strncpy(valcp, val, 15); - valcp[15] = '\0'; + strscpy(valcp, val, 16); s = strstrip(valcp); -- 2.15.2