Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221201151336.8044-1-suagrfillet@gmail.com> <Y4jICn5oxLozsv6m@wendy>
 <Y4jtfrJt+/Q5nMOz@spud>
In-Reply-To: <Y4jtfrJt+/Q5nMOz@spud>
From:   Song Shuai <suagrfillet@gmail.com>
Date:   Mon, 5 Dec 2022 12:33:43 +0000
Message-ID: <CAAYs2=gF7FetnJh2UE=1uFS6RChn4eTG5gdasn3KL4Uj2=bMag@mail.gmail.com>
Subject: Re: [PATCH v3] riscv : select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY
To:     Conor Dooley <conor@kernel.org>
Cc:     Conor Dooley <conor.dooley@microchip.com>, guoren@kernel.org,
        paul.walmsley@sifive.com, palmer@dabbelt.com,
        aou@eecs.berkeley.edu, apatel@ventanamicro.com,
        atishp@atishpatra.org, heiko@sntech.de, anshuman.khandual@arm.com,
        liaochang1@huawei.com, juerg.haefliger@canonical.com,
        wangkefeng.wang@huawei.com, linux-riscv@lists.infradead.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Conor Dooley <conor@kernel.org> =E4=BA=8E2022=E5=B9=B412=E6=9C=881=E6=97=A5=
=E5=91=A8=E5=9B=9B 18:08=E5=86=99=E9=81=93=EF=BC=9A
>
> On Thu, Dec 01, 2022 at 03:28:10PM +0000, Conor Dooley wrote:
> > On Thu, Dec 01, 2022 at 11:13:36PM +0800, Song Shuai wrote:
> > > In RISC-V, -fpatchable-function-entry option is used to support
> > > dynamic ftrace in this commit afc76b8b8011 ("riscv: Using
> > > PATCHABLE_FUNCTION_ENTRY instead of MCOUNT"). So recordmcount
> > > don't have to be called to create the __mcount_loc section before
> > > the vmlinux linking.
> > >
> > > Here selects FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY to tell
> > > Makefile not to run recordmcount.
> > >
> > > Link_v1: https://lore.kernel.org/linux-riscv/CAAYs2=3Dj3Eak9vU6xbAw0z=
Puoh00rh8v5C2U3fePkokZFibWs2g@mail.gmail.com/T/#t
> > > Link_v2: https://lore.kernel.org/linux-riscv/CAAYs2=3DiYn8sLQB8oh+RzT=
Kd2VKs8MXOLX6Mwpamx5gdVVN6mkA@mail.gmail.com/T/#m62138d7a76664798d00051818a=
438a601eff4cf1
> >
> > Hey Song Shuai,
> >
> > For future patches, please use normal "Link:" tags. If you're just
> > linking to prior versions of the patch, just put them below the ---
> > line so they don't end up in the git history.
>
> > > Signed-off-by: Song Shuai <suagrfillet@gmail.com>
> > > Tested-by: Guo Ren <guoren@kernel.org>
> > > ---
> > >  arch/riscv/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> > > index 572973103d73..c19cddb8feb9 100644
> > > --- a/arch/riscv/Kconfig
> > > +++ b/arch/riscv/Kconfig
> > > @@ -277,6 +277,7 @@ config ARCH_RV64I
> > >     select 64BIT
> > >     select ARCH_SUPPORTS_INT128 if CC_HAS_INT128
> > >     select HAVE_DYNAMIC_FTRACE if !XIP_KERNEL && MMU && $(cc-option,-=
fpatchable-function-entry=3D8)
> > > +   select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if DYNAMIC_FTRA=
CE
>
> Also, why are these not added in alphabetical order, like the current
> list is? I don't see HAVE_DYNAMIC_FTRACE in linux-next from the other
> day so that probably needs fixing in the series you are based on too.
>
Sorry for bothering you with this disorderly CONFIG  and the 'Link' tags
I'll tidy them up with Guo Ren in the next version.

> > >     select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE
> > >     select HAVE_DYNAMIC_FTRACE_WITH_DIRECT_CALLS
> > >     select HAVE_SAMPLE_FTRACE_DIRECT
> > > --
> > > 2.20.1
> > >


--
Thanks,
Song