Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: ScDLH6KvzKaUUg3ze4pxGRJEl7uiQvAIfCBQZewqEVR1ep1vZWLrb0vhzRNS81bNHknTQmCSWD
 7MMWQZKu2DSkfHCiMPdfI/kNsufORp7xpuTNYuNIaXopSwD+c8W0Omi0Qx0/7Oq6hVpT6KkL+w
 QYuft0qrlL5kL+2NYOTpjX15OAgreL5Ix6K5mofhmi6uYChkpzdykYmnETbZuIN36eZ+wMJtlu
 aODK2VCundbiItZ2NKYlYNb/vj9bSsPurQFxiMIuEzLHwIUB3LeeDWYYrfH6Sea068Y9mECgpt
 Las=
IronPort-SDR: c5+6BPxXicLZW46NxcI1HCpEucip1AwUaaO4qGB2rDiRsnB3Mbtmi4EZoYAq5We7LLMZqO0RIA
 gEdp1tAr4zSLfBrtJ/erE2r1S7xghggsFVvrANqEgM69fmviznHOuqXOch3u7cv8/V7cH0QhP7
 PX7crEvSt1ezFgH6hyHSXTPf4Gh0GVndQ0Rvwbsj59GeJNzK+xUnc0FpMR6NlnqPXUJWTE/6V2
 t/ncyMon5PnCdAqd/GDbjQz6f0C/VcMrjTOM5mnsu9pn5LnZi8CYfs/hRkhana0lClaFa4RSR0
 4c0=
WDCIronportException: Internal
Message-ID: <f440a8ff-7657-c1be-e733-4ad69b6b7b0b@opensource.wdc.com>
Date:   Mon, 5 Dec 2022 22:24:22 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: TI: X15 the connected SSD is not detected on Linux next 20221006
 tag
Content-Language: en-US
To:     Arnd Bergmann <arnd@arndb.de>,
        Serge Semin <fancer.lancer@gmail.com>,
        Anders Roxell <anders.roxell@linaro.org>
Cc:     Niklas Cassel <Niklas.Cassel@wdc.com>,
        Naresh Kamboju <naresh.kamboju@linaro.org>,
        Praneeth Bajjuri <praneeth@ti.com>,
        Serge Semin <Sergey.Semin@baikalelectronics.ru>,
        open list <linux-kernel@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "regressions@lists.linux.dev" <regressions@lists.linux.dev>,
        "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" 
        <linux-ide@vger.kernel.org>,
        "lkft-triage@lists.linaro.org" <lkft-triage@lists.linaro.org>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Carlos Hernandez <ceh@ti.com>,
        Sumit Semwal <sumit.semwal@linaro.org>
References: <ca8d3fff-0365-24d9-fd53-5799ac34f336@opensource.wdc.com>
 <7ee4a1bd-0674-42d8-8980-8b029ca09e71@app.fastmail.com>
 <75eaeab3-7781-d60a-ae61-ae837f5dcec9@opensource.wdc.com>
 <CADYN=9JiX-=PcKMzAcSm=p7Dh6kYT7Kbv-8kcNF0MQ4=1hFS5g@mail.gmail.com>
 <20221014140633.mlypet7skkxvt453@mobilestation>
 <CADYN=9LrKHRNMON3GA4piDvWeSWTASQ1u2=D30rXFdvo1L18bg@mail.gmail.com>
 <20221017155246.zxal2cfehjgaajcu@mobilestation>
 <CA+G9fYtYetV5sZVD14WkZxCE_tgTC4VVKm8BcBw5_NwXD6U=Sw@mail.gmail.com>
 <Y4cqcTRcni5H7UAU@x1-carbon>
 <CADYN=9KKGBXn-YkiiFxsUzsanTALbDV1c+tB0oUQPouE1idnuQ@mail.gmail.com>
 <20221205011105.4do4trbytq4bfw5b@mobilestation>
 <98670e23-6553-4788-8662-9403c480af82@app.fastmail.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <98670e23-6553-4788-8662-9403c480af82@app.fastmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/5/22 19:08, Arnd Bergmann wrote:
> On Mon, Dec 5, 2022, at 02:11, Serge Semin wrote:
>> On Thu, Dec 01, 2022 at 12:48:32PM +0100, Anders Roxell wrote:
> 
>>>
>>>   for (i = 0; i < hpriv->n_clks; i++) {
>>> - if (!strcmp(hpriv->clks[i].id, con_id))
>>> + if (hpriv->clks && hpriv->clks[i].id &&
>>> +    !strcmp(hpriv->clks[i].id, con_id))
>>>   return hpriv->clks[i].clk;
>>>   }
>>
>> Indeed I should have taken into account that devm_clk_bulk_get_all()
>> can get unnamed clocks too. But checking the hpriv->clks pointer for
>> being not null is redundant, since the ahci_platform_get_resources()
>> procedure makes sure that the array is always allocated. At the very
>> least you shouldn't check the pointer in the loop, but can make sure
>> that the clks array is available before it.
> 
> Do you think this is otherwise the correct fix then? Any chance we
> can still get a version of it into 6.1?

If someone sends me a proper patch to apply, I can send a last PR for 6.1
to Linus before week end.


> 
>      Arnd

-- 
Damien Le Moal
Western Digital Research