Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Dec 2022 14:36:51 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Divya Koppera <Divya.Koppera@microchip.com>
Cc:     hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        richardcochran@gmail.com, UNGLinuxDriver@microchip.com,
        Madhuri.Sripada@microchip.com
Subject: Re: [PATCH v4 net-next 1/2] net: phy: micrel: Fixed error related to
 uninitialized symbol ret
Message-ID: <Y43z8+grm/TM3ype@lunn.ch>
References: <20221205103550.24944-1-Divya.Koppera@microchip.com>
 <20221205103550.24944-2-Divya.Koppera@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221205103550.24944-2-Divya.Koppera@microchip.com>
Precedence: bulk

On Mon, Dec 05, 2022 at 04:05:49PM +0530, Divya Koppera wrote:
> Initialized return variable
> 
> Fixes Old smatch warnings:
> drivers/net/phy/micrel.c:1750 ksz886x_cable_test_get_status() error:
> uninitialized symbol 'ret'.

I guess this patch has been rebased without the smatch warning being
changed because line 1750 in net-next/main is a blank line between two
functions.

> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: 21b688dabecb ("net: phy: micrel: Cable Diag feature for lan8814 phy")
> Signed-off-by: Divya Koppera <Divya.Koppera@microchip.com>

So once i looked in the correct place:

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew