Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Dec 2022 09:55:10 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     liulongfang <liulongfang@huawei.com>
Cc:     alex.williamson@redhat.com, shameerali.kolothum.thodi@huawei.com,
        john.garry@huawei.com, cohuck@redhat.com,
        linux-kernel@vger.kernel.org, linuxarm@openeuler.org
Subject: Re: [PATCH v4 1/5] vfio/migration: Add debugfs to live migration
 driver
Message-ID: <Y434Pivb5PwzP0TI@nvidia.com>
References: <20221202092625.35075-1-liulongfang@huawei.com>
 <20221202092625.35075-2-liulongfang@huawei.com>
 <Y4oW/ToMZEUnlYZ1@nvidia.com>
 <f17dfd5d-3d65-d51e-426a-e60f7e99a3d6@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f17dfd5d-3d65-d51e-426a-e60f7e99a3d6@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?A6RO0OL0aVK4z3oGaPSkQA7pZOsbD4Iv4yImMshJ9bSCwrVJcBoEXeiRL5ar?=
 =?us-ascii?Q?99b42JHpNvIXvgZ97LzCyb6IIXEY3kJ31+BujYP5LcZemJCOipwP71Xid1Oc?=
 =?us-ascii?Q?uCYw2HN8gBuotkt+usI4qtWMuPDiJQWSOYFjwa8WUxj2W4Df5c9h18uhN945?=
 =?us-ascii?Q?kV2pvmB9TieenD4u46H2ZjlR0PK9yltubwvs3kb8BUpTdBY+oldhCi0/OXo5?=
 =?us-ascii?Q?HhRBkE+pztpSvWNHJpq9YQoU9R0AjxT9AkINnmbwW5O8acrOfK/53O3hxCgG?=
 =?us-ascii?Q?6gxRqJgVHGC2kpNtdiQy/ABBS5lX8CF6x3cLZ8Z1MPKI7TZcnwWlGOveQPV9?=
 =?us-ascii?Q?JKDlh4OOwSIQ6SAIerBbKckExMbx6vpD7P/Wa4hJlYf0OgO3lWun8BONC4+P?=
 =?us-ascii?Q?tJ1TiLcaQzJKtKK8g+lgKBxWucfBXvuRRPkmvjUNiaDBmBX4P7xaLdglheX5?=
 =?us-ascii?Q?gHtIbj4Bxx9ASP/aXMp5/KMPk81DjEaaCLHZ0KOzlcqnEEgcmzNStyYTG6zM?=
 =?us-ascii?Q?DFG1t0wczhD3akob63UF9JpcriPeLeTefFpcp7iubH/O3/JBtnJUdmSHPJPi?=
 =?us-ascii?Q?9eWQWwuoRNA8l8+wiuAcfQ3cjfwLYwicRynJpKI7yEPhBU2q0UNu6+8BJ6B8?=
 =?us-ascii?Q?0CTAxQLa8nSKgL0DwEUXAP4H/vGoINaeBRUSjJ/hn4oIFUvaHMpIK+vN23kz?=
 =?us-ascii?Q?L+ovHDA1VN7Mub9G7n1L1m24Cwz1fW2oHot4uWvChnb+ZtGyR+fwG0KKC17c?=
 =?us-ascii?Q?2xcNQYyH/LL/0T7mdUH4NvJk2EytWyAZ5BP72zwTqXQkmlC+s9+aFlRiPZV2?=
 =?us-ascii?Q?CzPGTXNBWzoeLxQ4BPEHvP+2WhK5XyLnWiD4dvTJXlc0XNLm+Sci+GHnqnlA?=
 =?us-ascii?Q?PqIAedeTIQEmewOES47OEJ/jUR5w7D4db3yh2yQwD0JoLAI4m9pXkgpnGWS0?=
 =?us-ascii?Q?k0SZa97hKCQAiteMFdAbOQjLpX4rVqHvxI0gUd3/ByUTTyy9Sa3kGO22agGN?=
 =?us-ascii?Q?72h1MGMhj+BAV2XjURUzUhVbvXF2EucGGgUPX0jXyocIQMvFq9jlMPwA3KNQ?=
 =?us-ascii?Q?fwesYVRxHjGS9CLxhZaHBBOZd8+Kd6IG26E9GcSy3TyQIcfyo42SVvO0dxrq?=
 =?us-ascii?Q?8WRO0Z+7LERhxb+8JvC1aZ22Cy/U3t+1d+xUu9yr5osoqKoQtNqV5mDDLLNj?=
 =?us-ascii?Q?W6koZcTG37D1oJA0lBLmmXQHzCj1o57c0YcuBHeUbRZe/1fTt8VFhpy0csr6?=
 =?us-ascii?Q?DmLu2Xonx1n21ANo+8/w7mGoxhtHTTTB/ScAjTJbVcoxDNwo8YsarnmhRv4b?=
 =?us-ascii?Q?pMZlvzdlRcHmqToS/njDM6kD5qMtQaN0Tv7Sc1ftIN2yYkv9p6nG5D1F5W3M?=
 =?us-ascii?Q?mjz3hJ7MYPHxgFplnwvf53eVCyMWfYPrYFd2HJ0BC8bgeLqQ2k7MTrUWfOo6?=
 =?us-ascii?Q?+8/7b2GpWeczERs2b2NCj+wt/heIg29c3r8mvxeZiImj9W26I4yr95nJVfQp?=
 =?us-ascii?Q?UETGRSS3Bz7bG+s2+5CVQaKlrtG/hg3ubD5h1Qpael26uUa3N+cV/dywY/yp?=
 =?us-ascii?Q?IcN31bk7eKy3ZB/C29NbAxrhZWwLBUR6ZC+t7aIp?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b780dfe-dd33-4d91-a7b9-08dad6c8541a
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2022 13:55:11.9964
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PV1G1/REvjCWKTSrcDK73zPtL8tq20cQSFosCmbIpgZp+aZG1kFFf9HwcSu5TPkf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7443
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 05, 2022 at 09:39:29PM +0800, liulongfang wrote:
> On 2022/12/2 23:17, Jason Gunthorpe wrote:
> > On Fri, Dec 02, 2022 at 05:26:21PM +0800, Longfang Liu wrote:
> > 
> >> +static ssize_t vfio_pci_vf_state_read(struct file *filp, char __user *buffer,
> >> +			   size_t count, loff_t *pos)
> >> +{
> > 
> > This would be better to use debugfs_create_devm_seqfile()
> > 
> > Then you can simply use seq_printf()
> >
> 
> The previous debugfs used this method in my patch.
> Is it now recommended to use the interface with "devm" ?

It doesn't matter, the point is not the devm, it is to use the right
helper for the data you want to expose over debugfs 
 
> >> @@ -119,6 +129,8 @@ struct vfio_migration_ops {
> >>  				   enum vfio_device_mig_state *curr_state);
> >>  	int (*migration_get_data_size)(struct vfio_device *device,
> >>  				       unsigned long *stop_copy_length);
> >> +	int (*migration_get_data)(struct vfio_device *device, char *buffer);
> >> +	int (*migration_get_attr)(struct vfio_device *device, char
> >>  				   *buffer);
> > 
> > Still no to passing through debugfs ops, create these files in the
> > driver.
> > 
> 
> If this part is also created and enabled in the device driver, why do we need
> to put this debugfs in the vfio public framework?

To create the directory, and the few actually common files

Jason