Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5996649rwb; Mon, 5 Dec 2022 06:47:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf6uN0UGUSbRTjJZfyTNVLDpOP1XGhyJI2yDeCenDVF6Zybum1JmUZhNsSfPbaojdz3ULLzJ X-Received: by 2002:a17:902:d102:b0:189:c3ef:c752 with SMTP id w2-20020a170902d10200b00189c3efc752mr13008395plw.118.1670251656439; Mon, 05 Dec 2022 06:47:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670251656; cv=none; d=google.com; s=arc-20160816; b=qO9s3jdA1qNzyq97WccOAkjXoBr+K2WPusjfzZZJ6IGOQ0Xr1CTugDJNB9OTJoPzTd /naPDEDCx1pIa93cKKJ87XDS+QQhT+8DFATD248e4FoWHfFwYHn5noC+7OJjMJGUe7UE Z6bC9ePeWKtIRm/tldtMHn+h2dAIAOlKzFb8gxrdHYSAdnZBMxdgwBu4dchU7C+Sbvxv 10GiR/1WdWTOjn/KVViyd1xbnTC+1/nYtEOq5ZGmE1WxvZXNny60DgiOF7E/h560i2vg tEKvKBXFZIZ/B+YXyytzriUgyd0OaaHmD7I7otS5PSTzrPj61d400hka+6/5Uy7Oez8N yyNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=bc4/MjN/YjTPQ9EZGEra+4fgjSY8zygUtk0AgsersU0=; b=mB90758N0s+/8/llcSRWyzgdwDR4UxEyHFbRga6HlZ983X1ytUpRElmgz3FDBqJJBW Y4wmYxghPCwUiJp4mfmnxBuY3oWLk+Z2LoVvljBQApGuCk+gjCY8mbd+zIa/j9T5wRrd nO7h0EvqEkDAF5jxYsW4Q+iZtJMhJ+VL6GBZU1fl/m2uqtOGWLv+KhObMkdbcjsHQ3v/ CjTmJtvJ/AFs19xR1iIwHebAn1ePYxEf1JabQUNzQ0f+5VHtqBZFZ9py0STQH0svY6ED kXtWP+Fpt/rhc3khzuckfqZ9908qDa35YMODnSo8eE3lKwVoZKypK+aVILQHIfGfTvyG xY1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=XuY48gAR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i125-20020a625483000000b00565d37ee1casi13761032pfb.166.2022.12.05.06.47.24; Mon, 05 Dec 2022 06:47:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=XuY48gAR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231805AbiLENyH (ORCPT + 81 others); Mon, 5 Dec 2022 08:54:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231205AbiLENyF (ORCPT ); Mon, 5 Dec 2022 08:54:05 -0500 Received: from mail-yw1-x1130.google.com (mail-yw1-x1130.google.com [IPv6:2607:f8b0:4864:20::1130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36127257; Mon, 5 Dec 2022 05:54:05 -0800 (PST) Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-3cbdd6c00adso118244167b3.11; Mon, 05 Dec 2022 05:54:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bc4/MjN/YjTPQ9EZGEra+4fgjSY8zygUtk0AgsersU0=; b=XuY48gARX1ENE547OqGANQPwOeRc2gRM3s9AirKaB5f7QPn2LgH6QY+/p5iN7FiaDR 3CGX4FGzaQtIrLyvdndr7xdF/D9mtI9guwQWgJ7AS9Z0fnEYwZi4oCG9mtxDGGH40+vT R8ez7KsxFQtLHrKvTvhJZpskWdlNPMQFy0T5umLohosgOqmBqcHW7gkoRQBnv48EFiks OjzPsJWCMH/PoOktEwc9W5U4Ez6iElLwZTDVmFv8FV7MwlnXHv+h/Dze/3utINPe4Hoo 6F7BeH/uSy/1K7myyxp7xfBcKLLyBOWpPBrMr7Gv3VgPkHR+Kg9eJImc6UHoB6fjru2U xCLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bc4/MjN/YjTPQ9EZGEra+4fgjSY8zygUtk0AgsersU0=; b=usuFAR3bafzc05B7OGEGFU/PNjWIyPfFBHO/y4/gvMPudJwBh0wsEobIMu7Es4uDOK z7fLbxcj3z0hK8xbzTQFdpDjiOsvqGKgMwdS1GCEJZHmD0uEnHK0Q4mlDJuBqL7FHQE+ rg9oo4XvTbUW8PZcay3cvZhBo6sm2eTaRiM27CNNlQBzxQruVCUAvMGPRVDc0wWbcovJ HRXD/79LtaHHslaEmWrKKYPnV2fFzf+vbPVJ/lA7lJULA97d9fl5IJlWVm3nJ0NBUzO7 LzUuFdtTbLNnvH7015qBr33WiDJ82fkVjKolEt5MpFe8QiOcVrKRrND2q4YyVWOldEoI OSWw== X-Gm-Message-State: ANoB5pkBvX6yOkdWXFUHE3NVANUl3B0YG3VEeNXwI77cfyB9mJ6nXs6l eQhB8mtfm1ueAhswJl4Na8h9op/HsfTHRg2cg2yTOOhnlqk= X-Received: by 2002:a05:690c:c9a:b0:3ed:90d2:2ab8 with SMTP id cm26-20020a05690c0c9a00b003ed90d22ab8mr3864513ywb.67.1670248444418; Mon, 05 Dec 2022 05:54:04 -0800 (PST) MIME-Version: 1.0 References: <20221202161502.385525-1-ojeda@kernel.org> <20221202161502.385525-28-ojeda@kernel.org> <20221204103153.117675b1@GaryWorkstation> In-Reply-To: From: Miguel Ojeda Date: Mon, 5 Dec 2022 14:53:53 +0100 Message-ID: Subject: Re: [PATCH v2 27/28] rust: types: add `Either` type To: Wedson Almeida Filho Cc: Gary Guo , Josh Triplett , ojeda@kernel.org, Alex Gaynor , Boqun Feng , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Wei Liu Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 4, 2022 at 6:36 PM Wedson Almeida Filho wrote: > > It's also implemented in `std`, which the kernel doesn't include. > (Which is actually good for us, since we can't really use it.) We have it around in the kernel (the `std` one is a re-export), so one "could" replace the `Either` with `Cow` in the case of the commit message via ignoring the to-owned side of it (but I assume Josh didn't mean to suggest that). Anyway, it can be easily configured out from our `alloc`, so I will send the patch. Cheers, Miguel