Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <14b50035-c080-2471-7bc3-967fe73357d0@seco.com>
Date:   Mon, 5 Dec 2022 10:13:50 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH] rtc: abx80x: Add nvmem support
Content-Language: en-US
To:     kernel test robot <lkp@intel.com>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        linux-rtc@vger.kernel.org
Cc:     llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <20221201230208.713118-1-sean.anderson@seco.com>
 <202212031600.ua4R64Lx-lkp@intel.com>
From:   Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <202212031600.ua4R64Lx-lkp@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NXIyRVQvN0dKSlBJWnhXU3E4Q1NUbGwwblNXaS94V1NwZUJEV0dCSWMwazA5?=
 =?utf-8?B?S2Z6c0JIQ0tGTEIvNDd1dDhYSE9oM0hhK1ByZGtRYzArVktlUGl6aVAzNUFa?=
 =?utf-8?B?SHRIbTl3d0xBOS80TkpVN3VmLzFLa3B2WEhLckI5UWprWUVrZzJiWklGTlU5?=
 =?utf-8?B?REloQk5Md243WUw0VmtZdzluMmZ2UHNRTjZUUEdVc0VqNkJiYWtkS3cwa2la?=
 =?utf-8?B?d1E2a1Y2Y242TERzdjdsOVh5NXRlc0FzbUxwWENaOFJTUjNoMWxlTm94SVFh?=
 =?utf-8?B?a3JWaE1pR2NVVEdwYUxPbEtiVkZ4c1ZIV0Y4d3Zlb2hmdmd6eTBqWnhYKy8v?=
 =?utf-8?B?bDlGL3RxMmVSTjkvdzlXUzFUbmZkb094Q3NqbDE5emVEUFpkMGxQbUtaQW1k?=
 =?utf-8?B?Zkh5SnJrbGRqb2xEK2ljZ1FwVGg0dVk4RTJmUkNmS1dyTW5rNkxGWVNlUXFR?=
 =?utf-8?B?OVNGT1VMdkRLRXMrSE5xUTdlRWRxT3V2VUNnQS9tSm4yWis3UnpPaDcxVDF1?=
 =?utf-8?B?YVF6dkJramREbCtoM1Z2NkVqeUpIbHh5N0dQVllGQlZtV1pMdnY1ayszcFRh?=
 =?utf-8?B?aHBxWTRJWGY4UTZRS1NSOGIyUkJxUEZyMDZIbHB5QWgyYm52cXZGSGNPK0tF?=
 =?utf-8?B?WGRBRTY3RnRHY3o5YjhVcFh4eVM1WXhCUDNOaXUvbHdGM255cGRyQmozWTdT?=
 =?utf-8?B?VE15dVhmWGh3U01Hei9CUzVMdlIxU0RhcFBlTllOVFZ1WlIzcEV2aUZ5UDVa?=
 =?utf-8?B?NllxNmdCTnhpR3dFMjI0ZFFJUVZiQ1RJVnZmd0hFZzdxUHNCY3dXdEFqOXI1?=
 =?utf-8?B?aXNldkdTMElhc0YzbFRVSmNrM2lrUjlvbndibGdLL1liQVVia1lyaHNlRlh2?=
 =?utf-8?B?R2VDaGRCS3hlNnZFZHd0OThFb2o0ZlFEdGNvSUhGQnlqbjk4bkhmbElEZXF3?=
 =?utf-8?B?RlF6OUhEYnFLKzVnaUJtb05qdXZrVVRWaGV1T1pPdUZOeTlqU2dKOHJ0U0Zq?=
 =?utf-8?B?di9nREkrTXFYTERNb2N4NzZyNjNKZ2hmUy9yWEp2YVRkcTVqRnFqWTJnaEY5?=
 =?utf-8?B?SmRkM29reUtpTVo0bHhlaVFROHBKYi81L0swNTZwb2JpbUdia0NoN3g4VXJn?=
 =?utf-8?B?Mi9HTENGWHVBTkQ4aHBPVTREVVFQTzhMZWNhZG9ETmFGR0YybFQ1WTU3dFpk?=
 =?utf-8?B?WkV4SFg2WjJPLzdldHFOZ2tjaUFld0VlQ0s5a2NIcEl3ZHIwZklRUFY0bThj?=
 =?utf-8?B?dUdnV25ManhmSGNvekM3VDVHUE12cktLckMxNkUvWkJ2cEtHNzROQmlKVkNP?=
 =?utf-8?B?NG9XZEM2TlVlNmJTR3dzb2pVQkU1UVBpRjUyNDlrOGZkL2VGeVRMSEIvekJF?=
 =?utf-8?B?UGloNnoyRGJ0M1hiSzM4WmZSSDIwUzZxdlpNQlNrazhhTUF0cUNPM01qVThV?=
 =?utf-8?B?SU01WkFQc2FXUWsvb1R4b2FYWEgySXlFTnY2eDlRTVBCZUtOYS8ySGthQWdP?=
 =?utf-8?B?WDhIbDZZd24rZkV6MWlVS1FKRDZyanBWbXJGVFA5a3gxa25Lais4S0ZLemlj?=
 =?utf-8?B?Y1pteHVtMXVrZDh1QktHd2RGMDN3SFgrUkVmN0dhMTdrVjVqYnc2ZjErMENL?=
 =?utf-8?B?T3Q4ZmhlcTRpZktwTno0TzZabjFCVmdpenc1QXJSVnRkNHhtTUszM1RPaElZ?=
 =?utf-8?B?d3JhK21Fb2c1cGp3TTRGVnZ3ZmVMRjZxelZ5d3N6MjJIYnFvdzZocklEL2Rw?=
 =?utf-8?B?M2lqRXVVc2E0bElpSTZUTTNUN1hsM0JRVmpSMlNBcHZmUXlRc0kyR2J1NW5Y?=
 =?utf-8?B?eCt2czd4WDRiVzFuMjZ1bXhyZ0tyWWluRXViZGdNM2lWcHcrTkc3U01Na25m?=
 =?utf-8?B?anRvcjFINGJtTkwxWFRMK21CMk9IMFVHSVltQmp1RDFjRjJKVUNGVEYxQkpn?=
 =?utf-8?B?VzRKc09QT0hQUkdtTHlCaElBZE5lUVF4V2ZjSUo5QTRhbGJkOUd2dmRPYVlP?=
 =?utf-8?B?V0RZSEVjVjlzcVJHdU1VZGZQRnRFbVZic2lLUzF3VGM2QlF3V1QxOHVRbWFu?=
 =?utf-8?B?UC9VNnVBbnpud2xVckozVjcwempGSjNvS1VuQ1RoZUxQdjI0WWVVcW5DeGo3?=
 =?utf-8?B?YVZSdzhIRW54R0ZsQzlVYXZ0S2F5cWNBVmFtNVFRdm15YXNrVVl5T1IxZlIy?=
 =?utf-8?B?NFE9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fade3307-4908-460e-924f-08dad6d35360
X-MS-Exchange-CrossTenant-AuthSource: DB9PR03MB8847.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2022 15:13:57.2523
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 88LsSEAKpCUtpumIhZ1BtEKyhP2W0UV6ARzHYTLYMnvh+vOIDi0PH+nJugQobJq1zS+VI0+AX/ipwfIXPCjLeQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR03MB9032
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/3/22 03:45, kernel test robot wrote:
> Hi Sean,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on v6.1-rc7]
> [also build test ERROR on linus/master]
> [cannot apply to abelloni/rtc-next next-20221202]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Sean-Anderson/rtc-abx80x-Add-nvmem-support/20221202-070301
> patch link:    https://lore.kernel.org/r/20221201230208.713118-1-sean.anderson%40seco.com
> patch subject: [PATCH] rtc: abx80x: Add nvmem support
> config: x86_64-randconfig-a014
> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/intel-lab-lkp/linux/commit/6dbbdf7eef71cb4255c6751bc9762cf02a0f53b6
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Sean-Anderson/rtc-abx80x-Add-nvmem-support/20221202-070301
>         git checkout 6dbbdf7eef71cb4255c6751bc9762cf02a0f53b6
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>>> drivers/rtc/rtc-abx80x.c:695:11: error: implicit declaration of function 'FIELD_GET' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>                    lower = FIELD_GET(NVMEM_ADDR_LOWER, offset);
>                            ^
>>> drivers/rtc/rtc-abx80x.c:697:12: error: implicit declaration of function 'FIELD_PREP' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>                    extram = FIELD_PREP(ABX8XX_EXTRAM_XADS, upper);
>                             ^
>    drivers/rtc/rtc-abx80x.c:697:12: note: did you mean 'FIELD_GET'?
>    drivers/rtc/rtc-abx80x.c:695:11: note: 'FIELD_GET' declared here
>                    lower = FIELD_GET(NVMEM_ADDR_LOWER, offset);
>                            ^
>    2 errors generated.
> 
> 
> vim +/FIELD_GET +695 drivers/rtc/rtc-abx80x.c
> 
>    685	
>    686	#ifdef CONFIG_NVMEM
>    687	static int abx80x_nvmem_xfer(struct abx80x_priv *priv, unsigned int offset,
>    688				     void *val, size_t bytes, bool write)
>    689	{
>    690		int ret;
>    691	
>    692		while (bytes) {
>    693			u8 extram, reg, len, lower, upper;
>    694	
>  > 695			lower = FIELD_GET(NVMEM_ADDR_LOWER, offset);
>    696			upper = FIELD_GET(NVMEM_ADDR_UPPER, offset);
>  > 697			extram = FIELD_PREP(ABX8XX_EXTRAM_XADS, upper);
>    698			reg = ABX8XX_SRAM_BASE + lower;
>    699			len = min(lower + bytes, (size_t)ABX8XX_SRAM_WIN_SIZE) - lower;
>    700			len = min_t(u8, len, I2C_SMBUS_BLOCK_MAX);
>    701	
>    702			ret = i2c_smbus_write_byte_data(priv->client, ABX8XX_REG_EXTRAM,
>    703							extram);
>    704			if (ret)
>    705				return ret;
>    706	
>    707			if (write)
>    708				ret = i2c_smbus_write_i2c_block_data(priv->client, reg,
>    709								     len, val);
>    710			else
>    711				ret = i2c_smbus_read_i2c_block_data(priv->client, reg,
>    712								    len, val);
>    713			if (ret)
>    714				return ret;
>    715	
>    716			offset += len;
>    717			val += len;
>    718			bytes -= len;
>    719		}
>    720	
>    721		return 0;
>    722	}
>    723	
> 

Ah, the ARM64 bitfield inclusion strikes again...

--Sean