Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221114012036.2870067-1-git@johnthomson.fastmail.com.au> <CAMhs-H-uKrn-OXX2POPr3ewXUx=h835yBSUcJWun7pC3dPj66w@mail.gmail.com>
In-Reply-To: <CAMhs-H-uKrn-OXX2POPr3ewXUx=h835yBSUcJWun7pC3dPj66w@mail.gmail.com>
From:   Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date:   Mon, 5 Dec 2022 16:12:26 +0100
Message-ID: <CAMhs-H8uCgCgPvesXXg+p-t_CnfChYGNk2oZC2yfs8+s06Nbsg@mail.gmail.com>
Subject: Re: [PATCH v2 1/1] PCI: mt7621: add sentinel to quirks table
To:     John Thomson <git@johnthomson.fastmail.com.au>
Cc:     Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Rob Herring <robh@kernel.org>,
        =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Nov 14, 2022 at 7:05 AM Sergio Paracuellos
<sergio.paracuellos@gmail.com> wrote:
>
> Hi John,
>
> On Mon, Nov 14, 2022 at 2:20 AM John Thomson
> <git@johnthomson.fastmail.com.au> wrote:
> >
> > With mt7621 soc_dev_attr fixed to register the soc as a device,
> > kernel will experience an oops in soc_device_match_attr
> >
> > This quirk test was introduced in the staging driver in
> > commit b483b4e4d3f6 ("staging: mt7621-pci: add quirks for 'E2' revision
> > using 'soc_device_attribute'"), and the staging driver was moved in
> > commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host
> > controller driver") for the 5.16 kernel
> >
> > Link: https://lore.kernel.org/lkml/26ebbed1-0fe9-4af9-8466-65f841d0b382@app.fastmail.com
> > Fixes: b483b4e4d3f6 ("staging: mt7621-pci: add quirks for 'E2' revision using 'soc_device_attribute'")
> > Signed-off-by: John Thomson <git@johnthomson.fastmail.com.au>
> > ---
> > v1 Link: https://lore.kernel.org/lkml/20221104205242.3440388-3-git@johnthomson.fastmail.com.au/#t
> > v2: no newline in middle of Fixes tag
> > ---
> >  drivers/pci/controller/pcie-mt7621.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
>
> I am pretty sure I already gave my Acked-by in the previous version of
> this patch. You should add tags when you submit new versiones. Anyway:
>
> Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
>
> Thanks,
>     Sergio Paracuellos

Gentle ping for this patch :)

Thanks,
    Sergio Paracuellos