Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Dec 2022 08:42:10 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     X86-kernel <x86@kernel.org>,
        LKML Mailing List <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        "Tony Luck" <tony.luck@intel.com>, <alison.schofield@intel.com>,
        <reinette.chatre@intel.com>, Ashok Raj <ashok.raj@intel.com>
Subject: Re: [Patch V1 2/7] x86/microcode/intel: Remove retries on early
 microcode load
Message-ID: <Y44fYl4oV5HmtjJM@a4bf019067fa.jf.intel.com>
References: <20221129210832.107850-1-ashok.raj@intel.com>
 <20221129210832.107850-3-ashok.raj@intel.com>
 <Y43hstW6oL4naReu@zn.tnic>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y43hstW6oL4naReu@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pnD9AtlAur0omelJQ6vA3zLcbfNi4piuUceZCZuLg791TCddM+6DcKAfmrPn?=
 =?us-ascii?Q?kncnr6rPVwqYI5A3P/eB0iFrzKpc3ZXO65Iefv4Oo/s/TgC3VYWu5IOuD/kk?=
 =?us-ascii?Q?o/ezsEJu3/Dh1vLg8a7+3sWZ7TPL4gXW7MpWufKXimkvBkGYzj+8Y1TZWbbI?=
 =?us-ascii?Q?WkuMapMwAPbYfyNzcVUv9Ou1d8SXUVeR2xfOHu9jwCazf6CFf59ZbGHZMCiz?=
 =?us-ascii?Q?KwRq/FMmYpb1KbyR6tKsGYVEPYCP73u/Cct+PDo8MzDwmGw5SxbzwXMlGUs9?=
 =?us-ascii?Q?7j7IQF93M/PcocnjU0eg99hflsMi63FTG9pqxv9ueiZ4jFl7omye5vzEOZEP?=
 =?us-ascii?Q?q0Fvq6VgERwGmjLfHOj2MKfzHm2i7PtkGpfGehIcTH+6cEf91TJsUjJn61of?=
 =?us-ascii?Q?11U+B9tOrbG4zqs90RNMmwecOqvJqWi+Glx5Yj3Y65hzDj3C4OHQqSztrgin?=
 =?us-ascii?Q?vGSypTVlcuT51Lxe0qBKF1XNvNZbK2nvuH+sYfgNUF53sFFWTpxlAkSpZw4j?=
 =?us-ascii?Q?2PQJMNgAKQQJS+B8/dXID5WZi9z/onjygFvgZgTAcSzpyvSRNC4/MsR6sqPZ?=
 =?us-ascii?Q?K2/r8c2WImZZmCdkuwPUqjrhZMw22KOb2jSeN7D6pA6hx+BG0cdHnvS6QXFU?=
 =?us-ascii?Q?L+HaTDBb/VOoJNUMeSaGzXwqn4azuXJjYEu0/ez7lWxIaIswERuSQWw7dovU?=
 =?us-ascii?Q?oxOEhhw/nHSPlPN5f+IBX9jfq/WKoKgArH4UDd7wtWd/thIit+FAaYVdh2Mr?=
 =?us-ascii?Q?mpr0xYE+kaQ4I9eg90fj3myTmJbL13qR1WA5AvDCtjwaOGxChBcY458wgZgi?=
 =?us-ascii?Q?kFl9l3qG+um+MLdXW7ilS7j/tm/sTYbIrU+gT6DK6h8e3p8FmGO5F33qQZA+?=
 =?us-ascii?Q?yo+a6RaU4EYXHTENdEnzpF7kj1UjOjZvDURGuAs8hZ9ISEIGO3OZrTGxSJe3?=
 =?us-ascii?Q?uyRYW98bF7M/SmcK1JO0Zgq0YbVFvT4cKbXo7pkqPw5ozhe7GecDDU3c0sJk?=
 =?us-ascii?Q?iyhuWAMAjwxzutaUW06Q2PKla4ZN39dt8jOemXxFXSki/2WCp3eO9QvXuZbE?=
 =?us-ascii?Q?pvdPEmuEGPfLlUEfabQF+mFqI5kht1UIwSNLJLmff7yOZ63wZESLFAr9r1Hl?=
 =?us-ascii?Q?aOmQcx+LfErDWF0XVfiGocvcDTsQJggy/GXQQuGiogdk3c+rXdpyszvnpeYa?=
 =?us-ascii?Q?olbFItRShVI6BI+ucsLBjZNB5AyAyEXZVAHlIaw549hrg57mTZGLtUnT4A4x?=
 =?us-ascii?Q?9kiEhVlVAcGf6sMmRMh0lxvjz61e99xiM7CfKqWAKNUHDcCrF+vqIq9AT6Bj?=
 =?us-ascii?Q?J1HxMvGnhFskP9tbefGsbYXI2q1Ixp413izjUWu0lme7z7h3VpYlyb6T/0kf?=
 =?us-ascii?Q?BKQ+mi9vX3t/hlrkNiITFzwvGoQATo0vndVYBvpOZL7eqmhoC5HEq0UoR0RZ?=
 =?us-ascii?Q?d3vODkbkXfjBfA1OjsoCzgmy+b7PRrVpvhf6einqB+7aag5qvDO0rQRpqh6U?=
 =?us-ascii?Q?79MJU8KYHfTdJp9NpCOpzpBMgRpWUVUO386m82+vdChpiJJZxwVQK7kSkA2D?=
 =?us-ascii?Q?rSli8MwsJ36B5vdE0GqyumIzRqZox9RMn572M2VI?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4de1ddb7-d593-4af8-d4b3-08dad6dfaa45
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2022 16:42:16.7929
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zD5ygQmBvPScIPA5iS3KvoHRYZTo2J8p0BxnOwHrEoVLNmoEK6OPYebJAT9VSDXN2Ib+uA4g9l0EPGmLLtAyNg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5669
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 05, 2022 at 01:18:58PM +0100, Borislav Petkov wrote:
> On Tue, Nov 29, 2022 at 01:08:27PM -0800, Ashok Raj wrote:
> > There is no direct evidence that these end user issues were caused by this
> > retry loop. However, the early boot hangs along with reverting the
> > microcode update workaround provide strong circumstantial evidence to
> > support the theory that they are linked.
> 
> A "circumstantial" reason for why something "might" be broken has no
> place in a commit message.
> 
> If you still wanna chase this and *actually* give me a sane,
> comprehensible reason of why this could cause an endless loop with
> officially released microcode, then I'm willing to listen.

Your changes look fine, thanks for fixing it up.

> 
> Otherwise, I'll apply this:
> 

Cheers,
Ashok