Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Dec 2022 09:05:54 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     X86-kernel <x86@kernel.org>,
        LKML Mailing List <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        "Tony Luck" <tony.luck@intel.com>, <alison.schofield@intel.com>,
        <reinette.chatre@intel.com>, Ashok Raj <ashok.raj@intel.com>
Subject: Re: [Patch V1 3/7] x86/microcode/core: Move microcode_check() to
 cpu/microcode/core.c
Message-ID: <Y44k8gXIG+usGkL1@a4bf019067fa.jf.intel.com>
References: <20221129210832.107850-1-ashok.raj@intel.com>
 <20221129210832.107850-4-ashok.raj@intel.com>
 <Y44bbZMMf8I6Lzl/@zn.tnic>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y44bbZMMf8I6Lzl/@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?drvMygCjnRznxY22rYXvaO9MjetmVYHIrsd7mSPbuG5/JRsm5Rg4wZL0wP0D?=
 =?us-ascii?Q?ICks6udPjLSBmAjRqDV43oVJ09ZZMniJgK0Rt2IFS5V4TwKJxMb0vQFs8rFH?=
 =?us-ascii?Q?YKx7FdS3YVdduoJeUNuPvTngCyHv4XNyuwH7o6bRGW268MWs4E2PuRzF2LP0?=
 =?us-ascii?Q?mpnERJTm6FRpmj04YXcEX8H120wRROoAZydw7xycXuyHoKbZtdXEAac2pFoP?=
 =?us-ascii?Q?FmY0fwFOZkbull01/xH0ootIDRHllVyJeHKil4qaf7Yg0wHIPiM4PbpPAEbG?=
 =?us-ascii?Q?dNxbUUl7/aOm+t7ULeAJExWYLGhI8QeBDlP4pxVTKZ9XeVOJum4IOGskFtu8?=
 =?us-ascii?Q?D6yB19OJNuc4rcsxT6swQ+RhbZqrxWhdKKP6h748gs78XhzNUyValohAqLGI?=
 =?us-ascii?Q?/FNvAH/sDvCaHnswm75ybY8uGD30nEALI677mFa/a5jKsPfqEmjMdujv5I4+?=
 =?us-ascii?Q?dAtZxLmHq4N3N2VxlVkA5qlvROoMu/nscJ8GHoprvBS54qpHcBz8Ks04CzFE?=
 =?us-ascii?Q?sWnKTlUn4MbRWsABzvU55rtKlGerUumnskEuis6jqBKWFwZp0saZm2r3mBk+?=
 =?us-ascii?Q?tfE1unpq5YaRUXL8PrI9hau5P/Zz9+6IhsoKkZFeBgpnOVm2MCLs3KSxYiLu?=
 =?us-ascii?Q?wThoQs0l7S8FGepRtPi4E7HaFDC+28F3lCRCYrGicMRckBSrlbgFUxyLrB3i?=
 =?us-ascii?Q?t6I1Ao47FdNRRaOGhf9strGarGx2DSc/zQaawahiylrLiyc3Plry3OB2bb5k?=
 =?us-ascii?Q?VoLBQMP5Q5Cv8riyeqJAkedAQ/+tyMP6zFw8mh5CpJRdIE7wXj1V86OjnakN?=
 =?us-ascii?Q?xAKB/IPTqXj9NP58XsU9GM3JxRCUNzaRvW2/jMG1Wn6Gms6uajhvRkiTqTkT?=
 =?us-ascii?Q?pTc2QrOybCcBPSbYUhmDeVJsd9l6C4jMXvcSr76C+u8jgV2kR5gHhW1IWZEA?=
 =?us-ascii?Q?+DiyqRkjVhZWNm1anNv9eVkXpKk1JQSeecXIX1jO8k079a8fWuN8zUXIt9Ke?=
 =?us-ascii?Q?b4AmWIJSYO7LNSjt9lZry72kTtmu4YyFy59d1kQHk+uI/JVzGcPL2+oxnxmo?=
 =?us-ascii?Q?t90bRYeUrLZX7YBEmOUHrUvX8SIdx1EYOwlsj+3aDR97HatqcbQVDc8t/jVM?=
 =?us-ascii?Q?FrXpMA/IiPEcBgfPItyP5oZjMB7e40NoutzR3xYmj5wdWh6c8S1Avw3rXB/v?=
 =?us-ascii?Q?imTBX3nR5GXvH8QRYVddaOdfgzomLxjLYUaRf4jrq5aQrQMNdmNwOJFHJ1RM?=
 =?us-ascii?Q?E16U/yQmXjJ34RAS5DrcAVOAhjTyupwb5DnKXTVMy6e6g2cBKS8h+fclqtek?=
 =?us-ascii?Q?iL8t+zaRRGcw/5ZiGKqwOPYxHA68hy3fQpd8+5x8ETj1zSG+P931yYzahpzP?=
 =?us-ascii?Q?leH+O0osRUo/e5Wnoa5KUuLBT5xj+FeGs1hJTtODljovIg8ibW5knil31x3G?=
 =?us-ascii?Q?MgOFjQdMqDsT2GRTWlvUhBnL59IHUO+OUBuz3yoVHfYsIpt+Vuw0mBvy8g8G?=
 =?us-ascii?Q?CzGFudrLGTe039nbaXiOxjWj4Iod2ONWbnggXGe23XuYRHfHAj0A3stOMizl?=
 =?us-ascii?Q?x00wXaljzyiyKElEeBa8ZaoO+qcIRnHdwUPbn4vtJoKorzFBfzWh/D97v5or?=
 =?us-ascii?Q?qg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: de060f8f-7497-4fa4-dc08-08dad6e2fb01
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2022 17:05:58.9752
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +C614NqY23NbivpB8OgSnFVq/6GLHKjXgsbqNyCscdsX5ylxAFSCJGqAoZz3r915w1IGsxmBBFB+EmUznCrmGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6067
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 05, 2022 at 05:25:17PM +0100, Borislav Petkov wrote:
> On Tue, Nov 29, 2022 at 01:08:28PM -0800, Ashok Raj wrote:
> > microcode_check() is only called from microcode/core.c. Move it and make
> > it static to prepare for upcoming fix of false negative when checking CPU
> > features after a microcode update.
> 
> So this function is there in cpu/common.c because it uses CPU facilities
> like cpuinfo_x86 and get_cpu_cap() so the logical place was there.
> So that I don't have to export a bunch of things but rather have the
> microcode loader call into it only.
> 
> Your next patch is using more of those CPU-specific facilities so
> "bleeding" them into the microcode loader looks like the wrong way
> around.
> 
> get_cpu_cap() deals with all those c->x86_capability arrays and other
> functions which do that, should be there too.

I was trying to move this similar to how x86_read_arch_cap_msr()
moved from x86/kernel/cpu/cpu.h -> asm/cpu.h.

Keeping the usage local since there is just one caller to microcode_check()
but there are other users of get_cpu_cap() like in
arch/x86/xen/enlighten_pv.c which seems to be reaching out to
../kernel/cpu/cpu.h. 

That said, what you say also makes sense. I'm fine with what you decide how
this should look.

Cheers
Ashok