Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Dec 2022 13:12:55 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>
Cc:     "zyjzyj2000@gmail.com" <zyjzyj2000@gmail.com>,
        "leon@kernel.org" <leon@kernel.org>,
        Bob Pearson <rpearsonhpe@gmail.com>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        Mark Bloch <mbloch@nvidia.com>, Tom Talpey <tom@talpey.com>,
        "tomasz.gromadzki@intel.com" <tomasz.gromadzki@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        "yangx.jy@fujitsu.com" <yangx.jy@fujitsu.com>,
        "Yasunori Gotou (Fujitsu)" <y-goto@fujitsu.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [for-next PATCH v6 09/10] RDMA/cm: Make QP FLUSHABLE
Message-ID: <Y44ml2qsQkx+QNRs@nvidia.com>
References: <20221116081951.32750-1-lizhijian@fujitsu.com>
 <20221116081951.32750-10-lizhijian@fujitsu.com>
 <Y3ziLoRuXFIOpnnl@nvidia.com>
 <9cf2a1c5-2334-dee8-8374-63453e23c5a3@fujitsu.com>
 <Y3+sb3RZkEO3ISpW@nvidia.com>
 <a3a10e6e-c75e-853b-06d3-ce2f67424afc@fujitsu.com>
 <Y4DOPjDKM64ryuP3@nvidia.com>
 <3c84d3ca-88f9-0995-4c0a-2b5dc69670b6@fujitsu.com>
 <3d2b0f6d-6214-8d04-8356-852c34563501@fujitsu.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3d2b0f6d-6214-8d04-8356-852c34563501@fujitsu.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?p5C5eaLS303eTz07AXewdSZ1BRxr692TTK8sMCyII9/BPrkexd5W+PxE0Jp7?=
 =?us-ascii?Q?Zi+EmrLdQ1SehQUYPolTXUE44uzUK6nwM04DEgWg1/pmv7DcHd/Q/u48pXnf?=
 =?us-ascii?Q?HAjmsWRc9tlDeCepJA0m+s2WUYDbM1EMyzK7rKldyfersdLYK0PgX5w5LA5f?=
 =?us-ascii?Q?xqr/uZPTIWISe1wdgxhkcOegerX3eFMjw+k9tA0rrxwbVqBLA/EHbqaSP95o?=
 =?us-ascii?Q?mtx0yfsdEpX75nE2CQzoEtXnVHicFe5bFNiZheP+l/X9so4H5NuyLdkhFxqG?=
 =?us-ascii?Q?i5A0umWOiO9qS1+R2649ICmk1hC7F/A9sYm9x5sh0bRuCHwj9skdJbf6+D+t?=
 =?us-ascii?Q?kWkG+ohXmCNaovQTnXq7ipCvlC8QlKExFTX8IUdulEKPTB+4okEmV/VUHFDA?=
 =?us-ascii?Q?6Swo0GPzy12KfXqarOAwHZODMyZuaNx1z2VEZEag534fjNefw14ICq3hWJUm?=
 =?us-ascii?Q?mVWNVrQMhSN0rQ/gJHqBR6lun9LIcXSzcNB2hKv2oo8DV60wxh6lhdW7oa2h?=
 =?us-ascii?Q?ISrGTpswKqHavLmBNODyK7IloSc0UmECPYH/jtr+McQ8Wwk00nN0BnZipwfU?=
 =?us-ascii?Q?N4CfwDi7TSdRkdsusXFstVt+VURxiqRg68ooKhyLVJ/gfhyWxq6v8dD3yJIe?=
 =?us-ascii?Q?7fJetpmKxwNoMBFHtC+TNlLK2WU35otQgtjGRyiNLCgFZTB9eFmsDwJxBVg3?=
 =?us-ascii?Q?aWRcfDRCGGydg9ql5Q5dCl12M4N9ek8eITBdNwxU2rALEz9k3YLgcSBiprcB?=
 =?us-ascii?Q?eggLRxParFpkP476gk8vP6FFhvohz1vWWEFte7NvkRM27Vzl1rTPB2HLApqn?=
 =?us-ascii?Q?h4jlJ8hkREOm9zRV/NWFgkQ4MxkUw3mHePI0moqebzw1LCnsT0ipJumG0qd8?=
 =?us-ascii?Q?QAjFkrfW+yUgcxoPPJIOIiiiHbHfc8xa8dT2GCBFBLtuFQbvVKkeNzniQnsb?=
 =?us-ascii?Q?Wefu0JHR0NZ3Tqb2tnoXyvYMChF+Qa0tptsMICtAypTqvM3RVCIYKujvekFz?=
 =?us-ascii?Q?dnUpVL01NIGSd8YpCStX+M4yll9d16P9IZ4lF8VFb1uZdu9lYCwqtqZUhnFd?=
 =?us-ascii?Q?J4ec77xyvXWTO51AasRDgfSF5KiZB7eg8ZkAYM3agAeWmFc5whDAI+gK1UQe?=
 =?us-ascii?Q?/V8WcUXJSxJdamQpQY3bNuIFlltUviq0nj227uuuGnSyr2PIO8oZKIWWF9qC?=
 =?us-ascii?Q?0/FGe5DlPeSCBpKdL5wR0SbxIHJB8XeT936Pewfi+H70CisAcy/T3du6T/Lz?=
 =?us-ascii?Q?yMTuwYwACU+y79js84p6WopAvFrL0VNT9EXyZrgTDF01UvP0ZDaPblQgdw1a?=
 =?us-ascii?Q?P5tp6+xWb4l8JDJrwfffh0vJyUhGrljrdy2SJ4DTKvoQZ+MTdO3lXjfKVSXn?=
 =?us-ascii?Q?xcCb9fhoPy/xCllp18gn5+4MW/fx6KLMPXtu8sCGNLZjs2hcP2hAg/pgNx4q?=
 =?us-ascii?Q?+GAjU85AhV61j/uSSmynR37DoiGdWZgZCRw42sGCCzAE9g4Kyz8yaRbe1/Vb?=
 =?us-ascii?Q?axlP5d9yK/8BhZHe6gygnY5CmP3cw8QDSoV7oij7gkZoTZbo5zECY2noHPVf?=
 =?us-ascii?Q?DLOO9SMr+LDnYP93AaMYMfi83BIWRbD9WNFE/NWv?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6a44709-c7b0-418e-5b10-08dad6e3f4db
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2022 17:12:58.1220
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vq84j57DIg+00rtNrnegYd4cE/bzd+uUq2argmg7wYLscFvhf2GEozhX7jr2K7Th
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7789
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 05, 2022 at 10:07:11AM +0000, lizhijian@fujitsu.com wrote:
> diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
> index 1f9938a2c475..603c0aecc361 100644
> --- a/drivers/infiniband/core/cm.c
> +++ b/drivers/infiniband/core/cm.c
> @@ -4094,9 +4094,18 @@ static int cm_init_qp_init_attr(struct cm_id_private *cm_id_priv,
>                  *qp_attr_mask = IB_QP_STATE | IB_QP_ACCESS_FLAGS |
>                                  IB_QP_PKEY_INDEX | IB_QP_PORT;
>                  qp_attr->qp_access_flags = IB_ACCESS_REMOTE_WRITE;
> -               if (cm_id_priv->responder_resources)
> +               if (cm_id_priv->responder_resources) {
> +                       struct ib_device *ib_dev = cm_id_priv->id.device;
> +                       u64 support_flush = ib_dev->attrs.device_cap_flags &
> +                         (IB_DEVICE_FLUSH_GLOBAL | IB_DEVICE_FLUSH_PERSISTENT);
> +                       u32 flushable = support_flush ?
> +                                       (IB_ACCESS_FLUSH_GLOBAL |
> +                                        IB_ACCESS_FLUSH_PERSISTENT) : 0;
> +
>                          qp_attr->qp_access_flags |= IB_ACCESS_REMOTE_READ |
> -                                                   IB_ACCESS_REMOTE_ATOMIC;
> +                                                   IB_ACCESS_REMOTE_ATOMIC |
> +                                                   flushable;
> +               }

This makes more sense

Jason