Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Dec 2022 10:19:07 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     Borislav Petkov <bp@alien8.de>, X86-kernel <x86@kernel.org>,
        "LKML Mailing List" <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Tony Luck <tony.luck@intel.com>, <alison.schofield@intel.com>,
        <reinette.chatre@intel.com>, Ashok Raj <ashok.raj@intel.com>
Subject: Re: [Patch V1 7/7] x86/microcode/intel: Print when early microcode
 loading fails
Message-ID: <Y442GzMi1EE9SV5R@a4bf019067fa.jf.intel.com>
References: <20221129210832.107850-1-ashok.raj@intel.com>
 <20221129210832.107850-8-ashok.raj@intel.com>
 <87v8mtob6b.ffs@tglx>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <87v8mtob6b.ffs@tglx>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7maRhAesVmAOzLZb2ee74GsEkoJN4KVVs6dnBv72deC0A8aj203BChvSK3gB?=
 =?us-ascii?Q?WLk7KK4erXGzw7ziHvit1npOIHrl8cIjj3+O88X6pK6eLq/ccVh4ZtIZFtuS?=
 =?us-ascii?Q?f8/7Ws/ROXg+hFQ7paWHYTKCjgV3hQN/18Pv0r9S1O/eob379BUNio/0GPHf?=
 =?us-ascii?Q?WA5m9vAbzMG/Fqf3y6GWaHN3EhSsYak2sGIcY7SPlNnpISVWkmOX6WEMRaiD?=
 =?us-ascii?Q?ZR3aM0RQIyBrbkl74G5VRo01k/AfN+KpYRfBSRXD4D9aGeLFERzNPBqmReFY?=
 =?us-ascii?Q?vwapDUuYJ9qt1agmTSUnLViVp0aPSxrkm34H2LqvihOBI8kubOffAu1bg936?=
 =?us-ascii?Q?07pOy2ys/I4VH6bngNQK7IOf3jav7oIvETF6EXSQNzD3Zq/rOkxOFhplSOko?=
 =?us-ascii?Q?kp56gOt01R+e9mj4qioWXb9aK3XPsZL/cI5v4x6NDT+X7KxQqVfBERT9rho/?=
 =?us-ascii?Q?4ZjysNKfVSlB9HbGBRUXYOEl4Ul9MSZ4ABOO+OgS4t1HCFXmdk3l6LQQYhjQ?=
 =?us-ascii?Q?5ngDhIv9dsPRpLmRk5vcudDdgubG9B5npAuTMDVow+5iN0kXB5x3jva+M7Wf?=
 =?us-ascii?Q?vKvM2eIedrstamAIjH2dRb9gl24Bh+8KJKYiWUk+oxhHFEVDL491bay8sLIX?=
 =?us-ascii?Q?DY9DJFRqVp8pMpxBlz5C5gLqfwcRc3ALgg6eOm4xw/zkvk0N+h+pddsxx5Fx?=
 =?us-ascii?Q?fsFl3Co4WwIltwySjeqVTtbf0sWDhDjmgS9Ph04JfPZzFLfHGO3evyLJAr1g?=
 =?us-ascii?Q?F+gfPWoAaZs6pXRnz1xpAfLS52SK/m/837k++Z0t0iPgtbLEQR+KUpID7JfK?=
 =?us-ascii?Q?TfGkY1aG3xnBMVJA/Skhl+7NJTwJ48B2yEPOUNEjqd6i8oVvrDD56aFJz+8z?=
 =?us-ascii?Q?f9xXw0Ncl4ZgScXZ6Uj/tLCCW/V2YP9pA0cvWOgB8YOS0cpcgtzZffviqjKg?=
 =?us-ascii?Q?XxOaIzvIqV92yePjmlKG1GedheAcbLMLkiE/jiAe2QIzb3x33z3ZaIZBQ5w8?=
 =?us-ascii?Q?BqUaaZ7cw+AGr9LXTJQ+avDE1mFEEzU733UypwH10pNt51WOpkts5qfMByPK?=
 =?us-ascii?Q?b4XBck6gVI2ZOUXtN0FaPpgQ5At/ZwJN6FAj6EhDK69YQT7gdQEl/EXdtN38?=
 =?us-ascii?Q?d4+PXKuyZ8IFjJjTaUWbLkFnj+/9GfzettiDl3HSAbz01SzNXm205hpuja0E?=
 =?us-ascii?Q?ghJawNFfUjXyzTAmpUPP2SsJYhWGoeOvo5mQB/6TZ26Y4qZ9kVfQ8cDCwzMC?=
 =?us-ascii?Q?YnDbBdQffey38rNq9/nKNLPj1WF2AYne6sn5gY1PM9K9R+wE0fL6fg3+0n9C?=
 =?us-ascii?Q?dk/zAMV0sykSW09BpVu5paknbalQCm7cjhCFCZJv6fvvYlH8HiGGMiGZBVZ0?=
 =?us-ascii?Q?btp9l8E6rTzLnvY+3gBR0cm1/LsUk7oaItYfc/RdG81+mM2buvRRbbdAK8jY?=
 =?us-ascii?Q?Iqgxi0+fn3ctA1644Ba8y319PQ9fBQV/qRVlAbfYMA6ofevrABe4CPXUaMKc?=
 =?us-ascii?Q?Wcp2YUfgo3Fj1KxKn+Qc61ZyTx/EFNbXQzcAB21o033RHBMZbnxLBJJ8CdJ0?=
 =?us-ascii?Q?xf8i+TTjYvQ4ZQRAmKO/rlShMGKxtuV+m2SD9lexcfJnu0MxUSMaie+4RBcd?=
 =?us-ascii?Q?cQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ac460faa-f5d6-404b-97fc-08dad6ed3622
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2022 18:19:13.1582
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jJiIXIRsYiJU0DsvajJLZSxf2B7D2yyiiIa3fiuI2bjAX5pMQhxUJl/h/8HlCKRdIULdpYDdv3A08xxnITEBGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7464
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 02, 2022 at 08:30:52PM +0100, Thomas Gleixner wrote:
> On Tue, Nov 29 2022 at 13:08, Ashok Raj wrote:
> 
> > Currently when early microcode loading fails there is no way for user to
> 
> the user
> 
> > know that the update failed.
> >
> > Store the failed status and pass it to print_ucode_info() to let early
> > loading failures to captured in console log.
> 
> so that early loading failures are captured in dmesg.
> 
> Hmm?

Thanks for the review Thomas. 

Boris, I have fixups to address all of Thomas's comments. Would you
like me to repost a new series with those fixups?

I'll drop patch1, since you have merged it in tip. You have a candidate for
patch2 as well, maybe I can drop that as well.

This patch has a type cast warning for 32bit compiles that I have fixed as
well.

I added a new patch to address Thomas's comment to print revs only when
loading succeeds[1].

Cheers,
Ashok

[1] https://lore.kernel.org/lkml/874judpqqd.ffs@tglx/