Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wang, Weilin" <weilin.wang@intel.com>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
CC:     Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
        "Ingo Molnar" <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Ian Rogers <irogers@google.com>,
        "Hunter, Adrian" <adrian.hunter@intel.com>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
        Kan Liang <kan.liang@linux.intel.com>,
        Zhengjun Xing <zhengjun.xing@linux.intel.com>,
        James Clark <james.clark@arm.com>,
        Athira Jajeev <atrajeev@linux.vnet.ibm.com>
Subject: RE: [PATCH] perf stat: Fix multi-line metric output in JSON
Thread-Topic: [PATCH] perf stat: Fix multi-line metric output in JSON
Thread-Index: AQHZBoD5lGUsRu3DdE2l74CJjH33Pa5a/C4ggARKxgCAAFRu0A==
Date:   Mon, 5 Dec 2022 18:07:39 +0000
Message-ID: <CO6PR11MB563587FE3F6CC5475E9D8864EE189@CO6PR11MB5635.namprd11.prod.outlook.com>
References: <20221202190447.1588680-1-namhyung@kernel.org>
 <CO6PR11MB5635C3BB62A1B9FA532DF57BEE179@CO6PR11MB5635.namprd11.prod.outlook.com>
 <Y43sJkk79WMbg8Eq@kernel.org>
In-Reply-To: <Y43sJkk79WMbg8Eq@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?j6MN/7JYHD93N38xUkDo2WVwIRq3JjrgPdYttkHA2zeiIsEH6bMcK7dqQCCq?=
 =?us-ascii?Q?OATMULiD+SHnauHyUngHhfJep2p4FfIL7mQio0VxoToFvek08xdGfF2LEMsC?=
 =?us-ascii?Q?EvBUt/UQ5eTLQ/8T/FCiO0e8qF73Witx6WG3E9I6nnqakN5gCNTs8E5y+4ZQ?=
 =?us-ascii?Q?oLvkXVLopJeocgl4qgKbvMd5vJpmC2oRyC0oYn3rruLRXCmcbgKrLRrhH7q8?=
 =?us-ascii?Q?yGeClJQdX4QuSG8eP/b/wUUFstrY5joWKFuBnj6nj6xT0/rxqcPslhu/QsKp?=
 =?us-ascii?Q?IzsWFWOd4PuwDOPr2V4lHLP01Jn+vUClh7OMhKHN3OVdsdmzaHnrbGIN/e+d?=
 =?us-ascii?Q?DS/a6xAMaLOu+/VVt3exu15OtbHVzhmaDN14NTO4fA60d7dK9Bfn+q9M5bd9?=
 =?us-ascii?Q?kBiCJeOCk8BycEid8fntCGMRjc664ehDpoYvATjy+Mk4PDsTGusaYQJ7XrM+?=
 =?us-ascii?Q?1rUItZFzG/QerYA2cL3+USQF0LmjjjD4wCJJln1C+ITi487SKlAYO6z+Psd9?=
 =?us-ascii?Q?x/Z7Zlgx485e5Bud43CEhXL1YFkgLlOnTwob7aKYjsWg0iE/K8AbjAdvzRbo?=
 =?us-ascii?Q?CJH55T44jc7DVV3j7hGj6HPmOp+ZxGc3QpcgMPUeB1TLaDuzIlmehRFURo8T?=
 =?us-ascii?Q?upaBNULL7HNBA+QumQqjVcOme8N0q58RLVWDgJiEsJwXkbA7MRoG0B4bHNPR?=
 =?us-ascii?Q?IkxrsIx0n/gX1GiIHIVOGyG8nCYHX9cRRDiOoV7F3TUfuLTfQaBXU9Yd6zDr?=
 =?us-ascii?Q?5JEh3qE2RmDFPSoG3lOSCDEOMPKG9RUSvR7HvS0vhUuwElMoHgNSi92qS9ou?=
 =?us-ascii?Q?2J02dBBAnuKd7uhw8L6AwqwNMc7jai3jHCGcef0EzrBfoSoyN34hbSu6jjNh?=
 =?us-ascii?Q?Ze/1Zx2W+Ci1Jlejrles2YGZUgq3hg5LjNZebYw8tPKVMQu8Qu7ZAkbyfVf8?=
 =?us-ascii?Q?VxEOwLZIxOZW2FYz96ROxa8j20FYdCGm+NV2zqsmlkdseZprfoXmQk9Gyp/+?=
 =?us-ascii?Q?OQfY+Tz1A2c49ylaLfKEWL+fxXY/J7W9ZI78AmFwGk7s8mU97UUkNO2I2qXP?=
 =?us-ascii?Q?rj9kCJZ6gaTar6bkfyWjWL7+RSOe1op3Z1wa1PvpuLHemniMwbOikZKXm3s/?=
 =?us-ascii?Q?Vt71ZBnhgDTzjIhnHb+ZjN69uO3t6QmD8FBOZuukVWV1fI7UUeSa8IIAYLHL?=
 =?us-ascii?Q?X5yknGsf4/bPkuXT8ndwuk/w1laj4Hr9eMeC8IpymaX2jLXto4H0q4ioFh/K?=
 =?us-ascii?Q?Ib7uURDZlnavNI/Pdo/ZHcFZHdIPpRcZQmQe4LjNJz/2oYDL1Dn4+Ek288vP?=
 =?us-ascii?Q?D0oIQABFUeO8WlMt12UzOXr8XWGmf9giTNCH35IpFRG7JuC7TeZHR2c4aODQ?=
 =?us-ascii?Q?Oq7nU2El+0CRW57zsBaS+x0JJrZpORJRiRWDAY1vEBp01+YNkRwLqCNyDmO5?=
 =?us-ascii?Q?dQ/lKbfkKFwt4P5OIBTXqmvuxymq95pRqCetKHbs3eP87xERF8ahZbm714Bg?=
 =?us-ascii?Q?2hrq9RuTLQu+M7nGJmdVYAyVDxe+PGsPrgjxrAvGSA9wXW8Fqs3myvyGwoEn?=
 =?us-ascii?Q?lxgRwg3oZcMaZ2q31Y3fagRBrI1qvRj5t+Tm6xW9?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5635.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d58318e8-e596-4420-5bdc-08dad6eb98bf
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2022 18:07:39.4370
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: aNr93o/9GOWVjw52mpkpkrBD+M/l/PkEdCerrUXj7dNXsmHZwu/YJ8q1D+qNOrt+vX0XOsFYQoC+R7ZpXgkYxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5008
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Yes, no problem.=20

Thanks,=20
Weilin

-----Original Message-----
From: Arnaldo Carvalho de Melo <acme@kernel.org>=20
Sent: Monday, December 5, 2022 5:04 AM
To: Wang, Weilin <weilin.wang@intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>; Jiri Olsa <jolsa@kernel.org>; Ingo =
Molnar <mingo@kernel.org>; Peter Zijlstra <peterz@infradead.org>; LKML <lin=
ux-kernel@vger.kernel.org>; Ian Rogers <irogers@google.com>; Hunter, Adrian=
 <adrian.hunter@intel.com>; linux-perf-users@vger.kernel.org; Kan Liang <ka=
n.liang@linux.intel.com>; Zhengjun Xing <zhengjun.xing@linux.intel.com>; Ja=
mes Clark <james.clark@arm.com>; Athira Jajeev <atrajeev@linux.vnet.ibm.com=
>
Subject: Re: [PATCH] perf stat: Fix multi-line metric output in JSON

Em Fri, Dec 02, 2022 at 07:31:59PM +0000, Wang, Weilin escreveu:
> Namhyung, it works. Thanks!

Thanks, applied and added a Tested-by: Weilin, ok?

- Arnaldo
=20
> -----Original Message-----
> From: Namhyung Kim <namhyung@gmail.com> On Behalf Of Namhyung Kim
> Sent: Friday, December 2, 2022 11:05 AM
> To: Arnaldo Carvalho de Melo <acme@kernel.org>; Jiri Olsa <jolsa@kernel.o=
rg>
> Cc: Ingo Molnar <mingo@kernel.org>; Peter Zijlstra <peterz@infradead.org>=
; LKML <linux-kernel@vger.kernel.org>; Ian Rogers <irogers@google.com>; Hun=
ter, Adrian <adrian.hunter@intel.com>; linux-perf-users@vger.kernel.org; Ka=
n Liang <kan.liang@linux.intel.com>; Zhengjun Xing <zhengjun.xing@linux.int=
el.com>; James Clark <james.clark@arm.com>; Athira Jajeev <atrajeev@linux.v=
net.ibm.com>; Wang, Weilin <weilin.wang@intel.com>
> Subject: [PATCH] perf stat: Fix multi-line metric output in JSON
>=20
> When a metric produces more than one values, it missed to print the openi=
ng bracket.
>=20
> Fixes: ab6baaae2735 ("perf stat: Fix JSON output in metric-only mode")
> Reported-by: "Wang, Weilin" <weilin.wang@intel.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> Weilin, could you please verify it fixes your problem?
>=20
>  tools/perf/util/stat-display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-displa=
y.c index f1ee4b052198..8d0bdd57163d 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -440,7 +440,7 @@ static void new_line_json(struct perf_stat_config *co=
nfig, void *ctx)  {
>  	struct outstate *os =3D ctx;
> =20
> -	fputc('\n', os->fh);
> +	fputs("\n{", os->fh);
>  	if (os->prefix)
>  		fprintf(os->fh, "%s", os->prefix);
>  	aggr_printout(config, os->evsel, os->id, os->nr);
> --
> 2.39.0.rc0.267.gcb52ba06e7-goog

--=20

- Arnaldo