Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Dec 2022 21:40:54 +0000
From:   Gary Guo <gary@garyguo.net>
To:     Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] rust: make compiler-builtin stubs non-global
Message-ID: <20221205214054.6b9e6a7e@GaryWorkstation>
In-Reply-To: <CANiq72mXQed42DARuOjEipUffNxx97LRL+byZ0G2kjuRup6ZYQ@mail.gmail.com>
References: <20221204231650.2604587-1-gary@garyguo.net>
        <CANiq72mXQed42DARuOjEipUffNxx97LRL+byZ0G2kjuRup6ZYQ@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?t2t0SHLTvsACUsJ+NcK58FeqrGOu2fTCeRHZepN9VGSfX0JkdpNotyPo3N3x?=
 =?us-ascii?Q?SnyJBLUE/aI3Q+rLhI0bR91pOV8kdtsTCWNV5LqNzsZKm/q1iL8qIp2AW+sc?=
 =?us-ascii?Q?aLVTclQgy4GEscr6TJ/jF0zhak9NSPgx2XTWvi+53C+5UrRTf59BwqqtY0fj?=
 =?us-ascii?Q?H8TI5MRRAt3FyyxfMB0RC6BoVrcsgbLQzEFRNTX7o8Y/dRqToISAsUXuraLP?=
 =?us-ascii?Q?kod4ZXd1/J3a5lpq+VbhigmxlwiVhD/lfwoud/iUZBm1ilzWCIQhfQyUSohX?=
 =?us-ascii?Q?JCw47RMNKgYw+uDaBx0XAwDLqyhI/PR0t83Pfjj+1a1FYzxFcYN/KBO0qq2L?=
 =?us-ascii?Q?UZwAqMlKtaddpTKjhRMIoIQ9QHRSvzAjU1H+mvlWEAAYymbx3cJKIlRAmlzw?=
 =?us-ascii?Q?htnUDrnk8g+Va9GqMBAQM8RyNu0i48eB27nOL2cB212waEBugTlRPtepf2WS?=
 =?us-ascii?Q?71xeiG5v14EpOrtgenA2KBFZkS7BXIXRiEg05rCGeyEsVhHB1xm9pPsYWojw?=
 =?us-ascii?Q?PqnB+L0YtF8XdnXsaXc1n9/KXQdB/A02dyy+Oz+7dCvwA6cFJwxNxb67nkEb?=
 =?us-ascii?Q?ZULRKzxBNVjhB3+UnaEZu0t1tpR7soQf7k/4i4MVz9TJNzvKIBJb2TFvHYu7?=
 =?us-ascii?Q?R5OD6kG17CtukzMWsLmAL7PTJR0HrXDBzRenxDY6ZdOkVrwdSfmoU50qyB2k?=
 =?us-ascii?Q?FtkpjP+qNi+xSwSU/u4vFJx6E/2jAhAndOBDIEUUWC9QAQVdZaYlpk6e6q8o?=
 =?us-ascii?Q?ekU80pbs05RNWCzTiv3udQWlDv+4os7X+DTlSlqqnq1xCQzaMDxZQZ9QVOMv?=
 =?us-ascii?Q?dfKg3o2QldxkSC6mYMTXVaLjN95P9a6GwJNbuc0c5uneQHhHvblG/tOL5xxV?=
 =?us-ascii?Q?j8M7hmACBhqe2/tTdAsyFqqKjK3ZdOaLfSVbqnmSYOqKgI8d4jtl5VK/3NkI?=
 =?us-ascii?Q?lHaWnYojdrCIm+NL+E63DrugmqqjcPSSiV/IhIEdDQ09Fnxn5rc5UGBxi8MA?=
 =?us-ascii?Q?vd3cccpvpe5xLtRpj1HW9m6fMfBu3k5IhResFoxxQsh/B0+Z1EHR6LO1ebpw?=
 =?us-ascii?Q?DfRqDzwFDEA4QVW+aNXDbyRijyS9GtzyZRV4waCWzdFNmNvy1kUhgYx83ZzH?=
 =?us-ascii?Q?cQ6JFlH33ozOiZNFpZR1/F36D4bzfE+NpIDk2nw9eGLuLvWxhMXMe1c1j+Ce?=
 =?us-ascii?Q?ftZj/JvQM2dwt1mJ91vff4uxYR6+lykpVELAkxgFwbHjeQmOCHe7/nrWZcHH?=
 =?us-ascii?Q?RHGDZQ5YrmS8MqpXBAWEd+OUKUaWsLnE4CgwIeR65eHuD+7S/TXheF+4X36l?=
 =?us-ascii?Q?ksT6RPPd7UufAos+Xqw3OFBWPTDIusb8UP7sTFP/AJV6PqWJO1lex5gT+h2f?=
 =?us-ascii?Q?aam/wyIcnYEpCV3ikEZxlZeqcsecuca09DPy+uG87UDFbPWVFxbVpKzSVnjd?=
 =?us-ascii?Q?yY/blDwuKfUOK3a76SsCMWjrZ+nsNZd1KCSFxRGfmdg3C9CHunWV8NVcY8HQ?=
 =?us-ascii?Q?x5RM6U/4r1c7sK3Fgtjlv1tNz7+SZBy401xWCpVL4rSyFFAFkF5Ks/Z9wh4x?=
 =?us-ascii?Q?m8Z3xy4zLeBEcOE3NkL8RgFsD+m4lJFTw30p4iMmCLE6sy729z+ZiC6/+FKb?=
 =?us-ascii?Q?sR0n4ncS9SnDC5geYJ5oVweJIMHzeQtzCMk7G7B7odB6?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: b9a1074e-fc91-42c1-0ddc-08dad7096447
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2022 21:40:56.4808
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sXPQnrKset6SMBGpEWs6Ff7F2sP3l4i7v3oDnS1OoKBvjKvEaOCoFMtELYQW8EvJ0Rr+QKTHg+655s5yrrsNFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP265MB5179
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 5 Dec 2022 21:26:27 +0100
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:

> On Mon, Dec 5, 2022 at 12:17 AM Gary Guo <gary@garyguo.net> wrote:
> >
> > This patch was previous discussed on GitHub.  
> 
> previous -> previously
> 
> > Link: https://github.com/Rust-for-Linux/linux/pull/779
> >
> > Signed-off-by: Gary Guo <gary@garyguo.net>  
> 
> Hmm... Something happened to the patch (compared to v1): the triple
> dashes, the diffstat, the base-commit etc. are not there. It can still
> be applied, so no worries, but it feels a bit strange.

Checked my bash history, and realised that there is a mistakenly added
`p` in my argument to `git format-patch` :)

> 
> The newline between the tags should not be there. Instead, please put
> it on top of `Link:` to keep tags separated (if you wanted to keep it
> close to the sentence to refer to it, you can use "[1]" instead and
> then "Link: https... [1]" in the tag).
> 
> > +// NOTE: if you are adding a new intrinsic is added here, you should also add it to
> > +// `redirect-intrinsics` in `rust/Makefile`.  
> 
> "is added" -> "". Also, what about putting the message at the top
> instead (below the docs or perhaps after the macro but before the
> calls to it)?

People usually add new things to the bottom, and that's my rationale
for adding the note there.

> 
> For the title of the patch, in the end I went with "rust: xxx: ..."
> (where xxx is typically the name of the crate or the `kernel` crate
> module), so perhaps "rust: compiler_builtins: make stubs non-global"
> or similar?

Will address, along with other suggestions, in v3.

Best,
Gary