Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Gary Guo <gary@garyguo.net>
To:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
        =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= <bjorn3_gh@protonmail.com>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Nick Desaulniers <ndesaulniers@google.com>
Subject: [PATCH v4] rust: compiler_builtins: make stubs non-global
Date:   Mon,  5 Dec 2022 21:50:00 +0000
Message-Id: <20221205215000.2563281-1-gary@garyguo.net>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ndrWK5/P2T+gpSd8DUW8crakHKye4icV1PpR1QvYOKkA4vb2mEn7MSwW6Vpg?=
 =?us-ascii?Q?2LOZMRbhe2RtH8Vfa0lnpgpGvSbZJ+K36DpJjeEGZuuNjMLGFSwk6kYRj17R?=
 =?us-ascii?Q?FEwOG8YC3nlK0reA5RHvljv7BcOolegdA6O+N0zuPzc7eu/+ln3rDNP0TFtZ?=
 =?us-ascii?Q?ephJcox69E/hFJ10PT13j83YpZ3+5BrCYq/x7Zr9DN3iqORwNcrSiPn2WpbP?=
 =?us-ascii?Q?jMuhol3fqSsHF56g5idW1ZQlQ5ihNfxwCxcqCB/4DwfhMQGDfrm1rD3//Gok?=
 =?us-ascii?Q?WkwpQTX8SeM1B7khtQfwGoEaVX4yPoPMAa5Fw9Jlmm8K2JK18UhWRgHQh+4B?=
 =?us-ascii?Q?4wnwPbQyticRg8Q3bN5/kurlz0Mf/l8g2R77BxGk9RPbP6j3NO6LN2V/jewX?=
 =?us-ascii?Q?jPw6Xm7Cz3G8x+ysQ3twEqMkNqUxbuT3E7qB69BGsbxjoixVb7c3CcCY0lnN?=
 =?us-ascii?Q?zvNzjFnJSsuJ8s6G5bdWF5Tc7+2y/d9HbkJtoW0nbr59OLF8mxAutfQ48q8P?=
 =?us-ascii?Q?XFqkjWXJuXs2e24m4xzfphSkVqVrSkM1QiLHCC4yfRlEeXWOI2BxSO/5bi/W?=
 =?us-ascii?Q?N7+M/XHLhn484YYLodY6tLV6x9o0C+ZaPRF0CKMA0C/JpGeGU1e3ZX9pOKVw?=
 =?us-ascii?Q?lW+TIKYFUw8+RZRxKax8qd6yTPCrwrQhMX24aBv/W1/aCTWDWXSDbLKHCFin?=
 =?us-ascii?Q?EYNZN+716sFj2kcY/IONqS4xcvhyquMv5Yy+Bbm0+IhJLa55EQ2EVEqIsxDu?=
 =?us-ascii?Q?NceGjF8GavQ6nTo0ZjuC2wd5KUxEH3rMi4FyPIHdAp3Rrvl9jQr5ElPpjA+n?=
 =?us-ascii?Q?4Ajm9C0n9H85UIodyHXY2vx/1TqAo6NJlFtvbf+j6qK6W3x2Nh5kvBFDxvRA?=
 =?us-ascii?Q?ei7Sr3/8llIwLqK36szkikdJoZ8sQvNWFcJx1s3ALxmdOH/5hc5wISB98oep?=
 =?us-ascii?Q?Jts+Fk6zepLPI+0GlQBkw1qFSza/26/9GPivtC4tDxA8cDQmfM3iI19AshpM?=
 =?us-ascii?Q?tgOx/EwkAVIRY9fqKJcRlooOq17Xen2BkEUq8/6qyxJ2+cdPNB+xRh1wRGCN?=
 =?us-ascii?Q?jLPiSidwm9YK6TveA2VJRvKYxzUeWUBqHLxicCUPsDFys0JNBIiROW/eqOJp?=
 =?us-ascii?Q?0uK6m/YGi04/48xGO4YA2dNRprCwmfztpeesaUFhPt5Z2rZIABRSnq1l1iqM?=
 =?us-ascii?Q?vKLhSLrGvS/S4/qhVxpejI90KXWP7Bo3Q13DpGCQyb5u7pSsVc3WUQishVl7?=
 =?us-ascii?Q?wQ0sXlYk3Eep3QPSk5wq/j41mEaOsLs1xGq0AI9Bny2hC+D3fUHn7d07yFsZ?=
 =?us-ascii?Q?IniiKxPq3NQVQ16dVFDpe/x1AbM6MCOoRY2QMNpfdSLJiPJ+78oR/8mG9Igj?=
 =?us-ascii?Q?WwX/S5syr3C2IZYLV4aRc6liQlnpABFDWTwFo0S0oQZhUvgrAbSJjchVvZ9d?=
 =?us-ascii?Q?08QkHJ7dfRMI0AAoptOiV3uHBozY/dYasLjKLciKX/t15K1uyMXHTBs6Gsv9?=
 =?us-ascii?Q?VWCRO8GJu2n377HThZE/O3SvMSwg0KQHcoh/JZDu4ZrGkX4a88xPMAFYLH5n?=
 =?us-ascii?Q?T59J/y9t6GguYTT88qQ=3D?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: da49c94a-19b9-495a-e357-08dad70ab07e
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2022 21:50:15.2731
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PdNVIlu39xAwXvsT8qUMrLZSkSOtD6EsFkl12IkY3ZiCrH03BvtDZOjCl+Cdr7KyDr63NcK83n0AsPiLGTJeSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO4P265MB6464
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Currently we define a number of stubs for compiler-builtin intrinsics
that compiled libcore generates. The defined stubs are weak so they will
not conflict with genuine implementation of these intrinsics, but their
effect is global and will cause non-libcore code that accidently
generate these intrinsics calls compile and bug on runtime.

Instead of defining a stub that can affect all code, this patch uses
objcopy's `--redefine-sym` flag to redirect these calls (from libcore
only) to a prefixed version (e.g. redirect `__multi3` to `__rust_multi3`),
so we can define panciking stubs that are only visible to libcore.

This patch was previously discussed on GitHub [1]. This approach was also
independently proposed by Nick Desaulniers in [2].

Link: https://github.com/Rust-for-Linux/linux/pull/779 [1]
Link: https://lore.kernel.org/lkml/CAKwvOdkc0Qhwu=gfe1+H23TnAa6jnO6A3ZCO687dH6mSrATmDA@mail.gmail.com/
Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Acked-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Gary Guo <gary@garyguo.net>
---
 rust/Makefile             | 14 ++++++++++++++
 rust/compiler_builtins.rs |  5 ++++-
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/rust/Makefile b/rust/Makefile
index ff70c4c916f8..aed6f7eca36f 100644
--- a/rust/Makefile
+++ b/rust/Makefile
@@ -359,8 +359,22 @@ rust-analyzer:
 	$(Q)$(srctree)/scripts/generate_rust_analyzer.py $(srctree) $(objtree) \
 		$(RUST_LIB_SRC) > $(objtree)/rust-project.json
 
+redirect-intrinsics = \
+	__eqsf2 __gesf2 __lesf2 __nesf2 __unordsf2 \
+	__unorddf2 \
+	__muloti4 __multi3 \
+	__udivmodti4 __udivti3 __umodti3
+
+ifneq ($(or $(CONFIG_ARM64),$(and $(CONFIG_RISCV),$(CONFIG_64BIT))),)
+	# These intrinsics are defined for ARM64 and RISCV64
+	redirect-intrinsics += \
+		__ashrti3 \
+		__ashlti3 __lshrti3
+endif
+
 $(obj)/core.o: private skip_clippy = 1
 $(obj)/core.o: private skip_flags = -Dunreachable_pub
+$(obj)/core.o: private rustc_objcopy = $(foreach sym,$(redirect-intrinsics),--redefine-sym $(sym)=__rust$(sym))
 $(obj)/core.o: private rustc_target_flags = $(core-cfgs)
 $(obj)/core.o: $(RUST_LIB_SRC)/core/src/lib.rs $(obj)/target.json FORCE
 	$(call if_changed_dep,rustc_library)
diff --git a/rust/compiler_builtins.rs b/rust/compiler_builtins.rs
index f8f39a3e6855..43378357ece9 100644
--- a/rust/compiler_builtins.rs
+++ b/rust/compiler_builtins.rs
@@ -28,7 +28,7 @@ macro_rules! define_panicking_intrinsics(
     ($reason: tt, { $($ident: ident, )* }) => {
         $(
             #[doc(hidden)]
-            #[no_mangle]
+            #[export_name = concat!("__rust", stringify!($ident))]
             pub extern "C" fn $ident() {
                 panic!($reason);
             }
@@ -61,3 +61,6 @@ define_panicking_intrinsics!("`u128` should not be used", {
     __udivti3,
     __umodti3,
 });
+
+// NOTE: if you are adding a new intrinsic here, you should also add it to
+// `redirect-intrinsics` in `rust/Makefile`.
-- 
2.34.1