To: Neil Horman <nhorman@tuxdriver.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
       torvalds@linux-foundation.org
Subject: Re: [PATCH]: proc: export a processes resource limits via proc/<pid>
In-Reply-To: Your message of "Mon, 13 Aug 2007 10:00:44 EDT."
             <20070813140044.GB1960@hmsreliant.think-freely.org>
From: Valdis.Kletnieks@vt.edu
References: <20070813140044.GB1960@hmsreliant.think-freely.org>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1187023658_3175P";
	 micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date: Mon, 13 Aug 2007 12:47:38 -0400
Message-ID: <10638.1187023658@turing-police.cc.vt.edu>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2146
Lines: 54

--==_Exmh_1187023658_3175P
Content-Type: text/plain; charset=us-ascii

On Mon, 13 Aug 2007 10:00:44 EDT, Neil Horman said:
> Hey there-
> 	Currently, there exists no method for a process to query the resource
> limits of another process.  They can be inferred via some mechanisms but they
> cannot be explicitly determined.  Given that this information can be usefull to
> know during the debugging of an application, I've written this patch which
> exports all of a processes limits via /proc/<pid>/limits.  Tested successfully
> by myself on x86 on top of 2.6.23-rc2-mm1.

>  /************************************************************************/
>  /*                       Here the fs part begins                        */
>  /************************************************************************/
> @@ -2017,6 +2080,7 @@ static const struct pid_entry tgid_base_stuff[] = {
>  	INF("environ",    S_IRUSR, pid_environ),
>  	INF("auxv",       S_IRUSR, pid_auxv),
>  	INF("status",     S_IRUGO, pid_status),
> +	INF("limits",	  S_IRUGO, pid_limits),

Any takers for S_IRUSR instead?  Either that, or lay out the use case for
making it S_IRUGO.  (I'm OK on it being world-visible *if* there's a good
and sane reason for it)

>  #ifdef CONFIG_SCHED_DEBUG
>  	REG("sched",      S_IRUGO|S_IWUSR, pid_sched),
>  #endif
> @@ -2310,6 +2374,7 @@ static const struct pid_entry tid_base_stuff[] = {
>  	INF("environ",   S_IRUSR, pid_environ),
>  	INF("auxv",      S_IRUSR, pid_auxv),
>  	INF("status",    S_IRUGO, pid_status),
> +	INF("limits",	 S_IRUGO, pid_limits),

Here too.

--==_Exmh_1187023658_3175P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Exmh version 2.5 07/13/2001

iD8DBQFGwIsqcC3lWbTT17ARAj90AJwNaHgTgWN91dKPxTqUcjaDC/TuiwCgwAOg
iUDlsa+b/VUTg4VPSZ1My6M=
=95Fs
-----END PGP SIGNATURE-----

--==_Exmh_1187023658_3175P--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/