Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Dec 2022 14:23:37 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Peter Xu <peterx@redhat.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        James Houghton <jthoughton@google.com>,
        Jann Horn <jannh@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Rik van Riel <riel@surriel.com>,
        Nadav Amit <nadav.amit@gmail.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Muchun Song <songmuchun@bytedance.com>,
        David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH 05/10] mm/hugetlb: Make userfaultfd_huge_must_wait() safe
 to pmd unshare
Message-ID: <Y45vab2k+S4DN1vd@monkey>
References: <20221129193526.3588187-1-peterx@redhat.com>
 <20221129193526.3588187-6-peterx@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221129193526.3588187-6-peterx@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WlFq06T4gmdvR1r9vGy2nshvZcB/xXTScRQ0uOTTPDHN1sCenuSNyoAIjYQg?=
 =?us-ascii?Q?SnzdRHTkr36h3QJh5jMpeH0EZMSQ/levHXTk0OgXNs/r0aPTB5bYW332B1dU?=
 =?us-ascii?Q?8xuUIwJAOMDyN24a1x6PmNd+uhq/MRerz2sRhlgdFF1gtbWZ9IM4hMP7G3wz?=
 =?us-ascii?Q?dkR4mC3nEjgeHggGLmRCLd5pc7BQ/gcc0O0axp8XpAg7FfA6m0EWZS4oPUCS?=
 =?us-ascii?Q?+4y19dHJxwcR0J9brjnaPG5LB8UdxNDFARVWxHwOpEZYR20dsfy9ybx5tpSS?=
 =?us-ascii?Q?Z5gc7vrol6OzairAMkg0e4zGLG3QG154O+6t+1ghI1tMooII3YEsYP3OKVpJ?=
 =?us-ascii?Q?X+lD5lvAXuc8fBKJb30RC2Pys2FVYVj0+U9e562H0vZ3hSxqOBYuaIh2wbEm?=
 =?us-ascii?Q?A+lSnNFp60MFLyfLU4XkIrd8Uz3uYbLtJqPlUH2pQlke8aiDRkfqrMXVst+F?=
 =?us-ascii?Q?A4An7tE1D+O5/SLGRbGkbQqW/zqiVus9RUBbqPVB6nrX5MFNi69qY2XTajTv?=
 =?us-ascii?Q?yvSu0ygWHDLkqAUArwluXjKx801eZEkv8HX3AWuw89DjsD1iarP77YbhdusJ?=
 =?us-ascii?Q?Ay/GuCdN0A0puB6WPkfa0M7UZH/cwrZk+qo8A5OmP53CWvlrwxUZwms0qLo8?=
 =?us-ascii?Q?yMub5DfAaZKuDqPcKBggPfKvyFe+h2iLpQePiu2C19klDq1gLO+m2FYr8/lb?=
 =?us-ascii?Q?XATP9z0MCzItHkbmWLDa8hnxZuiw3313giydldHiezVYd3imgg6mzwjaM8Ww?=
 =?us-ascii?Q?+qZoxIlvCVFAHUv1SRzrbixUEVzeA69ibtJx2dj/f1g3YRcCq0YmjGLcD2h9?=
 =?us-ascii?Q?mSdT5A5jcuUiQFJ8vDUsWD0bWS0mkdBNxqeIirsOkZC5mzYqZfGfY5RMDGj/?=
 =?us-ascii?Q?srcAc73GreX1ar70qg328FWDWhvKIG4ktFrF3Rv64Ow+qd4ieCi8Efe2622X?=
 =?us-ascii?Q?N2ugzkG7PUuNIp98JOWLlL7wlOMzPMVWva6l43QQ9POZ2NPdSohwz9z0Cp4U?=
 =?us-ascii?Q?9eRyd/qUIbNPfmYMHCuHNmTPxWBFcZd+CJyI2UMxx2yZZIRzOtzejin2oalK?=
 =?us-ascii?Q?kscPPNzO/OrRwmaiQkFx8QzMQK9ZHZQ0kIffpUp30WHMoYJ7+u0Q7K7+wiTR?=
 =?us-ascii?Q?ksb3gpxufHKb+9A/wTpuH/lkuz4Lpb/jJD+h5vi4IuOtaIqm/t8oFYFPRf6+?=
 =?us-ascii?Q?uERPJAa9HqerBgCMHxh7xVBjQRirzs2Fvgix8gg2bblDn+MekevTT+8N5KYq?=
 =?us-ascii?Q?uGvWmTtnYfhsah8A+L9zPni3gIMCn3o2LwAir+rfTr1gkbS6SyQ91JoBPHbm?=
 =?us-ascii?Q?nffGL4IjxPgXCxXrXRMDLdytyA62nOIh08KbynU3EjQ/BCBqqEoqh9FpyaK8?=
 =?us-ascii?Q?ooDclUtu+816tQy2PPkH+JJy3/n/76Kyi+D/w/NkbsA2Q84D47hm7KjT6Zi/?=
 =?us-ascii?Q?Q8Zloa7HKEZfIRc5QUs8MO4Ly7pPyW7LiCPQA0t3qlFaiEXE1pM36pJrYCiu?=
 =?us-ascii?Q?taEo96wY3Bp793abaUAlKWabhmohTGfq5n7vzWBknW5pU+Bbwr70Ol8se3A3?=
 =?us-ascii?Q?fZUrzuWNOe4ST7V+Iyabfjg9lgjPCLbrQjIoFYcNDH5Ek4NpzLREea9rT5FB?=
 =?us-ascii?Q?6g=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?ds+KxYrxEVL/kjGNf3+I9jRSuV0MMJEpX6IPxRkutIlPofAIQTPEepuOF1xB?=
 =?us-ascii?Q?TfUD+ujI8lm6EOUn1tci/7V9gEleSrdCRjNGoQJ8cMiWHEVkyZa4m1s5Yj+E?=
 =?us-ascii?Q?QLHNlRYJhegjBvFcU1ttU5n/KWDIl5UNNPo9FGSeEbHk5MGcS8u3ozgzQytc?=
 =?us-ascii?Q?uj5xD5FmR3P7EDdv/kVDGfuhcvOFNu78+UhUqlOgPYGEF5ERdHhmfAVq8NG2?=
 =?us-ascii?Q?/hV+TmCKldAxOActLyhP+61yIxiexJ0SABSijbgQ4MyC3mGkafX3rarlI9JB?=
 =?us-ascii?Q?je1engnDu5ZBVYFP1iHobRLsDNK90i4N6vm4NUDvM6imw8mvqggM186AGkn1?=
 =?us-ascii?Q?W+DZfgBwghgfP/lGpVXgn8Ed2jibUOPzdJdEGAfLHkuZA4fPaIBbs0H7XyCo?=
 =?us-ascii?Q?3uBDgEIj/kzPIlJrPRbN0EOoSiEzvBTkfonmnAZ/Cp1Y16NP/yPvoYU2eHS2?=
 =?us-ascii?Q?jlHGAZ1sdN4NwQZU4IcOPqaEjcRFcsOgAYsZcTEQ7YT6FKmswnlvqdPRpcnF?=
 =?us-ascii?Q?7/XsebEF6gBZ3HuoFdhYuhbQAJSLdu/ex/K+z092p6IvJSuZeyHa7YgOogg0?=
 =?us-ascii?Q?IzVXFkJdrBXcylf78dh9wHijXuLljgKUdpJxI3LGwIW19Ipi3eJj5lPskq1e?=
 =?us-ascii?Q?7Rqx4Xfns0XZHtfwdueF5ppeKE9qViZ9tDan5X0CLyucJAoql5s7crA7+lO1?=
 =?us-ascii?Q?xyWQOXLJuvMrQeMdMUl1xl/365Lc7BBi0SK3svOj3D2cKk3rEQu83xQURox/?=
 =?us-ascii?Q?svKFZnGjVRHIQzQdHldFQpTXL5XGfrZnSPzLqpV3zIzgntgWSbDY17KFJ388?=
 =?us-ascii?Q?Hafvw9w1GilPLV4+0vtr/jBFKJ9upbAhBhsYFe6+0AYKm3F1mLkIXeWRPyhR?=
 =?us-ascii?Q?OmP5+xDzcpspXVALIwkfKL5XSvGXQDGqkdutnrISCUNVJbtSGFda6UsVphoc?=
 =?us-ascii?Q?6EsoEFHrTHGoNWp3NOyDJWkzrdCBECyKS5RcUBF3SXHpjKYyTEFKmq2Wsc6E?=
 =?us-ascii?Q?lMBlZwLAcIlnt5hz84xvFEQqjAzqr1ql1IKob4nRNpNU1dHEj/FvbYU7LXZ6?=
 =?us-ascii?Q?DRhhB7F5kmqp0Y9F7Ezor647qe4ivTIXWJwSracNZTZ5cj7PsB8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c887081-d43d-43c0-c9d1-08dad70f5c53
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2022 22:23:40.0603
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oJmUeq8ZIiEeGd4CdgiTWT/QGmWfEpsp5R/v0SvHPYyU0J7FzDS6+AvWw25kOks+OJF8zLfWgz+dN4fXUTr7wQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4632
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-05_01,2022-12-05_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 mlxscore=0
 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2212050185
X-Proofpoint-ORIG-GUID: DnN8UapDRJ_G3FfN-M8inNoNdbJsSGow
X-Proofpoint-GUID: DnN8UapDRJ_G3FfN-M8inNoNdbJsSGow
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/29/22 14:35, Peter Xu wrote:
> We can take the hugetlb walker lock, here taking vma lock directly.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  fs/userfaultfd.c | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)

Looks good.

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz