Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 5 Dec 2022 14:29:43 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Peter Xu <peterx@redhat.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        James Houghton <jthoughton@google.com>,
        Jann Horn <jannh@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Rik van Riel <riel@surriel.com>,
        Nadav Amit <nadav.amit@gmail.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Muchun Song <songmuchun@bytedance.com>,
        David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH 06/10] mm/hugetlb: Make hugetlb_follow_page_mask() safe
 to pmd unshare
Message-ID: <Y45w13WvB9K/G9qn@monkey>
References: <20221129193526.3588187-1-peterx@redhat.com>
 <20221129193526.3588187-7-peterx@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221129193526.3588187-7-peterx@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YgCb7CwxGytbZ+X4OqiQsM569G/z2W4aHvC13/drIp77YQHhkgmcUHi+ECyG?=
 =?us-ascii?Q?hxB3Saew0HWIREtI6sbkP2vY9s2rozcBZJHz839DyXdI1Shk1siJLr6FmAPk?=
 =?us-ascii?Q?a9Kz46iTPDFnldwqqmda35dYztflK3KSvkQ3Vue01IkiZU9RJOKvg1JOnTDA?=
 =?us-ascii?Q?L0IoD9B0Ibex9iajkXqq4u/Tsx4LLrYvVgsNNfbdW1YOGNON7i/aeBjZc54b?=
 =?us-ascii?Q?4Y6EXFzB/BmB5B0gscQ3cyvT3DYPebJ9wbtYu4vkqVctbm6FK5U6Fg4TJ89R?=
 =?us-ascii?Q?/Oz03N28bLE/v1mdWc6EPyNigHGPCPGgjlLBTsSAu+xPSjiRz7Nvvxp2h2ew?=
 =?us-ascii?Q?nYHLedO6ByyWq7mcp4LAxfB+MCNPr5Q/KNa8/YCaziLYo+N1j4XDEVe4XGZW?=
 =?us-ascii?Q?rVuAE+UlyYUvtlLLIduXDnkf/u7uDjv2VZw1OBtEFf22blpVIRpHvozvVba0?=
 =?us-ascii?Q?aSmwm3t6/GgIWEuYrIb76Tu2ISQboxxBTOXmOkXfYNid5hjFIbVVtIv2RgS4?=
 =?us-ascii?Q?+TX5ZaGO3TylQxL+NmIUtGGFBT0O5eXTp9CEd4TSwRR3PKXjJ3ixPBEohuq4?=
 =?us-ascii?Q?SY9LbX97IWxV/4D8A6AsYw6KJGRi52n+8pd1AuCCMG1UjuJdBI1+yWTMSdqK?=
 =?us-ascii?Q?vs6mXh9y20PDTozTtL6OtdCg9AWSLD1zmvuhu88VFoYpnjKZ5L0kwrHghXvj?=
 =?us-ascii?Q?GllMk/yzzcFoiNSiufes2agNNPhsZMmg5e9jILzkNy6Rbg4V2idCfzFLHnEm?=
 =?us-ascii?Q?wzFbA7libnRqP4GN0+8eyLz5IevxffeGxxLW0tY+NXx31Zwq+OcqICw495Sb?=
 =?us-ascii?Q?trNLSa8Sd84QpfDQrRkGBGe2AHtMv0vQRaDi+sK/T9RQdGuO7T01ZMmXdeNQ?=
 =?us-ascii?Q?u8ap2MnVhWfy0AUnGjWVjchuv1LywgpWW5+EIjqcs4TiypNfgVX88ia+3ZRp?=
 =?us-ascii?Q?pBuyxhCDYR6tFmKs76+e4h8r/Ad/h49U5JSkIrmMEk2iSdmXnwhsOW0QQZ54?=
 =?us-ascii?Q?NTXtR1j1tNz4c8TUUNVHNRR4BDsIHiG8hES7mp65dXirpyOEEpz1mKVfb66q?=
 =?us-ascii?Q?LuUiz35yOK01VEBYIhD7yAwDtoBFskukA9U4f/Uo0tsl5kHOAAziAakLdZ0B?=
 =?us-ascii?Q?hGFDrUDHrDsUKgoYwkpqBO800M9ssi/ZPzlsCTE+68RiIOEi22rRq3En4fUn?=
 =?us-ascii?Q?su5nJ7JRG0MhMnop1WIo0HXAJXgh+KgOZPCnxak0d6uH3iWdE0eH0Bazcrw9?=
 =?us-ascii?Q?TJOcF3c9Kur4/Z3bx9J1Qy9IOxoNaXPjYniZ4EoO0Uvt0aI1Ds5/Yfk1w3nN?=
 =?us-ascii?Q?n0BzSKG9I3IKXybwbYgU+cx7ICo5ERX+w2ChiK2irloYHDSQDc9sNcGUa79R?=
 =?us-ascii?Q?Ktin/W2Z+iQJFgrdiX3yS141bhZlvCbIccZmj0et83b77lKrbMlgjC91OJZt?=
 =?us-ascii?Q?KxrDELKqDmtXXZUmrN3NHauEwkgoSGYl4VNqjxdnvolU1Br3FBrljHEBQV2F?=
 =?us-ascii?Q?XcA3AkvqoxRh73esM6oyvxEovqgNBGrKuZpwUf1Pn62RL1cWRVwMsrgulMB3?=
 =?us-ascii?Q?YszezuLv0Z2KG2GWg+vFfis7t+3haBfOgg8bJqCvhqywHH4sBcFdj29XUuO1?=
 =?us-ascii?Q?TA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?fkMHDMYNNV6i0G2pbZKObvlXCJbQ8Q4w6oRLYa/PdWb9wPVQfYyTh8p6vvnF?=
 =?us-ascii?Q?e73BKul6cWuEiV/nmOor/AKxc13PUjycI6Xo44MyCbba656BXkPHVXyKu6PM?=
 =?us-ascii?Q?UjjVpem2xUdLX0YNldzlCHRC+9Phtc+9xP+vyXa0SntAXsZyJI7grdjtuG+M?=
 =?us-ascii?Q?++ZojOicSOZnCsLxy2lJRZXfIdi5039kK/m3VH+oYUiv4IPLRVU5NShjTBi1?=
 =?us-ascii?Q?mJUSZE1woosZCmM/H7nfL+3GTDrUIFr8FOAn+l3EgJzbn2CLMSyLeL5U4Mqv?=
 =?us-ascii?Q?+wnnvYvL0C9TcHqQ/nbVM11WuAMyBFoeifmtXa+v5o6mK03eN//YxcoVrBFa?=
 =?us-ascii?Q?GD/6NCE/wX31zuguUrGb3P8P5w3a/AI9C5NJs+K9UHPGTXmhrjHKZCF6wDl2?=
 =?us-ascii?Q?vkb/g1+3bzmahaw65Zcpz4TQuyZwbiL2usuj9yRuttNqzVX6qakqP74Lm6rJ?=
 =?us-ascii?Q?ZhfX1qph3AXEOSS1NiV2I1vhTDDEK0B3dBx0KkJy7v3Ij7lvfCMfc+H22bas?=
 =?us-ascii?Q?/wn3+Id9GovviLZjGGCT2/XU5iGmFEd0H8LT6dmAoZL+vU+Zid26nNiOtIq7?=
 =?us-ascii?Q?2bThzySYp7dxew1JCvkdbeUa6Q+/9MQ0mLZh5QUOPHLVDlsgysOqNV/ruIPB?=
 =?us-ascii?Q?3AgNVX7HbudJbuqiqRUm1uioPRyDjMOmqj7DxYw0zl1XnQ29S/fXJEoFpOJa?=
 =?us-ascii?Q?E1SUC/6JDupxlvVjvruXkuM/vUvQJrXoJv0MC5JujqDbu419fna+HhEY2h4C?=
 =?us-ascii?Q?ffzizg8K1PqrceNDu/mQEaXAviRVTiAc18zOO8XO+TWIODCkW7al0dNufEW6?=
 =?us-ascii?Q?smLlD4qmxFFM7lB5CcZu1GDXCxGA6O6QnylQJsENVVHuUOFfxvHJ2mLdM3t5?=
 =?us-ascii?Q?ICZlxidzn78g9vk7GMruq0nm7rgWlnQxpznb2dmXXdRl9lfraQfxtNqWC2bM?=
 =?us-ascii?Q?fVav6O9Gx/845tx5VQx/DpPlcSVFObLNyKnn9p753hrherbTpmZ5WTTALym1?=
 =?us-ascii?Q?ObUu0ck5gNzj4tBti7hejc+W6hsF4z+a1yKVH+Ipp0tJSaQHPX3ipPHzjT9r?=
 =?us-ascii?Q?N9mcjsVvCGik0JTCt4as+SI8AXJ3puH+fNXFmPIkxbHxATXOmcA=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52ccdd45-7116-4cb4-73cb-08dad71036a9
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2022 22:29:46.3963
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F+IIqOjmyAsV4JL29rqT3NrRdB6lPvs19ZfHnQZXCL54wqPXK6FymhzrVzzxIGFZ9AHa4lrfuA8jNGjb5hiNNg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6778
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-05_01,2022-12-05_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 bulkscore=0
 mlxlogscore=999 malwarescore=0 suspectscore=0 spamscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2212050186
X-Proofpoint-ORIG-GUID: ntkJ3Lc0BsmWLiPhPemwccvJpvMUGY6-
X-Proofpoint-GUID: ntkJ3Lc0BsmWLiPhPemwccvJpvMUGY6-
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/29/22 14:35, Peter Xu wrote:
> Since hugetlb_follow_page_mask() walks the pgtable, it needs the vma lock
> to make sure the pgtable page will not be freed concurrently.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  mm/hugetlb.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Thanks!

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

-- 
Mike Kravetz