Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <44140361-33c3-ff97-b28f-64c26bf87d5c@igalia.com>
Date:   Mon, 5 Dec 2022 21:37:26 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v2 1/2] drm/v3d: cleanup BOs properly when lookup_bos
 fails
To:     Melissa Wen <mwen@igalia.com>, emma@anholt.net, airlied@gmail.com,
        daniel@ffwll.ch
Cc:     Thomas Zimmermann <tzimmermann@suse.de>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        kernel-dev@igalia.com
References: <20221205135538.3545051-1-mwen@igalia.com>
 <20221205135538.3545051-2-mwen@igalia.com>
Content-Language: en-US
From:   =?UTF-8?Q?Ma=c3=adra_Canal?= <mcanal@igalia.com>
In-Reply-To: <20221205135538.3545051-2-mwen@igalia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 12/5/22 10:55, Melissa Wen wrote:
> When v3d_lookup_bos fails to `allocate validated BO pointers`,
> job->bo_count was already set to args->bo_count, but job->bo points to
> NULL. In this scenario, we must verify that job->bo is not NULL before
> iterating on it to proper clean up a job. Also, drm_gem_object_put
> already checks that the object passed is not NULL, doing the job->bo[i]
> checker redundant.
> 
> Signed-off-by: Melissa Wen <mwen@igalia.com>

Reviewed-by: Maíra Canal <mcanal@igalia.com>

Best Regards,
- Maíra Canal

> ---
>  drivers/gpu/drm/v3d/v3d_gem.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
> index 96af1cb5202a..31a37572c11d 100644
> --- a/drivers/gpu/drm/v3d/v3d_gem.c
> +++ b/drivers/gpu/drm/v3d/v3d_gem.c
> @@ -363,11 +363,11 @@ v3d_job_free(struct kref *ref)
>  	struct v3d_job *job = container_of(ref, struct v3d_job, refcount);
>  	int i;
>  
> -	for (i = 0; i < job->bo_count; i++) {
> -		if (job->bo[i])
> +	if (job->bo) {
> +		for (i = 0; i < job->bo_count; i++)
>  			drm_gem_object_put(job->bo[i]);
> +		kvfree(job->bo);
>  	}
> -	kvfree(job->bo);
>  
>  	dma_fence_put(job->irq_fence);
>  	dma_fence_put(job->done_fence);