Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d75ca7a3de87fb211a216de169e4394e79a82a7d.camel@perches.com>
Subject: Re: Fw: [PATCH 0/2] feat: checkpatch: prohibit Buglink: and warn
 about missing Link:
From:   Joe Perches <joe@perches.com>
To:     Andrew Morton <akpm@linux-foundation.org>,
        Kai =?ISO-8859-1?Q?Wasserb=E4ch?= <kai@dev.carbon-project.org>
Cc:     Thorsten Leemhuis <linux@leemhuis.info>,
        LKML <linux-kernel@vger.kernel.org>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>
Date:   Mon, 05 Dec 2022 17:19:58 -0800
In-Reply-To: <11a9fe60f5333a931b8d75f67808b6d923c16dfa.camel@perches.com>
References: <20221205131424.36909375d90d5a40cd028bc0@linux-foundation.org>
         <11a9fe60f5333a931b8d75f67808b6d923c16dfa.camel@perches.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-12-05 at 17:02 -0800, Joe Perches wrote:
> On Mon, 2022-12-05 at 13:14 -0800, Andrew Morton wrote:
> > Date: Sun,  4 Dec 2022 12:33:37 +0100
> > From: Kai Wasserb?ch <kai@dev.carbon-project.org>
[]
> > - checkpatch implements custum versions of Perl core modules, that might
> >   be an future area for clean-ups? Eg. right off the bat there is a
> >   `uniq` implementation. List::Util (core module since 5.8.0 (5.7.3 to
> >   be pedantic)) has a far better performing version in XS.

> Maybe.  I don't know there are that many generic functions
> that could be used.  You are welcome find some.

uniq isn't used in checkpatch since

commit 52178ce01335d9d76611c3a5198b8778cb9b03f5
Author: Dwaipayan Ray <dwaipayanray1@gmail.com>
Date:   Fri Feb 26 15:08:26 2021 +0530

    checkpatch: add verbose mode
 
and could be removed.