Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221204084844.3573800-1-badhri@google.com> <20221204084844.3573800-3-badhri@google.com>
 <Y4xrpgCTqV4yAplp@kroah.com> <20221204155724.GA1862600@roeck-us.net>
In-Reply-To: <20221204155724.GA1862600@roeck-us.net>
From:   Badhri Jagan Sridharan <badhri@google.com>
Date:   Mon, 5 Dec 2022 17:33:15 -0800
Message-ID: <CAPTae5KvmBXJrYByttNz4mmubfP9M_jAJh8Gx=5hgn2PajBuVg@mail.gmail.com>
Subject: Re: [PATCH v3 3/3] usb: typec: maxim_contaminant: Implement
 check_contaminant callback
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Kyle Tso <kyletso@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Fixing both the comments in version 4 of the patchset. Thanks !

On Sun, Dec 4, 2022 at 7:57 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Sun, Dec 04, 2022 at 10:43:02AM +0100, Greg Kroah-Hartman wrote:
> > On Sun, Dec 04, 2022 at 12:48:44AM -0800, Badhri Jagan Sridharan wrote:
> > > +EXPORT_SYMBOL_GPL(is_contaminant);
> >
> > Sorry, but this is a horrible name for the kernel global namespace.
> > Please properly prefix it to show exactly what subsystem this is from.
> >
>
> I don't think this needs to be exported either.
>
> Guenter