Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Divya.Koppera@microchip.com>
To:     <andrew@lunn.ch>
CC:     <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <richardcochran@gmail.com>,
        <UNGLinuxDriver@microchip.com>, <Madhuri.Sripada@microchip.com>
Subject: RE: [PATCH v4 net-next 2/2] net: phy: micrel: Fix warn: passing zero
 to PTR_ERR
Thread-Topic: [PATCH v4 net-next 2/2] net: phy: micrel: Fix warn: passing zero
 to PTR_ERR
Thread-Index: AQHZCJVv3bBjy+j6lE2XjF4N4A7sva5fTaGAgADtbyA=
Date:   Tue, 6 Dec 2022 03:54:57 +0000
Message-ID: <CO1PR11MB477119863F77DCC9198D0947E21B9@CO1PR11MB4771.namprd11.prod.outlook.com>
References: <20221205103550.24944-1-Divya.Koppera@microchip.com>
 <20221205103550.24944-3-Divya.Koppera@microchip.com>
 <Y431PXknftwxwX3f@lunn.ch>
In-Reply-To: <Y431PXknftwxwX3f@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jM/5aqQ3YK1/PTOCKk4jQ6nNngVdW2AeT76RSMhxH6yEcGvLCb83NbwFmcR1?=
 =?us-ascii?Q?lZ81IDZVAG1SCWfppWS6XJXN/7irRdsw9J6Ihm19YZs8mahhlleUtwH28iYJ?=
 =?us-ascii?Q?Sfk3BUI7L1uhDIUwtdeMH45foRi5qV4hBbIDqaI+pd82qGNjA9yIUmA/HcF9?=
 =?us-ascii?Q?rpqnBXqtPZec48sLROU63jTI6OgLR6vcRPajw54ifpSTN0gT1eVz6tb3aNbM?=
 =?us-ascii?Q?Cx+f0dDmEZcTLnWb+ZeZlpD2o3ssOtmH9iX8/OJ9GJgg/Xk6TwJUnzZVQZim?=
 =?us-ascii?Q?jo+i/rFzLuVNpJcq1LDZfh+AkuOx0QuZ7z/a2QjQ7CSm/yG+FrwdrfX4q1oR?=
 =?us-ascii?Q?up475I7pR7g8onL3LWc0xWhPexNPzauB8WjZKvK8CguYp0fkdCLGKOsXfHe4?=
 =?us-ascii?Q?NpKaFKBM1kBgsG+4ZaXGnat28xLeMBUlhN2wzQRYLhC3VveStbRFKS6m89oz?=
 =?us-ascii?Q?WH0fjnoEn6TP8748eo2dOT0Kn/q88+GtlT+ou8uWv/TI8k+xZEbyLEPwYzGU?=
 =?us-ascii?Q?uYiNyrO9iWGhAULF8vph2/9j4DA/IVbpKAtdF7Zqg75IYl0A++KeOkco3qD0?=
 =?us-ascii?Q?HOQC4BBp6ww+tfZh6D1XF9krH02s22xCkqFaodFPJMPy1/10AtkBUiJFeqYA?=
 =?us-ascii?Q?EW+5BS503GkE3INs4rjbc7Wi14ICtvgAcwEJTbafH7JtoTTyEzBCFsZ/do03?=
 =?us-ascii?Q?HAjbWr9MiFsw1eMlmpErK9X7dtgL4lt8o5cnXsm+Q9pIsL7XA6GNW2pIVnB0?=
 =?us-ascii?Q?Z2U3zvcUiYJgD4pvD2JJ4x8kbJFJPpelfKWXpBazjwWt9DMCRUbBD71WKfFD?=
 =?us-ascii?Q?u0tOTd+IEtmnXHhJKpq7az/K9JsrcX2m2Y+pnUgdbEfJRjpMmGSiG0zNUuiZ?=
 =?us-ascii?Q?VmQkhC4xwmfBWm09RojdBRUMIfed2E2fyi9tSTy1rWOJ3GVQ5noDUTtkXUEt?=
 =?us-ascii?Q?54xPiQFSoA87ESfHN1XrIKW2iry3/iSbMZmAvk9/eGRwywCYSZuaViq9NgTX?=
 =?us-ascii?Q?kbZb7k4azQKMO1L73ZAzs1NbofV7q4AZYuc3TUtBlzvdirNgXFGPSGgCy7Yb?=
 =?us-ascii?Q?38SaO79HluxF8fER5CeFXYunZKzf2fwDz47UpRdJ5HkxbVr6L9WEoL7jnCdN?=
 =?us-ascii?Q?PJU1z2RNPzXMq2wlDCzF7uDFHYHgZDdjgl/cYSF74QDLQaMC7sptbdvt/zo6?=
 =?us-ascii?Q?snDUiguht5tXn13tEctG/7TzdAAByabuTn+FF9V4OhzWHVEsBs2cRuKy+pic?=
 =?us-ascii?Q?dSsTd24bzFJQ4OIlZexFdz+OVwK73rveI7/24Ey3DLc/TYnBwA/kklvX2Lx8?=
 =?us-ascii?Q?bzDrU3MMhrr2VYwRi/+j86PSVoYpFpyu9jvAQ/+2f94sF7M9upAqxNEDOXLd?=
 =?us-ascii?Q?eJP9lF3y8Q/Do0ZG9O6BtE12t+aM6xgS2Xirado2G5Udxex99hFeqa2fasYz?=
 =?us-ascii?Q?ofN5jqjxho6Ne5HHL+xcgWou3lbu4tQ751/AYLZ5dxx3LX6en6ARvsD5NbgY?=
 =?us-ascii?Q?augQQUlEqYeC45xeSGnd5DqZbw2rAzTdoRTi4gx4OemXWv92vbhMjzZpRvWv?=
 =?us-ascii?Q?5m7BP/FblsOiVb5cVPNfJSb0WPx8AKOz3n5FDSnLrvwQ+vkjitEZJHmApmZD?=
 =?us-ascii?Q?Bw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4771.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 733d7e8a-c97e-4658-08e0-08dad73da40d
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2022 03:54:57.1016
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Oy7adR9Gnv0ZVEVA0OtP7Ju0s3OvWYwGxK0rqPMtB0l5r2/n2Y4h4z48d4ynaQWxpO2DTrqqifRz9HiU4Rg4ij8kauRXmbYNiF1bnud7DHs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7819
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Monday, December 5, 2022 7:12 PM
> To: Divya Koppera - I30481 <Divya.Koppera@microchip.com>
> Cc: hkallweit1@gmail.com; linux@armlinux.org.uk; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> richardcochran@gmail.com; UNGLinuxDriver
> <UNGLinuxDriver@microchip.com>; Madhuri Sripada - I34878
> <Madhuri.Sripada@microchip.com>
> Subject: Re: [PATCH v4 net-next 2/2] net: phy: micrel: Fix warn: passing =
zero
> to PTR_ERR
>=20
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> On Mon, Dec 05, 2022 at 04:05:50PM +0530, Divya Koppera wrote:
> > Handle the NULL pointer case
> >
> > Fixes New smatch warnings:
> > drivers/net/phy/micrel.c:2613 lan8814_ptp_probe_once() warn: passing
> zero to 'PTR_ERR'
> >
> > vim +/PTR_ERR +2613 drivers/net/phy/micrel.c
> > Reported-by: kernel test robot <lkp@intel.com>
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Fixes: ece19502834d ("net: phy: micrel: 1588 support for LAN8814 phy")
> > Signed-off-by: Divya Koppera <Divya.Koppera@microchip.com>
> > ---
> > v3 -> v4:
> > - Split the patch for different warnings
> > - Renamed variable from shared_priv to shared.
> >
> > v2 -> v3:
> > - Changed subject line from net to net-next
> > - Removed config check for ptp and clock configuration
> >   instead added null check for ptp_clock
> > - Fixed one more warning related to initialisaton.
> >
> > v1 -> v2:
> > - Handled NULL pointer case
> > - Changed subject line with net-next to net
> > ---
> >  drivers/net/phy/micrel.c | 15 ++++++++-------
> >  1 file changed, 8 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index
> > 1bcdb828db56..0399f3830700 100644
> > --- a/drivers/net/phy/micrel.c
> > +++ b/drivers/net/phy/micrel.c
> > @@ -2971,12 +2971,13 @@ static int lan8814_config_intr(struct
> > phy_device *phydev)
> >
> >  static void lan8814_ptp_init(struct phy_device *phydev)  {
> > +     struct lan8814_shared_priv *shared =3D phydev->shared->priv;
> >       struct kszphy_priv *priv =3D phydev->priv;
> >       struct kszphy_ptp_priv *ptp_priv =3D &priv->ptp_priv;
> >       u32 temp;
> >
> > -     if (!IS_ENABLED(CONFIG_PTP_1588_CLOCK) ||
> > -         !IS_ENABLED(CONFIG_NETWORK_PHY_TIMESTAMPING))
> > +     /* Check if PHC support is missing at the configuration level */
> > +     if (!shared->ptp_clock)
> >               return;
>=20
> Can you somehow keep the IS_ENABLED() ? It gets evaluated at compile time=
.
> The optimizer can see the function will always return here, and all the c=
ode
> that follows is pointless, and so remove it. By turning this into a runti=
me test,
> you have made the image bigger.
>=20

Thanks, will change this.

>      Andrew
/Divya