Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Dec 2022 11:29:28 +0530
From:   Kanchan Joshi <joshi.k@samsung.com>
To:     Christoph Hellwig <hch@lst.de>
Cc:     August Wikerfors <git@augustwikerfors.se>,
        Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
        Sagi Grimberg <sagi@grimberg.me>,
        linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM9B1
 256G and 512G
Message-ID: <20221206055928.GB24451@test-zns>
MIME-Version: 1.0
In-Reply-To: <20221117031951.GB392@test-zns>
User-Agent: Mutt/1.9.4 (2018-02-28)
Content-Type: multipart/mixed;
        boundary="----vu1s6p.wgdQE3gZrnomxJkzeTvd9c8sIFt7LU8e8l4OokKPH=_1070a_"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20221116171727.4083-1-git@augustwikerfors.se>
        <CGME20221116172324epcas5p3d9877249797ac741ead5785cba27e00e@epcas5p3.samsung.com>
        <20221116171935.GA24524@lst.de> <20221117031951.GB392@test-zns>
Precedence: bulk

------vu1s6p.wgdQE3gZrnomxJkzeTvd9c8sIFt7LU8e8l4OokKPH=_1070a_
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Disposition: inline

On Thu, Nov 17, 2022 at 08:49:51AM +0530, Kanchan Joshi wrote:
>On Wed, Nov 16, 2022 at 06:19:35PM +0100, Christoph Hellwig wrote:
>>On Wed, Nov 16, 2022 at 06:17:27PM +0100, August Wikerfors wrote:
>>>The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop units
>>>reports eui as 0001000200030004 when resuming from s2idle, causing the
>>>device to be removed with this error in dmesg:
>>>
>>>nvme nvme0: identifiers changed for nsid 1
>>
>>What EUI did it report before? Is the identifier stable after
>>multiple resume cycles?
>>
>>Can some of the Samsung folks here reach out to the relevant firmware
>>team to see if they have any clues?
>
>I will check.

Took more time than I wanted. Firmware team mentioned that issue existed
in this firmware. This is fixed in new firmware, but bit of travel time
is involved when official release from OEM (Lenovo) comes out.

Hope the information is sufficient, and quirk can go in.

If required, 
Acked-by: Kanchan Joshi <joshi.k@samsung.com>

------vu1s6p.wgdQE3gZrnomxJkzeTvd9c8sIFt7LU8e8l4OokKPH=_1070a_
Content-Type: text/plain; charset="utf-8"


------vu1s6p.wgdQE3gZrnomxJkzeTvd9c8sIFt7LU8e8l4OokKPH=_1070a_--