Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d33354c9-810e-0577-86b5-20552718f8a0@linux.ibm.com>
Date:   Tue, 6 Dec 2022 07:20:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH] cxl: Remove unnecessary cxl_pci_window_alignment()
To:     Bjorn Helgaas <helgaas@kernel.org>,
        Andrew Donnellan <ajd@linux.ibm.com>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nicholas Piggin <npiggin@gmail.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
References: <20221205223231.1268085-1-helgaas@kernel.org>
Content-Language: en-US
From:   Frederic Barrat <fbarrat@linux.ibm.com>
In-Reply-To: <20221205223231.1268085-1-helgaas@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 05/12/2022 23:32, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> cxl_pci_window_alignment() is referenced only via the struct
> pci_controller_ops.window_alignment function pointer, and only in the
> powerpc implementation of pcibios_window_alignment().
> 
> pcibios_window_alignment() defaults to returning 1 if the function pointer
> is NULL, which is the same was what cxl_pci_window_alignment() does.
> 
> cxl_pci_window_alignment() is unnecessary, so remove it.  No functional
> change intended.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---


Thanks!
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>

   Fred


>   drivers/misc/cxl/vphb.c | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/misc/cxl/vphb.c b/drivers/misc/cxl/vphb.c
> index 1264253cc07b..6332db8044bd 100644
> --- a/drivers/misc/cxl/vphb.c
> +++ b/drivers/misc/cxl/vphb.c
> @@ -67,12 +67,6 @@ static void cxl_pci_disable_device(struct pci_dev *dev)
>   	}
>   }
>   
> -static resource_size_t cxl_pci_window_alignment(struct pci_bus *bus,
> -						unsigned long type)
> -{
> -	return 1;
> -}
> -
>   static void cxl_pci_reset_secondary_bus(struct pci_dev *dev)
>   {
>   	/* Should we do an AFU reset here ? */
> @@ -200,7 +194,6 @@ static struct pci_controller_ops cxl_pci_controller_ops =
>   	.enable_device_hook = cxl_pci_enable_device_hook,
>   	.disable_device = cxl_pci_disable_device,
>   	.release_device = cxl_pci_disable_device,
> -	.window_alignment = cxl_pci_window_alignment,
>   	.reset_secondary_bus = cxl_pci_reset_secondary_bus,
>   	.setup_msi_irqs = cxl_setup_msi_irqs,
>   	.teardown_msi_irqs = cxl_teardown_msi_irqs,