Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Divya.Koppera@microchip.com>
To:     <andrew@lunn.ch>
CC:     <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <richardcochran@gmail.com>,
        <UNGLinuxDriver@microchip.com>, <Madhuri.Sripada@microchip.com>
Subject: RE: [PATCH v4 net-next 1/2] net: phy: micrel: Fixed error related to
 uninitialized symbol ret
Thread-Topic: [PATCH v4 net-next 1/2] net: phy: micrel: Fixed error related to
 uninitialized symbol ret
Thread-Index: AQHZCJVqIZPw2JVcBkmfFVdUaVU49q5fTBiAgAEsSUA=
Date:   Tue, 6 Dec 2022 07:32:31 +0000
Message-ID: <CO1PR11MB4771E12DCF6D65E568627489E21B9@CO1PR11MB4771.namprd11.prod.outlook.com>
References: <20221205103550.24944-1-Divya.Koppera@microchip.com>
 <20221205103550.24944-2-Divya.Koppera@microchip.com>
 <Y43z8+grm/TM3ype@lunn.ch>
In-Reply-To: <Y43z8+grm/TM3ype@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?T0NxXy2eQzWHBAB44DfgvYE0VM/PV+4akSUnuuyUOZ2UWsGZUUAnGlWCdIjw?=
 =?us-ascii?Q?hUPaYU9lx+8f8yp0QXTCXBJ0GiU6HihoRzJzuvMDdDI3Qpu4zvc3HTaPKr84?=
 =?us-ascii?Q?YM79sYPS+LAt9jmaShZygWEedqM5ri5DtrynsQRmD9bgwjAe4LHvsgKj8fbl?=
 =?us-ascii?Q?N7QnsSt6mUoH+S3yL+vZSELfRq+7aT8WtZOYOHN3JgLh7keONkmN0RxydcHb?=
 =?us-ascii?Q?HVfHxHZqrV+e6KLa4GQBmCiKIijOfk1M+yWs/MI212QPkbmFrSyzuRNZzLbh?=
 =?us-ascii?Q?fCmeD6lPMAfEtUlYQVkX4zRBuREF5OvwAswcFvdIslvau8iG6APoLv7k9KUh?=
 =?us-ascii?Q?rmkvON1+coKhpYNv5FlvjwA0fjJ0vC/W4Qb5mezsf5vVT8XBlrQzfF9HgqCr?=
 =?us-ascii?Q?2IwK4QS9H5S84/Rw4SzzA7B0lzScSNpe0TVepHpvK6uXBjQFekxSF3vvwNqF?=
 =?us-ascii?Q?I58IMdsouNxeTqakT89MB1dbZZTVLq1V3RVnSLhwtRP/1rTaP4kgMBWG3571?=
 =?us-ascii?Q?17KvJnBHVEIJPLGMzthkl43cPvKSxXf6fvT2BTaPqkUoHX36HO6reopYNuQx?=
 =?us-ascii?Q?I81VjvwuOR5mPiIPEJqFwaZ0mprWuYjEWyFii0/uW2LNiUibNj/yQI4mx6xF?=
 =?us-ascii?Q?lhnA07eEm0kMnoUFIXkT86SeEUq0vtmZpIH4aq9PlkiEmlYKsTg9NBBmkTXh?=
 =?us-ascii?Q?aQ25wiQcQz/uIv9eyJvcMM2GVrI+3zyfC5EWAusVWMxukH8mzgwz6dZemyDD?=
 =?us-ascii?Q?yju8EkyJWmEjlRDBztGLZalx4GtsBe8cBThWltKV6RXN4OxGje7pTmQ35iL7?=
 =?us-ascii?Q?IChwVfeFEipafRzeDmHcpYP0OhXhJvBAqiAdDuW7s/wpyxQrfd++ZreJ75q4?=
 =?us-ascii?Q?PMIqgMhkb4dvTMV+XbH4rB01zBook5/2hIerw7IpiwjzsNcybJkBw24FDhf/?=
 =?us-ascii?Q?Scq+S3qNXYBwLAip9K8Bt2xlo+Zge/COEld72pMnqQiDkYSGOA97Nb37O2fl?=
 =?us-ascii?Q?6w6zh/QoABOhh7VCiORYnJTnptUUrYMnjCT2LiYxLkkcMdma/Nyt7uPgSRFF?=
 =?us-ascii?Q?hTgJIUn2INOV9pJtpT8lCMXFPFOBC4u//pUKdngEIs15ITY/xKVKXE6QXkAq?=
 =?us-ascii?Q?PVHojaDnLwM4pUBZW8zVmDs0gIe9YEB/9jpcYkRPlIDDy6aFloJLLoI/rMcv?=
 =?us-ascii?Q?ChhmwMK/r2LDoyA1VqkRUhXJDhNsjk8s2+rEAkn82oA2DUbRjo6wWsiH0Bd6?=
 =?us-ascii?Q?Nwc25d044HIYrvj4AQhcD+Um6i0JZ4u0cgluREGg7P98ZjfCNWRbzyDvyTFI?=
 =?us-ascii?Q?+GH8ILTyEs/C15aNzdfl/ThUQNST6wGKQSmPKyhcNQOtVVltaU/TK96jRfsz?=
 =?us-ascii?Q?t0dCClDJ9Tdz0U7PLZcbgRMkfYy9DeIp4Tl9GUYIfrGa9zGbiXi1olP0PTUm?=
 =?us-ascii?Q?COiY5HUvj/jfneYSFGwHtO+tEPYdF4/+JUcNU/r+8SGK7DNpra69fD3EQHT6?=
 =?us-ascii?Q?XX1OS4wg26tahboVTGB8sJjit5b1OgV8PJyAHYSwISaJoWyXx2LOqW6udyuT?=
 =?us-ascii?Q?MpKHOIxtkVXvCJYf8jTkZw+09Fiv+j3SASgJfzAUEuSR+7BntSAUwJfYRXuN?=
 =?us-ascii?Q?mA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4771.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff544ad5-184e-4ca9-d3ce-08dad75c0907
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2022 07:32:31.4192
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xd1+1IJPsJUwj/yHNenOYhfmNRJumOjufcVtIZQrKt5RGqO2KeBtWrXrEPo4UFKQquLt+TdE8Q3sO4HOTeLCdeiFMV16sJHccnAYRHc5cOA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7328
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Monday, December 5, 2022 7:07 PM
> To: Divya Koppera - I30481 <Divya.Koppera@microchip.com>
> Cc: hkallweit1@gmail.com; linux@armlinux.org.uk; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> richardcochran@gmail.com; UNGLinuxDriver
> <UNGLinuxDriver@microchip.com>; Madhuri Sripada - I34878
> <Madhuri.Sripada@microchip.com>
> Subject: Re: [PATCH v4 net-next 1/2] net: phy: micrel: Fixed error relate=
d to
> uninitialized symbol ret
>=20
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> On Mon, Dec 05, 2022 at 04:05:49PM +0530, Divya Koppera wrote:
> > Initialized return variable
> >
> > Fixes Old smatch warnings:
> > drivers/net/phy/micrel.c:1750 ksz886x_cable_test_get_status() error:
> > uninitialized symbol 'ret'.
>=20
> I guess this patch has been rebased without the smatch warning being
> changed because line 1750 in net-next/main is a blank line between two
> functions.
>=20

Yes, rebased without fix.

> > Reported-by: kernel test robot <lkp@intel.com>
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Fixes: 21b688dabecb ("net: phy: micrel: Cable Diag feature for lan8814
> > phy")
> > Signed-off-by: Divya Koppera <Divya.Koppera@microchip.com>
>=20
> So once i looked in the correct place:
>=20
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>=20
>     Andrew