Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S973711AbXHMRrz (ORCPT ); Mon, 13 Aug 2007 13:47:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S974012AbXHMRnb (ORCPT ); Mon, 13 Aug 2007 13:43:31 -0400 Received: from coyote.holtmann.net ([217.160.111.169]:42425 "EHLO mail.holtmann.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S974011AbXHMRn3 (ORCPT ); Mon, 13 Aug 2007 13:43:29 -0400 Subject: Re: [PATCH] Firmware class name collision From: Marcel Holtmann To: Markus Rechberger Cc: linux-kernel@vger.kernel.org, Jean Delvare , Greg KH In-Reply-To: <46C092EB.1070501@amd.com> References: <46C05896.4050509@amd.com> <1187025047.6698.219.camel@violet> <46C092EB.1070501@amd.com> Content-Type: text/plain Date: Mon, 13 Aug 2007 19:45:38 +0200 Message-Id: <1187027138.6698.239.camel@violet> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1626 Lines: 50 Hi Markus, > >> following patch fixes the i2c name collision with i2c-dev. > >> > >> http://mcentral.de/wiki/index.php/Bugtracker#i2c_core_problem > >> > >> This issue has been experienced with em28xx and saa7133 based devices. > >> I discussed that problem with Jean Delvare a while ago and he proposed > >> to add a prefix to the class name. > >> > >> http://mcentral.de/~mrec/patches/firmware_class_name_collision.diff > >> > >> Signed-off-by: Markus Rechberger > >> > >> index b24efd4..bfc54a1 100644 > >> --- a/drivers/base/firmware_class.c > >> +++ b/drivers/base/firmware_class.c > >> @@ -297,8 +297,7 @@ firmware_class_timeout(u_long data) > >> > >> static inline void fw_setup_device_id(struct device *f_dev, struct > >> device *dev) > >> { > >> - /* XXX warning we should watch out for name collisions */ > >> - strlcpy(f_dev->bus_id, dev->bus_id, BUS_ID_SIZE); > >> + snprintf(f_dev->bus_id, BUS_ID_SIZE, "fw-%s", dev->bus_id); > >> } > >> > > > > I would prefer if we use "firmware-%s" since the "fw" might collide with > > the new Firewire stack. Please change that and I agree. > > > > > > firmware-%s sounds more informative and cannot be mistaken with firewire > yes. > > Signed-off-by: Markus Rechberger Acked-by: Marcel Holtmann Regards Marcel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/