Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Dec 2022 09:18:46 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Vlim <vlim@gigadevice.com>
Cc:     Michael Walle <michael@walle.cc>,
        Victor Lim <victorswlim@gmail.com>,
        "tudor.ambarus@microchip.com" <tudor.ambarus@microchip.com>,
        "p.yadav@ti.com" <p.yadav@ti.com>,
        "richard@nod.at" <richard@nod.at>,
        "vigneshr@ti.com" <vigneshr@ti.com>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "vikhyat.goyal@amd.com" <vikhyat.goyal@amd.com>,
        "amit.kumar-mahapatra@amd.com" <amit.kumar-mahapatra@amd.com>,
        "alejandro.carmona@amd.com" <alejandro.carmona@amd.com>
Subject: Re: [PATCH] Linux: SPI: add Gigadevice part #
Message-ID: <20221206091846.02f6396f@xps-13>
In-Reply-To: <TY0PR06MB5658B73E2F22472D0AF48BDBBB1B9@TY0PR06MB5658.apcprd06.prod.outlook.com>
References: <20221204080000.4100-1-vlim@gigadevice.com>
        <dee37d18f8de5af7d07388031fc08571@walle.cc>
        <TY0PR06MB5658B73E2F22472D0AF48BDBBB1B9@TY0PR06MB5658.apcprd06.prod.outlook.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Vlim,

vlim@gigadevice.com wrote on Tue, 6 Dec 2022 01:27:13 +0000:

> Hi, Michael,
>=20
> I will redo the patch following this doc.
> At the meantime, can you point out a few mistakes that I am making so tha=
t I can correct it in the next submit.

Here are a few:
- The title is wrong (git log --oneline <file> for hints)
- The commit log is useless
- Don't make unrelated changes in your commit, one change =3D=3D one commit
- Don't change how the code looks like for no reason or justification

And please avoid top posting when answering.

Good luck!

Thanks,
Miqu=C3=A8l

>=20
> ________________________________
> From: Michael Walle <michael@walle.cc>
> Sent: Monday, December 5, 2022 00:22
> To: Victor Lim <victorswlim@gmail.com>
> Cc: tudor.ambarus@microchip.com <tudor.ambarus@microchip.com>; p.yadav@ti=
.com <p.yadav@ti.com>; miquel.raynal@bootlin.com <miquel.raynal@bootlin.com=
>; richard@nod.at <richard@nod.at>; vigneshr@ti.com <vigneshr@ti.com>; linu=
x-mtd@lists.infradead.org <linux-mtd@lists.infradead.org>; linux-kernel@vge=
r.kernel.org <linux-kernel@vger.kernel.org>; vikhyat.goyal@amd.com <vikhyat=
.goyal@amd.com>; amit.kumar-mahapatra@amd.com <amit.kumar-mahapatra@amd.com=
>; alejandro.carmona@amd.com <alejandro.carmona@amd.com>; Vlim <vlim@gigade=
vice.com>
> Subject: Re: [PATCH] Linux: SPI: add Gigadevice part #
>=20
> [You don't often get email from michael@walle.cc. Learn why this is impor=
tant at https://aka.ms/LearnAboutSenderIdentification ]
>=20
> =E6=AD=A4=E4=B8=BA=E5=A4=96=E9=83=A8=E9=82=AE=E4=BB=B6=EF=BC=8C=E8=B0=A8=
=E9=98=B2=E9=92=93=E9=B1=BC=E9=82=AE=E4=BB=B6=EF=BC=8C=E8=AF=B7=E6=B3=A8=E6=
=84=8F=E9=82=AE=E4=BB=B6=E6=98=AF=E5=90=A6=E6=B6=89=E5=8F=8A=E6=95=8F=E6=84=
=9F=E4=BF=A1=E6=81=AF
>=20
> This is an external email, beware of phishing emails. Please pay close at=
tention to whether the email contains sensitive information
>=20
>=20
> Hi,
>=20
> Am 2022-12-04 09:00, schrieb Victor Lim:
> > Edited gigadevice.c =20
>=20
> Please have a look at
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
>=20
> -michael